From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#39722: Support for bookmark.el in VC directory buffers Date: Wed, 13 May 2020 01:46:05 +0300 Message-ID: <87imh0n80q.fsf@mail.linkov.net> References: <4738c0198ff32df9ea59906ef055e68838e921f0.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="62450"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 39722@debbugs.gnu.org To: Matthias Meulien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 13 01:00:44 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jYdtE-000G87-9y for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 May 2020 01:00:44 +0200 Original-Received: from localhost ([::1]:51974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYdtD-0002P2-D5 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 May 2020 19:00:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYdsZ-0001la-GH for bug-gnu-emacs@gnu.org; Tue, 12 May 2020 19:00:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45288) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYdsZ-0007gE-7F for bug-gnu-emacs@gnu.org; Tue, 12 May 2020 19:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jYdsZ-0004a2-6C for bug-gnu-emacs@gnu.org; Tue, 12 May 2020 19:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 May 2020 23:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39722 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39722-submit@debbugs.gnu.org id=B39722.158932438917504 (code B ref 39722); Tue, 12 May 2020 23:00:03 +0000 Original-Received: (at 39722) by debbugs.gnu.org; 12 May 2020 22:59:49 +0000 Original-Received: from localhost ([127.0.0.1]:56823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYdsL-0004YG-DO for submit@debbugs.gnu.org; Tue, 12 May 2020 18:59:49 -0400 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:35433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYdsJ-0004Xu-RA for 39722@debbugs.gnu.org; Tue, 12 May 2020 18:59:48 -0400 Original-Received: from mail.gandi.net (m91-129-104-245.cust.tele2.ee [91.129.104.245]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 93E07200005; Tue, 12 May 2020 22:59:39 +0000 (UTC) In-Reply-To: <4738c0198ff32df9ea59906ef055e68838e921f0.camel@gmail.com> (Matthias Meulien's message of "Fri, 21 Feb 2020 22:19:34 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180130 Archived-At: > Being able to bookmark VC directory buffers is useful when working on > multiple projects; The proposed patch implements this on the lines of > what I read in info.el. Thanks, this is a useful addition. Please push it after fixing minor details: > +(defun vc-dir-bookmark-make-record () > + "This implements the `bookmark-make-record-function' type for > +`vc-dir' buffers." > ... > +(defun vc-dir-bookmark-jump (bmk) > + "This implements the `handler' function interface for the record > +type returned by `vc-dir-bookmark-make-record'." According to the documentation standard described in (info "(elisp) Documentation Tips") the first line of the docstring should consist of a complete sentence. I see that you copied the docstring from Info-bookmark-jump, but the docstrings of info.el contains a mistake that should be fixed in info.el.