unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Arne Babenhauserheide <arne_bab@web.de>
Cc: 39058@debbugs.gnu.org
Subject: bug#39058: 26.1; epg-sign-string should report an error if no pinentry is available
Date: Sun, 02 Aug 2020 11:33:53 +0200	[thread overview]
Message-ID: <87ime1jsse.fsf@gnus.org> (raw)
In-Reply-To: <87h814nwkd.fsf@web.de>

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I'm able to reproduce this when clicking "cancel" in the pinentry
> window -- no error is signalled anywhere, which I think it should be.
> I'll try to look into that.

Right.  When I press "cancel" in the pinentry window, there's no data
output in the egp buffer, but the following lands in the
epg-context-error-buffer...  and is then ignored, and we return a
success:

gpgsm: Note: non-critical certificate policy not allowed
gpgsm: Note: non-critical certificate policy not allowed
gpgsm: DBG: adding certificates at level -2
gpgsm: error creating signature: Operation cancelled <Pinentry>

I think I've now fixed this bit in Emacs 28.1.  It's likely this fix
also corrects signing when there's no pinentry program at all, but I'm
not sure how to test that.  Could you test the fix in Emacs 28.1?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  parent reply	other threads:[~2020-08-02  9:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-09 21:34 bug#39058: 26.1; epg-sign-string should report an error if no pinentry is available Arne Babenhauserheide
2020-08-02  8:49 ` Lars Ingebrigtsen
2020-08-02  9:29   ` Lars Ingebrigtsen
2020-08-02  9:33   ` Lars Ingebrigtsen [this message]
2020-10-26 15:47     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ime1jsse.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=39058@debbugs.gnu.org \
    --cc=arne_bab@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).