From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#39058: 26.1; epg-sign-string should report an error if no pinentry is available Date: Sun, 02 Aug 2020 11:33:53 +0200 Message-ID: <87ime1jsse.fsf@gnus.org> References: <87h814nwkd.fsf@web.de> <87v9i1l9f7.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25831"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39058@debbugs.gnu.org To: Arne Babenhauserheide Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 02 11:35:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2AOb-0006c5-Nv for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Aug 2020 11:35:09 +0200 Original-Received: from localhost ([::1]:44304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2AOa-0007U3-PO for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Aug 2020 05:35:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37934) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2AOU-0007Tc-EQ for bug-gnu-emacs@gnu.org; Sun, 02 Aug 2020 05:35:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58400) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k2AOU-0006Gw-5L for bug-gnu-emacs@gnu.org; Sun, 02 Aug 2020 05:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k2AOU-0003rm-1j for bug-gnu-emacs@gnu.org; Sun, 02 Aug 2020 05:35:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87h814nwkd.fsf@web.de> Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Aug 2020 09:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39058 X-GNU-PR-Package: emacs Original-Received: via spool by 39058-submit@debbugs.gnu.org id=B39058.159636084514794 (code B ref 39058); Sun, 02 Aug 2020 09:35:01 +0000 Original-Received: (at 39058) by debbugs.gnu.org; 2 Aug 2020 09:34:05 +0000 Original-Received: from localhost ([127.0.0.1]:41713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2ANZ-0003qY-4u for submit@debbugs.gnu.org; Sun, 02 Aug 2020 05:34:05 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:59534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2ANX-0003q4-3q for 39058@debbugs.gnu.org; Sun, 02 Aug 2020 05:34:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References:Subject: Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ikqq/r1ebKf1b5aUAE3sEAt4nt2xxcTnzo1Ta/7YzW4=; b=a0Y+UTPeqTIN2HNU8BGGIyV2rp NpT8CXuij+gzQNmF2FlCiU+S1rUQaELeZ6FpU9owuBfFC/BTPrsk8xWpsokuSyoBSVwtQgh/wFDum rVNzvcgi6XfRCycEfiwcLvJ8TyTl1X9yETCIGhCUw6GtIgaHIbRYvj83s4aqOyk3/6+o=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2ANO-0007ip-Qf; Sun, 02 Aug 2020 11:33:57 +0200 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183825 Archived-At: Lars Ingebrigtsen writes: > I'm able to reproduce this when clicking "cancel" in the pinentry > window -- no error is signalled anywhere, which I think it should be. > I'll try to look into that. Right. When I press "cancel" in the pinentry window, there's no data output in the egp buffer, but the following lands in the epg-context-error-buffer... and is then ignored, and we return a success: gpgsm: Note: non-critical certificate policy not allowed gpgsm: Note: non-critical certificate policy not allowed gpgsm: DBG: adding certificates at level -2 gpgsm: error creating signature: Operation cancelled I think I've now fixed this bit in Emacs 28.1. It's likely this fix also corrects signing when there's no pinentry program at all, but I'm not sure how to test that. Could you test the fix in Emacs 28.1? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no