From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Fu, Yuan" <ykf5041@psu.edu>
Cc: 42272@debbugs.gnu.org
Subject: bug#42272: 27.0.91; [PATCH] Fix doc-view rescale
Date: Wed, 05 Aug 2020 17:13:03 +0200 [thread overview]
Message-ID: <87imdxjfcw.fsf@gnus.org> (raw)
In-Reply-To: <222D27A6-231C-4B9C-9577-E28F75A80869@psu.edu> (Yuan Fu's message of "Wed, 8 Jul 2020 19:30:34 +0000")
"Fu, Yuan" <ykf5041@psu.edu> writes:
> In Emacs 27, doc-view doesn’t to image rescaling if imagemagick is not
> present. However, since we have native image rescaling now, we want
> to rescale regardless of imagemagick. I also added convenient
> centering commands to doc-view.el. Note that the patch is made on
> Emacs master branch.
The imagemagick fixes look good to me, and the new functionality, too.
But this should probably be done in two separate patches, and the patch
with the new functionality also needs to be documented in the Document
View node in the misc.texi manual. (And it also needs an etc/NEWS
entry.)
Can you do the patch splitting and documentation additions and resubmit?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-08-05 15:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 19:30 bug#42272: 27.0.91; [PATCH] Fix doc-view rescale Fu, Yuan
2020-08-05 15:13 ` Lars Ingebrigtsen [this message]
2020-08-07 1:29 ` Yuan Fu
2020-08-07 7:10 ` Lars Ingebrigtsen
2020-08-13 19:34 ` Fu, Yuan
2020-08-14 11:53 ` Lars Ingebrigtsen
2020-08-14 15:02 ` Yuan Fu
2020-08-14 15:43 ` Lars Ingebrigtsen
2020-08-14 16:39 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imdxjfcw.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=42272@debbugs.gnu.org \
--cc=ykf5041@psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).