From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#42272: 27.0.91; [PATCH] Fix doc-view rescale Date: Wed, 05 Aug 2020 17:13:03 +0200 Message-ID: <87imdxjfcw.fsf@gnus.org> References: <222D27A6-231C-4B9C-9577-E28F75A80869@psu.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1002"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 42272@debbugs.gnu.org To: "Fu, Yuan" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 05 17:14:38 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k3L7l-00006J-PE for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Aug 2020 17:14:37 +0200 Original-Received: from localhost ([::1]:39470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3L7k-0003Tz-QB for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Aug 2020 11:14:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3L7E-00031k-8G for bug-gnu-emacs@gnu.org; Wed, 05 Aug 2020 11:14:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40426) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k3L7D-00089f-Tt for bug-gnu-emacs@gnu.org; Wed, 05 Aug 2020 11:14:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k3L7D-0000QY-Pp for bug-gnu-emacs@gnu.org; Wed, 05 Aug 2020 11:14:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Aug 2020 15:14:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42272 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42272-submit@debbugs.gnu.org id=B42272.15966404031484 (code B ref 42272); Wed, 05 Aug 2020 15:14:03 +0000 Original-Received: (at 42272) by debbugs.gnu.org; 5 Aug 2020 15:13:23 +0000 Original-Received: from localhost ([127.0.0.1]:51957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3L6Z-0000Ns-11 for submit@debbugs.gnu.org; Wed, 05 Aug 2020 11:13:23 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:42786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3L6X-0000Nb-JE for 42272@debbugs.gnu.org; Wed, 05 Aug 2020 11:13:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=HdRJC8MxzdeDfWalDEE5MUNTR8xrTWcw+ysl269z2Mg=; b=ub8oRnWSmmVC9wsK5CCB22j+dH Y27oDB+Jer12fY5ofUCVzlDLRjzbHikSvGE0cpj6ihHMFPjfVKbflrrnWMMLY/VqQ97ZM3EEtG11Q g/bK8YiYaWj9gip/8fent9NSQ4TNNIAqpCSK3DaR0Ttin2YvwzK0U/qzfwNx5IFf6ir0=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k3L6H-000618-3d; Wed, 05 Aug 2020 17:13:07 +0200 In-Reply-To: <222D27A6-231C-4B9C-9577-E28F75A80869@psu.edu> (Yuan Fu's message of "Wed, 8 Jul 2020 19:30:34 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184109 Archived-At: "Fu, Yuan" writes: > In Emacs 27, doc-view doesn=E2=80=99t to image rescaling if imagemagick i= s not > present. However, since we have native image rescaling now, we want > to rescale regardless of imagemagick. I also added convenient > centering commands to doc-view.el. Note that the patch is made on > Emacs master branch. The imagemagick fixes look good to me, and the new functionality, too. But this should probably be done in two separate patches, and the patch with the new functionality also needs to be documented in the Document View node in the misc.texi manual. (And it also needs an etc/NEWS entry.) Can you do the patch splitting and documentation additions and resubmit? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no