bug#44937: 28.0.50; [PATCH] Make log-view-commit-body face less intrusive

bug#44937: 28.0.50; [PATCH] Make log-view-commit-body face less intrusive

[Protesilaos Stavrou]

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

In light of the latest feedback in bug#44424, please find attached a
patch that makes the new log-view-commit-body face look exactly like the
design it replaced in log-view buffers.

The idea is to avoid introducing a disruptive change, while still
providing a face that themes or users can configure to match their
needs.

What do you think?

-- 
Protesilaos Stavrou
protesilaos.com

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Make-log-view-commit-body-less-intrusive.patch --]
[-- Type: text/x-patch, Size: 1399 bytes --]

From 7ca7f7918f4d03aeab5d67fd72ea371443ac174f Mon Sep 17 00:00:00 2001
From: Protesilaos Stavrou <info@protesilaos.com>
Date: Sun, 29 Nov 2020 02:10:43 +0200
Subject: [PATCH] Make log-view-commit-body less intrusive

* lisp/vc/log-view.el (log-view-commit-body): Inherit from
font-lock-comment-face.  This makes expanded commit messages in
log-view look the same as they did prior to commit 1f0b929430 (consult
bug#44424).
---
 lisp/vc/log-view.el | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el
index 56ecc64671..e7b6eea807 100644
--- a/lisp/vc/log-view.el
+++ b/lisp/vc/log-view.el
@@ -208,15 +208,7 @@ If it is nil, `log-view-toggle-entry-display' does nothing.")
   "Face for the message header line in `log-view-mode'."
   :group 'log-view)
 
-(defface log-view-commit-body
-  '((((class color) (min-colors 88) (background light))
-     :background "gray95" :foreground "black" :extend t)
-    (((class color) (min-colors 88) (background dark))
-     :background "gray5" :foreground "white" :extend t)
-    (((class color) (min-colors 8) (background light))
-     :foreground "black")
-    (((class color) (min-colors 8) (background dark))
-     :foreground "white"))
+(defface log-view-commit-body '((t :inherit font-lock-comment-face))
   "Face for the commit body in `log-view-mode'."
   :version "28.1")
 
-- 
2.29.2

bug#44937: 28.0.50; [PATCH] Make log-view-commit-body face less intrusive

[Lars Ingebrigtsen]

Protesilaos Stavrou <info@protesilaos.com> writes:

> In light of the latest feedback in bug#44424, please find attached a
> patch that makes the new log-view-commit-body face look exactly like the
> design it replaced in log-view buffers.
>
> The idea is to avoid introducing a disruptive change, while still
> providing a face that themes or users can configure to match their
> needs.
>
> What do you think?

Looks good to me; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44937: 28.0.50; [PATCH] Make log-view-commit-body face less intrusive

[Dmitry Gutov]

On 29.11.2020 12:44, Lars Ingebrigtsen wrote:
> Protesilaos Stavrou<info@protesilaos.com>  writes:
> 
>> In light of the latest feedback in bug#44424, please find attached a
>> patch that makes the new log-view-commit-body face look exactly like the
>> design it replaced in log-view buffers.
>>
>> The idea is to avoid introducing a disruptive change, while still
>> providing a face that themes or users can configure to match their
>> needs.
>>
>> What do you think?
> Looks good to me; applied to Emacs 28.

Thanks!

bug#44937: 28.0.50; [PATCH] Make log-view-commit-body face less intrusive

[Protesilaos Stavrou]

On 2020-11-29, 12:51 +0200, Dmitry Gutov <dgutov@yandex.ru> wrote:

> On 29.11.2020 12:44, Lars Ingebrigtsen wrote:
>> Protesilaos Stavrou<info@protesilaos.com>  writes:
>> 
>>> In light of the latest feedback in bug#44424, please find attached a
>>> patch that makes the new log-view-commit-body face look exactly like the
>>> design it replaced in log-view buffers.
>>>
>>> The idea is to avoid introducing a disruptive change, while still
>>> providing a face that themes or users can configure to match their
>>> needs.
>>>
>>> What do you think?
>> Looks good to me; applied to Emacs 28.
>
> Thanks!

Had not realised we can reply to those... Thank you!

-- 
Protesilaos Stavrou
protesilaos.com