From: Michael Albinus <michael.albinus@gmx.de>
To: Boruch Baum <boruch_baum@gmx.com>
Cc: 48072@debbugs.gnu.org
Subject: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH]
Date: Wed, 28 Apr 2021 14:13:38 +0200 [thread overview]
Message-ID: <87im4661zh.fsf@gmx.de> (raw)
In-Reply-To: <20210428120011.5g73ctmekbff42gf@E15-2016.optimum.net> (Boruch Baum's message of "Wed, 28 Apr 2021 08:00:11 -0400")
Boruch Baum <boruch_baum@gmx.com> writes:
Hi Boruch,
>> > + (unless (executable-find command)
>> > + (user-error "Not a valid command!"))
>>
>> This doesn't check the remote case.
>
> Good point. It's an area of dired I'm weak in because I don't use it.
> How about the following (with the update diredc regex):
>
> (unless (executable-find
> (if (string-match "^ *\\([^ ]+\\) " command)
> (substring command (match-beginning 1) (match-end 1))
> command)
> (file-remote-p file))
> (user-error "Not a valid command!"))
Instead of (file-remote-p file) you could always use t. If
default-directory is local, it doesn't hurt.
Best regards, Michael.
next prev parent reply other threads:[~2021-04-28 12:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 19:02 bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] Boruch Baum
2021-04-27 19:19 ` Eli Zaretskii
2021-04-27 19:32 ` Boruch Baum
2021-04-28 2:22 ` Eli Zaretskii
2021-04-28 3:00 ` Boruch Baum
2021-04-28 6:19 ` Kévin Le Gouguec
2021-04-28 9:33 ` Boruch Baum
2021-04-28 9:50 ` Boruch Baum
2021-04-28 11:58 ` Eli Zaretskii
2021-04-28 12:49 ` Boruch Baum
2021-04-28 13:03 ` Eli Zaretskii
2021-04-28 15:01 ` Boruch Baum
2021-04-28 15:13 ` Eli Zaretskii
2021-04-28 15:21 ` Boruch Baum
2021-04-28 15:52 ` Eli Zaretskii
2021-04-28 17:10 ` Michael Albinus
2021-04-28 15:16 ` Boruch Baum
2021-04-28 11:47 ` Eli Zaretskii
2021-04-28 11:03 ` Michael Albinus
2021-04-28 12:00 ` Boruch Baum
2021-04-28 12:13 ` Michael Albinus [this message]
2021-04-28 12:46 ` Boruch Baum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im4661zh.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=48072@debbugs.gnu.org \
--cc=boruch_baum@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).