unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Boruch Baum <boruch_baum@gmx.com>
Cc: 48072@debbugs.gnu.org
Subject: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH]
Date: Tue, 27 Apr 2021 22:19:22 +0300	[thread overview]
Message-ID: <83lf93h6x1.fsf@gnu.org> (raw)
In-Reply-To: <20210427190243.n5yg3gywd5wma3jl@E15-2016.optimum.net> (message from Boruch Baum on Tue, 27 Apr 2021 15:02:43 -0400)

> Date: Tue, 27 Apr 2021 15:02:43 -0400
> From: Boruch Baum <boruch_baum@gmx.com>
> 
> Function dired-read-shell-command was accepting an empty input. This is
> a bug because it then passes the empty input as a legitimate command
> which is silently processed (in error) by dired, eventually to return a
> completion message.

I'm not sure we want to disallow this.  (Wasn't there a similar
discussion recently?)

> validates the entered command as a valid shell executable.

This is certainly a mistake: a valid shell command doesn't have to be
a file that executable-find is able to find.  Shells are known to
support all kinds of internal and magic commands.

Thanks.





  reply	other threads:[~2021-04-27 19:19 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-27 19:02 bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] Boruch Baum
2021-04-27 19:19 ` Eli Zaretskii [this message]
2021-04-27 19:32   ` Boruch Baum
2021-04-28  2:22     ` Eli Zaretskii
2021-04-28  3:00       ` Boruch Baum
2021-04-28  6:19         ` Kévin Le Gouguec
2021-04-28  9:33           ` Boruch Baum
2021-04-28  9:50           ` Boruch Baum
2021-04-28 11:58             ` Eli Zaretskii
2021-04-28 12:49               ` Boruch Baum
2021-04-28 13:03                 ` Eli Zaretskii
2021-04-28 15:01                   ` Boruch Baum
2021-04-28 15:13                     ` Eli Zaretskii
2021-04-28 15:21                       ` Boruch Baum
2021-04-28 15:52                         ` Eli Zaretskii
2021-04-28 17:10                           ` Michael Albinus
2021-04-28 15:16                   ` Boruch Baum
2021-04-28 11:47           ` Eli Zaretskii
2021-04-28 11:03 ` Michael Albinus
2021-04-28 12:00   ` Boruch Baum
2021-04-28 12:13     ` Michael Albinus
2021-04-28 12:46       ` Boruch Baum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83lf93h6x1.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=48072@debbugs.gnu.org \
    --cc=boruch_baum@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).