From: Matthias Meulien <orontee@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 51016@debbugs.gnu.org
Subject: bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers
Date: Mon, 22 Nov 2021 23:11:46 +0100 [thread overview]
Message-ID: <87ilwj3knx.fsf@gmail.com> (raw)
In-Reply-To: <87mtlx2y3b.fsf@gmail.com> (Matthias Meulien's message of "Sun, 21 Nov 2021 18:54:48 +0100")
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
Matthias Meulien <orontee@gmail.com> writes:
> Juri Linkov <juri@linkov.net> writes:
>
>> I confirm there is a relation because the commit f0768d3145
>
> Oh you're right. Sorry.
>
>> However, changing the .+ thing to .* in outline-font-lock-keywords
>> fixes this problem. So we need to decide whether to try to remove
>> entire line mathing from diff-hunk-header-re (not sure how easy to
>> do),
I just skipped last character of `diff-hunk-header-re' (the culprit `$')
when building `diff-outline-regexp'; Cycling is restored when on hunk
headers. Looks safe to me since `diff-hunk-header-re' is unchanged.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-broken-outline-minor-mode-cycling-in-diff-buffer.patch --]
[-- Type: text/x-diff, Size: 979 bytes --]
From cf4ccd97e6d6e82faee5b01224c5a3caa8908cc1 Mon Sep 17 00:00:00 2001
From: Matthias Meulien <orontee@gmail.com>
Date: Mon, 22 Nov 2021 23:06:06 +0100
Subject: [PATCH] Fix broken outline minor mode cycling in diff buffers
* lisp/vc/diff-mode.el (diff-setup-buffer-type): Fix outline regexp
matching whole line
---
lisp/vc/diff-mode.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/vc/diff-mode.el b/lisp/vc/diff-mode.el
index 8f83aa580e..eeda503afb 100644
--- a/lisp/vc/diff-mode.el
+++ b/lisp/vc/diff-mode.el
@@ -1588,7 +1588,8 @@ diff-setup-buffer-type
nil)))
(when (eq diff-buffer-type 'git)
(setq diff-outline-regexp
- (concat "\\(^diff --git.*\n\\|" diff-hunk-header-re "\\)"))
+ (concat "\\(^diff --git.*\n\\|"
+ (substring diff-hunk-header-re 0 -1) "\\)"))
(setq-local outline-level #'diff--outline-level))
(setq-local outline-regexp diff-outline-regexp))
--
2.30.2
[-- Attachment #3: Type: text/plain, Size: 14 bytes --]
--
Matthias
next prev parent reply other threads:[~2021-11-22 22:11 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 21:05 bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers Matthias Meulien
2021-10-09 0:26 ` bug#51016: Status: " Matthias Meulien
2021-10-09 0:37 ` Matthias Meulien
2021-10-13 20:30 ` bug#51016: " Matthias Meulien
2021-11-05 2:51 ` Lars Ingebrigtsen
2021-11-06 16:40 ` Juri Linkov
2021-11-06 18:30 ` Lars Ingebrigtsen
2021-11-08 22:38 ` Matthias Meulien
2021-11-09 3:47 ` Lars Ingebrigtsen
2021-11-09 8:19 ` Juri Linkov
2021-11-18 18:06 ` Juri Linkov
2021-11-19 7:22 ` Lars Ingebrigtsen
2021-11-19 8:31 ` Juri Linkov
2021-11-20 8:37 ` Lars Ingebrigtsen
2021-11-20 19:17 ` Juri Linkov
2021-11-21 17:02 ` Lars Ingebrigtsen
2021-11-21 17:26 ` Matthias Meulien
2021-11-21 17:41 ` Juri Linkov
2021-11-21 17:54 ` Matthias Meulien
2021-11-22 22:11 ` Matthias Meulien [this message]
2021-11-22 23:03 ` Matthias Meulien
2021-11-24 6:54 ` Lars Ingebrigtsen
2021-11-24 18:48 ` Juri Linkov
2021-12-15 17:08 ` Juri Linkov
2021-12-16 5:50 ` Lars Ingebrigtsen
2021-12-16 17:22 ` Juri Linkov
2021-12-16 17:48 ` Eli Zaretskii
2021-12-16 19:04 ` Juri Linkov
2021-12-16 20:06 ` Eli Zaretskii
2021-12-16 21:02 ` Kévin Le Gouguec
2021-12-17 6:36 ` Eli Zaretskii
2021-12-17 7:07 ` Kévin Le Gouguec
2021-12-17 7:55 ` Eli Zaretskii
2021-12-17 21:27 ` Kévin Le Gouguec
2021-12-18 6:23 ` Eli Zaretskii
2021-12-18 9:18 ` Kévin Le Gouguec
2021-12-18 17:05 ` Juri Linkov
2021-12-18 17:52 ` Eli Zaretskii
2021-12-18 19:43 ` Kévin Le Gouguec
2021-12-18 20:03 ` Eli Zaretskii
2021-12-18 23:30 ` Kévin Le Gouguec
2021-12-19 11:00 ` Lars Ingebrigtsen
2021-12-19 11:27 ` Eli Zaretskii
2021-12-17 4:25 ` Richard Stallman
2021-11-21 17:49 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilwj3knx.fsf@gmail.com \
--to=orontee@gmail.com \
--cc=51016@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).