From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Alfred M. Szmidt" <ams@gnu.org>
Cc: 55310@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#55310: 27.2; vc-revert: unhelpful error message when modified buffers exist
Date: Mon, 09 May 2022 11:38:26 +0200 [thread overview]
Message-ID: <87ilqfcagd.fsf@gnus.org> (raw)
In-Reply-To: <E1nnhoI-0007PC-RC@fencepost.gnu.org> (Alfred M. Szmidt's message of "Sun, 08 May 2022 10:22:58 -0400")
"Alfred M. Szmidt" <ams@gnu.org> writes:
> I don't think we want to have an interface that offers to kill buffers
> in a loop -- it sounds like something that's really error-prone, which
> is why that code is the way it is, I think. (To make the user make the
> decision themselves explicitly.)
>
> We already support such mechanism I think in several other places,
> like ibuffer, etc.
Sure, but that's a mode to list and act on buffers -- having vc-revert
kill buffers (even after querying the user) would be surprising.
> My main problem is really that it is impossible to know _which_
> buffers are modified, if you have several hundred open in several
> different projects -- in addition to the fact that the error message
> is just wrong ("all buffers" -- it is just some buffers, that are
> marked).
Yes, it would be nice if it actually said which buffers it's talking
about.
> Idea (ideas are cheap): maybe if one could add some sort of
> high-light, or something in vc-dired that shows that this or that file
> has a open buffer that is unmodified, and then the error could be the
> same but just saying that one should check the highlighted buffers.
I think that's a good idea -- perhaps Dmitry has some comments; added to
the CCs.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2022-05-09 9:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-08 7:41 bug#55310: 27.2; vc-revert: unhelpful error message when modified buffers exist Alfred M. Szmidt
2022-05-08 11:44 ` Lars Ingebrigtsen
2022-05-08 14:22 ` Alfred M. Szmidt
2022-05-09 9:38 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilqfcagd.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=55310@debbugs.gnu.org \
--cc=ams@gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).