From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#55310: 27.2; vc-revert: unhelpful error message when modified buffers exist Date: Mon, 09 May 2022 11:38:26 +0200 Message-ID: <87ilqfcagd.fsf@gnus.org> References: <87y1zcjljm.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9252"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 55310@debbugs.gnu.org, Dmitry Gutov To: "Alfred M. Szmidt" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 09 11:53:00 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1no04Z-0002Ca-Uc for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 May 2022 11:52:59 +0200 Original-Received: from localhost ([::1]:32898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1no04Y-00007U-Ix for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 May 2022 05:52:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnzr4-0003cq-Mg for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 05:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33987) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nnzr4-0002j2-C6 for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 05:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nnzr4-0002k9-A1 for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 05:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 May 2022 09:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55310 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 55310-submit@debbugs.gnu.org id=B55310.165208911610513 (code B ref 55310); Mon, 09 May 2022 09:39:02 +0000 Original-Received: (at 55310) by debbugs.gnu.org; 9 May 2022 09:38:36 +0000 Original-Received: from localhost ([127.0.0.1]:56117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nnzqe-0002jV-Im for submit@debbugs.gnu.org; Mon, 09 May 2022 05:38:36 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:39842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nnzqc-0002jH-MB for 55310@debbugs.gnu.org; Mon, 09 May 2022 05:38:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=z+AblMsPep8f1IgVAqrtkVeKoX1mlzCh+zCiruhq92o=; b=CBQy40VXifa8afaJtPBOhClGQ3 xoWsmB9ojuRnX2KEFeAIeuKDw2iQchn3HeDC/Ai77KIqzdILr9ydePh27FTcmBSR1DEjzjciIB04d Tr/JfwbfuqKDKrgkskDOq3n6X6a0jTEbds/r5/H4HunIAaduuZ7BZxt4vdPzRnVPC3sY=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nnzqU-00044d-Jj; Mon, 09 May 2022 11:38:28 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAIVBMVEX9/f0hDA67wq9T qNr2723e3diWXk27olJdTkhSp7b///+JyUX3AAAAAWJLR0QKaND0VgAAAAd0SU1FB+YFCQkjMC6A 7ocAAAGVSURBVDjLtdG/T4NAFAfwy5Grrmdsy4inJR2bEBO7GYLWkTQe0c0QSxlNh9qx0BRulsX7 b70fTXtAm+jgGxj48H3v3gHAoS4sz/NAoIoa70FvD0sBiO6RaVgmCZujIwkBaQ2QmhHKVqvABGiC ORx2JXQuFdy3Ei8SnoKH1owjoE8V9QQ8Br4JtgQ616uboBak722wT4AeTssW6D12YJ6q8yuobd6F nneXMblIEJrQF4kMZ7jfAFAg8ooF2I1Was4BIocs4imcExK7cX6GRfUUDNcJWxPIooLlcY4k9NVx h9uU5QQWLkvLPEcMY7tU4G6ZTrC02OYI6k4CosQlcURcogpNRWJS3xwl8pHZYg9KqbFHlHyIJTFm 2JZfHMD9jAlZiU4423DOzcQMDDN5XLypxgagQYjKKw21hKpzBRWvmgDle3vMq3ED0Le4w4o34DkI fNG94k2QV8F1/St83fhkQK+92ybsLtwanQA4+ksCib9kOcBCoeOEFISIEt8PEllvwApbicmC6kQD Jhrqw8Ul6lYzgEY/cgiymJjq9IAAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjItMDUtMDlUMDk6MzU6 NDgrMDA6MDCOxssmAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTA1LTA5VDA5OjM1OjQ4KzAwOjAw /5tzmgAAAABJRU5ErkJggg== X-Now-Playing: Blaine L. Reininger's _Broken Fingers_: "Broken Fingers" In-Reply-To: (Alfred M. Szmidt's message of "Sun, 08 May 2022 10:22:58 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231703 Archived-At: "Alfred M. Szmidt" writes: > I don't think we want to have an interface that offers to kill buffers > in a loop -- it sounds like something that's really error-prone, which > is why that code is the way it is, I think. (To make the user make the > decision themselves explicitly.) > > We already support such mechanism I think in several other places, > like ibuffer, etc. Sure, but that's a mode to list and act on buffers -- having vc-revert kill buffers (even after querying the user) would be surprising. > My main problem is really that it is impossible to know _which_ > buffers are modified, if you have several hundred open in several > different projects -- in addition to the fact that the error message > is just wrong ("all buffers" -- it is just some buffers, that are > marked). Yes, it would be nice if it actually said which buffers it's talking about. > Idea (ideas are cheap): maybe if one could add some sort of > high-light, or something in vc-dired that shows that this or that file > has a open buffer that is unmodified, and then the error could be the > same but just saying that one should check the highlighted buffers. I think that's a good idea -- perhaps Dmitry has some comments; added to the CCs. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no