bug#56976: 29.0.50; Obsolete netrc.el

bug#56976: 29.0.50; Obsolete netrc.el

[Lars Ingebrigtsen]

It'd be nice to obsolete netrc.el, since the functionality is duplicated
by auth-source, and is broken for non-ASCII chars etc.

There's only one in-tree usage of netrc-parse, and that's in
tramp-parse-netrc.  This could be changed to use
`auth-source-netrc-parse' instead, but in earlier versions of that
function, it'd return nil when not specifying the host/user/ports, which
made it not quite compatible.  I've now changed that, but I'm not sure
what the compat situation is here (i.e., if this Tramp has to work in
older Emacs versions or not).


In GNU Emacs 29.0.50 (build 29, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.16.0)
 of 2022-08-04 built on joga
Repository revision: 3e60f7f3c31a8491b085684121e5229be56b3538
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101003
System Description: Ubuntu 22.04 LTS

bug#56976: 29.0.50; Obsolete netrc.el

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> It'd be nice to obsolete netrc.el, since the functionality is duplicated
> by auth-source, and is broken for non-ASCII chars etc.
>
> There's only one in-tree usage of netrc-parse, and that's in
> tramp-parse-netrc.  This could be changed to use
> `auth-source-netrc-parse' instead, but in earlier versions of that
> function, it'd return nil when not specifying the host/user/ports, which
> made it not quite compatible.  I've now changed that, but I'm not sure
> what the compat situation is here (i.e., if this Tramp has to work in
> older Emacs versions or not).

(Adding Michael to the CCs.)

bug#56976: 29.0.50; Obsolete netrc.el

[Michael Albinus]

Lars Ingebrigtsen <larsi@gnus.org> writes:

Hi Lars,

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> It'd be nice to obsolete netrc.el, since the functionality is duplicated
>> by auth-source, and is broken for non-ASCII chars etc.
>>
>> There's only one in-tree usage of netrc-parse, and that's in
>> tramp-parse-netrc.  This could be changed to use
>> `auth-source-netrc-parse' instead, but in earlier versions of that
>> function, it'd return nil when not specifying the host/user/ports, which
>> made it not quite compatible.  I've now changed that, but I'm not sure
>> what the compat situation is here (i.e., if this Tramp has to work in
>> older Emacs versions or not).

*This Tramp* has to work back with Emacs 26. Don't worry, I will check
the compatibility status after your commit, and adjust as needed.

> (Adding Michael to the CCs.)

I'm scanning all new messages in the groups I read on gmane for some
buzzwords, like "tramp". Those messages will be presented to me first :-)

Thanks to automated gnus-summary-search-article-forward.

Best regards, Michael.

bug#56976: 29.0.50; Obsolete netrc.el

[Lars Ingebrigtsen]

Michael Albinus <michael.albinus@gmx.de> writes:

> *This Tramp* has to work back with Emacs 26. Don't worry, I will check
> the compatibility status after your commit, and adjust as needed.

The problem is that until earlier today, auth-source-netrc-parse just
returned nil if called with no host/user parameters, so I don't know
what the compat check would be.

Perhaps it'd be more convenient if there was a new function like
`auth-source-netrc-parse-all-entries' that tramp.el could check for the
presence of?  Would that help?  (It would just be an alias, probably.)

> I'm scanning all new messages in the groups I read on gmane for some
> buzzwords, like "tramp". Those messages will be presented to me first :-)
>
> Thanks to automated gnus-summary-search-article-forward.

:-)

bug#56976: 29.0.50; Obsolete netrc.el

[Michael Albinus]

Lars Ingebrigtsen <larsi@gnus.org> writes:

Hi Lars,

>> *This Tramp* has to work back with Emacs 26. Don't worry, I will check
>> the compatibility status after your commit, and adjust as needed.
>
> The problem is that until earlier today, auth-source-netrc-parse just
> returned nil if called with no host/user parameters, so I don't know
> what the compat check would be.

I could check whether netrc-parse is obsolete. In that case,
auth-source-netrc-parse would be in play.

Best regards, Michael.

bug#56976: 29.0.50; Obsolete netrc.el

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Perhaps it'd be more convenient if there was a new function like
> `auth-source-netrc-parse-all-entries' that tramp.el could check for the
> presence of?

I've now done this, and partially reverted previous change, because the
change in behaviour might break things.

So I'll go ahead and change the Tramp code to use
`auth-source-netrc-parse-all', and leave the further adjustments to you?

bug#56976: 29.0.50; Obsolete netrc.el

[Michael Albinus]

Lars Ingebrigtsen <larsi@gnus.org> writes:

Hi Lars,

>> Perhaps it'd be more convenient if there was a new function like
>> `auth-source-netrc-parse-all-entries' that tramp.el could check for the
>> presence of?
>
> I've now done this, and partially reverted previous change, because the
> change in behaviour might break things.
>
> So I'll go ahead and change the Tramp code to use
> `auth-source-netrc-parse-all', and leave the further adjustments to you?

In general yes, but why the new alias? What's wrong with my proposal
checking obsolescence of netrc-parse?

I try to keep it as simple as possible, and introducing a new alias for
exactly one use case, which has a planned suicide date (compatibility of
Tramp), seems too much for me.

Best regards, Michael.

bug#56976: 29.0.50; Obsolete netrc.el

[Lars Ingebrigtsen]

Michael Albinus <michael.albinus@gmx.de> writes:

>> I've now done this, and partially reverted previous change, because the
>> change in behaviour might break things.
>>
>> So I'll go ahead and change the Tramp code to use
>> `auth-source-netrc-parse-all', and leave the further adjustments to you?
>
> In general yes, but why the new alias? What's wrong with my proposal
> checking obsolescence of netrc-parse?

I decided against the alias, because my first change (to just make
missing/nil host etc return all entries) wasn't quite
backwards-compatible enough, so it wasn't a good idea in the first
place.

So a new function is needed in any case.

bug#56976: 29.0.50; Obsolete netrc.el

[Michael Albinus]

Lars Ingebrigtsen <larsi@gnus.org> writes:

Hi Lars,

>>> So I'll go ahead and change the Tramp code to use
>>> `auth-source-netrc-parse-all', and leave the further adjustments to you?

Should be fixed now in master.

Best regards, Michael.

bug#56976: 29.0.50; Obsolete netrc.el

[Lars Ingebrigtsen]

Michael Albinus <michael.albinus@gmx.de> writes:

> Should be fixed now in master.

Thanks.

bug#56976: 29.0.50; Obsolete netrc.el

[Lars Ingebrigtsen]

I've now made the adjustments and made netrc.el obsolete.