bug#50970: 29.0.50; Italics cause fill column indicator misalignment

bug#50970: 29.0.50; Italics cause fill column indicator misalignment

[Carlos Pita]

[-- Attachment #1: Type: text/plain, Size: 5690 bytes --]

I believe the attached screenshot describes the issue well enough.

Best regards,
Carlos

—

In GNU Emacs 29.0.50 (build 1, x86_64-apple-darwin20.6.0, NS
appkit-2022.60 Version 11.6 (Build 20G165))
 of 2021-10-02 built on Carloss-MacBook-Pro.local
Windowing system distributor 'Apple', version 10.3.2022
System Description:  macOS 11.6

Configured using:
 'configure --disable-dependency-tracking --disable-silent-rules
 --enable-locallisppath=/usr/local/share/emacs/site-lisp
 --infodir=/usr/local/Cellar/emacs-plus@28/28.0.50/share/info/emacs
 --prefix=/usr/local/Cellar/emacs-plus@28/28.0.50 --with-xml2
 --with-gnutls --without-dbus --with-imagemagick --with-modules
 --with-rsvg --with-ns --disable-ns-self-contained'

Configured features:
ACL GLIB GMP GNUTLS IMAGEMAGICK JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY
KQUEUE NS PDUMPER PNG RSVG THREADS TIFF TOOLKIT_SCROLL_BARS XIM ZLIB

Important settings:
  value of $LC_CTYPE: UTF-8
  value of $LANG: en_AR.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Python

Minor modes in effect:
  shell-dirtrack-mode: t
  display-fill-column-indicator-mode: t
  flymake-mode: t
  recentf-mode: t
  my-fill-mode: t
  delete-selection-mode: t
  winner-mode: t
  org-roam-db-autosync-mode: t
  outline-minor-mode: t
  ns-auto-titlebar-mode: t
  ido-ubiquitous-mode: t
  ido-everywhere: t
  global-company-mode: t
  company-mode: t
  electric-pair-mode: t
  cua-mode: t
  show-paren-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  auto-fill-function: python-do-auto-fill
  transient-mark-mode: t

Load-path shadows:
/Users/carlos/.emacs.d/elpa/magit-20210928.1325/magit-section-pkg
hides /Users/carlos/.emacs.d/elpa/magit-section-20210829.1849/magit-section-pkg
/Users/carlos/.emacs.d/elpa/transient-20210920.1038/transient hides
/usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/29.0.50/lisp/transient

Features:
(shadow sort flyspell ispell mail-extr emacsbug message rfc822 mml
mml-sec epa derived epg rfc6068 epg-config gnus-util rmail
rmail-loaddefs mm-decode mm-bodies mm-encode mailabbrev gmm-utils
mailheader sendmail mail-utils vc-git diff-mode vc-dispatcher python
tramp-sh tramp tramp-loaddefs trampver tramp-integration files-x
tramp-compat shell parse-time iso8601 ls-lisp dired-aux doc-view
jka-compr image-mode exif display-fill-column-indicator checkdoc
lisp-mnt dired-x dired dired-loaddefs flymake-proc flymake compile
text-property-search warnings thingatpt visual-fill-column recentf
tree-widget exec-path-from-shell doom-themes-ext-org
doom-themes-ext-visual-bell face-remap cl-extra help-mode
company-oddmuse company-keywords company-etags etags fileloop xref
project company-gtags company-dabbrev-code company-dabbrev company-files
company-clang company-capf company-cmake company-semantic
company-template company-bbdb doom-solarized-light-theme doom-themes
doom-themes-base delsel winner org-roam-migrate org-roam-mode
org-roam-capture org-roam-node org-roam-db org-roam-utils
org-roam-compat org-roam org-capture org-element avl-tree generator
org-id org-refile org ob ob-tangle ob-ref ob-lob ob-table ob-exp
org-macro org-footnote org-src ob-comint org-pcomplete pcomplete comint
ansi-color ring org-list org-faces org-entities time-date noutline
outline easy-mmode org-version ob-emacs-lisp ob-core ob-eval org-table
ol org-keys oc org-compat org-macs org-loaddefs format-spec find-func
cal-menu calendar cal-loaddefs emacsql-sqlite url-http url-auth
mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr url-gw
nsm rmc puny advice emacsql emacsql-compiler magit-section rx f dash s
ns-auto-titlebar ido-completing-read+ memoize cus-edit pp wid-edit
minibuf-eldef ido company edmacro kmacro pcase elec-pair cua-base
cus-load finder-inf info package browse-url url url-proxy url-privacy
url-expand url-methods url-history url-cookie url-domsuf url-util
mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core
cl-macs eieio-loaddefs password-cache json map url-vars seq gv subr-x
byte-opt bytecomp byte-compile cconv cl-loaddefs cl-lib paren iso-transl
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util
term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads kqueue cocoa ns lcms2
multi-tty make-network-process emacs)

Memory information:
((conses 16 420243 16840)
 (symbols 48 28975 3)
 (strings 32 129525 3341)
 (string-bytes 1 3752515)
 (vectors 16 46182)
 (vector-slots 8 551119 16026)
 (floats 8 378 233)
 (intervals 56 695 0)
 (buffers 992 20))

[-- Attachment #2: Fill indicator.png --]
[-- Type: image/png, Size: 102756 bytes --]

bug#50970: 29.0.50; Italics cause fill column indicator misalignment

[Eli Zaretskii]

> From: Carlos Pita <carlosjosepita@gmail.com>
> Date: Sat, 2 Oct 2021 13:00:01 -0300
> 
> I believe the attached screenshot describes the issue well enough.

Which font is that?  I cannot reproduce with the default font Emacs
uses here.  Do you see the same results with all monospaced fonts,
once you customize the comment face to use italics?

bug#50970: 29.0.50; Italics cause fill column indicator misalignment

[Carlos Pita]

[-- Attachment #1: Type: text/plain, Size: 1114 bytes --]

Which font is that?  I cannot reproduce with the default font Emacs
uses here.  Do you see the same results with all monospaced fonts,
once you customize the comment face to use italics?


Source Code Pro, but it doesn’t seem to be relevant.

I have been able to reproduce it with a minimal setup (see the
attached screenshot):

(setq inhibit-startup-screen t)
(setq fill-column 80)
(global-display-fill-column-indicator-mode)
(custom-set-faces
 '(default ((t (:height 160))))
 '(font-lock-comment-face ((t (:slant italic))))

The problem is that it doesn’t always happen, I had to restart emacs
many times (I’m doing `emacs .emacs.d/init.el` one time after another)
until the issue happened. Due to the random nature of the issue it’s
not possible to ascertain that the (:height 160) part is strictly
necessary, but let’s say that I’ve rejected the null hypothesis that
the issue happens at default font size, but maybe it’s that I’m
shortsighted enough as to not perceive it at the smaller font size.
BTW, the default font in my system is Menlo.

Best regards,
Carlos

[-- Attachment #2: Minimal Setup 2.png --]
[-- Type: image/png, Size: 143121 bytes --]

bug#50970: 29.0.50; Italics cause fill column indicator misalignment

[Eli Zaretskii]

> From: Carlos Pita <carlosjosepita@gmail.com>
> Date: Sat, 2 Oct 2021 15:02:08 -0300
> Cc: 50970@debbugs.gnu.org
> 
> Which font is that?  I cannot reproduce with the default font Emacs
> uses here.  Do you see the same results with all monospaced fonts,
> once you customize the comment face to use italics?
> 
> 
> Source Code Pro, but it doesn’t seem to be relevant.
> 
> I have been able to reproduce it with a minimal setup (see the
> attached screenshot):
> 
> (setq inhibit-startup-screen t)
> (setq fill-column 80)
> (global-display-fill-column-indicator-mode)
> (custom-set-faces
>  '(default ((t (:height 160))))
>  '(font-lock-comment-face ((t (:slant italic))))

Doesn't reproduce here with these settings.

> The problem is that it doesn’t always happen, I had to restart emacs
> many times (I’m doing `emacs .emacs.d/init.el` one time after another)
> until the issue happened. Due to the random nature of the issue it’s
> not possible to ascertain that the (:height 160) part is strictly
> necessary, but let’s say that I’ve rejected the null hypothesis that
> the issue happens at default font size, but maybe it’s that I’m
> shortsighted enough as to not perceive it at the smaller font size.

That's too bad, because it means I have no reliable recipe to
reproduce and debug the problem...

Does anyone else see this and can provide a reproducible recipe?

bug#50970: 29.0.50; Italics cause fill column indicator misalignment

[Carlos Pita]

[-- Attachment #1: Type: text/plain, Size: 4198 bytes --]


> That's too bad, because it means I have no reliable recipe to
> reproduce and debug the problem...

Indeed it is. If you know of anything that could be affected by subtle timing issues or something like that, just let me know and I will do my best in order to test it.

Just in case, here is the dump for the minimal configuration:

In GNU Emacs 29.0.50 (build 1, x86_64-apple-darwin20.6.0, NS appkit-2022.60 Version 11.6 (Build 20G165))
 of 2021-10-02 built on Carloss-MacBook-Pro.local
Windowing system distributor 'Apple', version 10.3.2022
System Description:  macOS 11.6

Configured using:
 'configure --disable-dependency-tracking --disable-silent-rules
 --enable-locallisppath=/usr/local/share/emacs/site-lisp
 --infodir=/usr/local/Cellar/emacs-plus@28/28.0.50/share/info/emacs
 --prefix=/usr/local/Cellar/emacs-plus@28/28.0.50 --with-xml2
 --with-gnutls --without-dbus --with-imagemagick --with-modules
 --with-rsvg --with-ns --disable-ns-self-contained'

Configured features:
ACL GLIB GMP GNUTLS IMAGEMAGICK JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY
KQUEUE NS PDUMPER PNG RSVG THREADS TIFF TOOLKIT_SCROLL_BARS XIM ZLIB

Important settings:
  value of $LC_CTYPE: UTF-8
  value of $LANG: en_AR.UTF-8
  locale-coding-system: utf-8-unix

Major mode: ELisp/d

Minor modes in effect:
  global-display-fill-column-indicator-mode: t
  display-fill-column-indicator-mode: t
  show-paren-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
/Users/carlos/.emacs.d/elpa/magit-20210928.1325/magit-section-pkg hides /Users/carlos/.emacs.d/elpa/magit-section-20210829.1849/magit-section-pkg
/Users/carlos/.emacs.d/elpa/transient-20210920.1038/transient hides /usr/local/Cellar/emacs-plus@28/28.0.50/share/emacs/29.0.50/lisp/transient

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail
rmail-loaddefs text-property-search mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date
ido-completing-read+ memoize cus-edit pp cus-start cus-load wid-edit
minibuf-eldef ido edmacro kmacro easy-mmode
display-fill-column-indicator info package browse-url url url-proxy
url-privacy url-expand url-methods url-history url-cookie url-domsuf
url-util mailcap url-handlers url-parse auth-source cl-seq eieio
eieio-core cl-macs eieio-loaddefs password-cache json map url-vars seq
gv subr-x byte-opt bytecomp byte-compile cconv cl-loaddefs cl-lib paren
iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize
mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads kqueue cocoa ns lcms2
multi-tty make-network-process emacs)

Memory information:
((conses 16 91194 5077)
 (symbols 48 10226 1)
 (strings 32 30543 1480)
 (string-bytes 1 1020041)
 (vectors 16 18443)
 (vector-slots 8 228387 13018)
 (floats 8 45 19)
 (intervals 56 253 0)
 (buffers 992 11))


[-- Attachment #2: Type: text/html, Size: 7155 bytes --]

bug#50970: 29.0.50; Italics cause fill column indicator misalignment

[Eli Zaretskii]

> From: Carlos Pita <carlosjosepita@gmail.com>
> Date: Sat, 2 Oct 2021 15:35:22 -0300
> Cc: 50970@debbugs.gnu.org
> 
>  That's too bad, because it means I have no reliable recipe to
>  reproduce and debug the problem...
> 
> Indeed it is. If you know of anything that could be affected by subtle timing issues or something like that, just
> let me know and I will do my best in order to test it.
> 
> Just in case, here is the dump for the minimal configuration:
> 
> In GNU Emacs 29.0.50 (build 1, x86_64-apple-darwin20.6.0, NS appkit-2022.60 Version 11.6 (Build
> 20G165))
>  of 2021-10-02 built on Carloss-MacBook-Pro.local
> Windowing system distributor 'Apple', version 10.3.2022
> System Description:  macOS 11.6

Maybe it's specific to macOS?

bug#50970: 29.0.50; Italics cause fill column indicator misalignment

[Carlos Pita]

Well, I’ve done literally thousands of restarts in different combinations of emacs versions, extensions, etc. Each new combination was tested in at least 100 restarts. This is what I can say:

* It never happened with 27.2 in any combination.
* With a minimal configuration it still happens in 28, but at a very low frequency (maybe < 1/100).
* The same after recompiling all my extensions.
* It never happened after removing the elpa directory altogether.
* Having global company mode enabled is what raises the frequency (> 1/10).

My highlights on the above (taking into account that “never" means “not yet seen”):

* The problem is likely in 28, not in 27.2.
* I would say it’s always waiting there but some setups make it more frequent.
* Enabling company is the easiest way to (probabilistic) reproducibility I’ve found.

BTW, I now feel authorized to say that startup time has improved a lot, any specific optimization there?

bug#50970: 29.0.50; Italics cause fill column indicator misalignment

[Lars Ingebrigtsen]

Carlos Pita <carlosjosepita@gmail.com> writes:

> My highlights on the above (taking into account that “never" means
> “not yet seen”):
>
> * The problem is likely in 28, not in 27.2.
> * I would say it’s always waiting there but some setups make it more frequent.
> * Enabling company is the easiest way to (probabilistic)
> reproducibility I’ve found.

(I'm going through old bug reports that unfortunately weren't resolved
at the time.)

Do you still see this issue with the current "master"?

bug#50970: 29.0.50; Italics cause fill column indicator misalignment

[Carlos Pita]

Hi Lars,

> Do you still see this issue with the current "master”?

I won’t be able to test this for the next few weeks, but I’ve been using 28 for months and have never seen this again, so I’d say that you can safely close it.

> (I'm going through old bug reports that unfortunately weren't resolved at the time.)

Thanks!

bug#50970: 29.0.50; Italics cause fill column indicator misalignment

[Lars Ingebrigtsen]

Carlos Pita <carlosjosepita@gmail.com> writes:

> I won’t be able to test this for the next few weeks, but I’ve been
> using 28 for months and have never seen this again, so I’d say that
> you can safely close it.

OK; done.