From: Michael Albinus <michael.albinus@gmx.de>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 65356@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#65356: 30.0.50; [wishlist] Support Tramp method, user name and host name completion in eshell
Date: Fri, 18 Aug 2023 08:45:26 +0200 [thread overview]
Message-ID: <87il9crgqh.fsf@gmx.de> (raw)
In-Reply-To: <4b4a64de-846a-ed2a-f409-80ea75e9cb57@gmail.com> (Jim Porter's message of "Thu, 17 Aug 2023 20:31:54 -0700")
Jim Porter <jporterbugs@gmail.com> writes:
Hi Jim,
> X-Debbugs-Cc: monnier@iro.umontreal.ca
Well, this works only if you *submit* a new bug. If you *reply*, just
use Cc. I've added Stefan in this reply.
>> In eshell, this feature does not exist. I would like if I could type
>> "cd /ss TAB" and could see the same offering of "ssh:", "sshfs:" and
>> "sshx:". Same for user name and host name.
>>
>> The appended patch does this for me. I have no idea how good it fits
>> into the eshell machinery, for example whether there are problems with
>> the em-elecslash.el module. Comments welcome!
>
> Thanks. This would be a useful feature indeed. I have a couple of main
> concerns, which I'm not quite sure what to do about at the moment:
>
> 1) Should this go in the Eshell Tramp extension module? Currently,
> that module is there to add built-in versions of su/sudo/doas, as an
> alternative to the "standard" Eshell way of connecting to a remote
> host: "cd /ssh:user@host:~". Therefore, I think we'd want
> tab-completion of Tramp file names even (or especially!) when the
> Tramp extension module is disabled (which is the default).
I have no preference where it shall be in eshell. I've used em-tramp.el
during my work, because it is the least invasive place: it requires
already Tramp. You might have seen, that the new function uses two Tramp
variables.
> 2) I'm not sure 'pcomplete-try-first-hook' is the right way to enable
> this. Pcomplete has quite a few ways of performing completions, and it
> already knows when it should specifically complete file names (as
> opposed to "--options" for example). Maybe we should enhance Pcomplete
> itself so that you can opt into completion of remote file names too?
> Then when you tab-complete in Eshell, it would just work in all the
> contexts where you can normally complete a file name. I Cc'ed Stefan
> since he might have some thoughts on the Pcomplete machinery here.
When I've started to implement this, I was a n00b wrt pcomplete. Well,
I'm still a n00b, all what I have done is stealing code from somewhere
else, shamelessly.
It would be great if this completion function applies only to possible
*Lisp* file names. Roughly said, to arguments of commands not being
external, and not in a pipe. If this could be arranged I'd appreciate
it. So I count on you and Stefan :-)
Best regards, Michael.
next prev parent reply other threads:[~2023-08-18 6:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 18:01 bug#65356: 30.0.50; [wishlist] Support Tramp method, user name and host name completion in eshell Michael Albinus
2023-08-18 3:31 ` Jim Porter
2023-08-18 6:45 ` Michael Albinus [this message]
2023-08-18 11:43 ` Michael Albinus
2023-08-18 13:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-18 15:12 ` Michael Albinus
2023-08-18 22:33 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-19 3:26 ` Jim Porter
2023-08-19 17:48 ` Michael Albinus
2023-08-19 18:37 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-19 19:14 ` Michael Albinus
2023-08-20 0:02 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-20 7:50 ` Michael Albinus
2023-08-20 5:23 ` Jim Porter
2023-08-20 10:53 ` Michael Albinus
2023-08-23 0:30 ` Jim Porter
2023-08-23 7:56 ` Michael Albinus
2023-08-18 17:50 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il9crgqh.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=65356@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).