unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Jim Porter <jporterbugs@gmail.com>, 65356@debbugs.gnu.org
Subject: bug#65356: 30.0.50; [wishlist] Support Tramp method, user name and host name completion in eshell
Date: Fri, 18 Aug 2023 17:12:33 +0200	[thread overview]
Message-ID: <875y5cqt9a.fsf@gmx.de> (raw)
In-Reply-To: <jwv5y5ch493.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 18 Aug 2023 09:25:42 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

Hi Stefan,

>> --8<---------------cut here---------------start------------->8---
>> (defun pcomplete/cd ()
>>   "Completion for `cd'."
>>   (while (pcomplete-here (completion-table-in-turn
>> 			  (pcomplete-tramp)
>> 			  (pcomplete-dirs)))))
>> --8<---------------cut here---------------end--------------->8---
>
> AFIK this applies to `M-x shell` as well, so it doesn't seem
> quite right.

Yes. However, there is already another problem in shell-mode. My patch
completes only incomplete Tramp file names, like "/ss". Complete Tramp
file names are handled by pcomplete-dirs already. So we see in a *shell*
buffer, w/o my patch:

--8<---------------cut here---------------start------------->8---
[albinus@gandalf ~]$ cd /ssh:host: TAB
=> all directories on that remote host
--8<---------------cut here---------------end--------------->8---

So we must fix completion of remote file names in shell-mode anyway. This
would prevent also the modified pcomplete/cd to show any Tramp related
file name.

>         Stefan

Best regards, Michael.





  reply	other threads:[~2023-08-18 15:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-17 18:01 bug#65356: 30.0.50; [wishlist] Support Tramp method, user name and host name completion in eshell Michael Albinus
2023-08-18  3:31 ` Jim Porter
2023-08-18  6:45   ` Michael Albinus
2023-08-18 11:43     ` Michael Albinus
2023-08-18 13:25       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-18 15:12         ` Michael Albinus [this message]
2023-08-18 22:33           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-19  3:26             ` Jim Porter
2023-08-19 17:48               ` Michael Albinus
2023-08-19 18:37                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-19 19:14                   ` Michael Albinus
2023-08-20  0:02                     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-20  7:50                       ` Michael Albinus
2023-08-20  5:23                 ` Jim Porter
2023-08-20 10:53                   ` Michael Albinus
2023-08-23  0:30                     ` Jim Porter
2023-08-23  7:56                       ` Michael Albinus
2023-08-18 17:50         ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875y5cqt9a.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=65356@debbugs.gnu.org \
    --cc=jporterbugs@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).