* bug#25022: 25.1.50; Different highlighting for different citation level in message-mode
@ 2016-11-24 23:22 Hong Xu
2016-12-06 6:08 ` Hong Xu
0 siblings, 1 reply; 12+ messages in thread
From: Hong Xu @ 2016-11-24 23:22 UTC (permalink / raw)
To: 25022
Currently in message-mode all cited texts are highlighted in the same
way. It would be nicer if the highlighting of different citation levels
can be easily customized.
In GNU Emacs 25.1.50.13 (x86_64-unknown-linux-gnu, GTK+ Version 3.14.5)
of 2016-11-24 built on home
Repository revision: 7f43d7c0101256b120ead3ddae6ee47327d231c9
Windowing system distributor 'The X.Org Foundation', version 11.0.11604000
System Description: Debian GNU/Linux 8.6 (jessie)
Configured using:
'configure --with-modules --with-xwidgets
--prefix=/home/hong/.local/opt/emacs/
'--program-transform-name=s/^ctags$/ctags.emacs/''
Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 MODULES XWIDGETS
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#25022: 25.1.50; Different highlighting for different citation level in message-mode
2016-11-24 23:22 bug#25022: 25.1.50; Different highlighting for different citation level in message-mode Hong Xu
@ 2016-12-06 6:08 ` Hong Xu
2016-12-06 7:39 ` Katsumi Yamaoka
2019-09-23 11:12 ` Lars Ingebrigtsen
0 siblings, 2 replies; 12+ messages in thread
From: Hong Xu @ 2016-12-06 6:08 UTC (permalink / raw)
To: 25022
[-- Attachment #1.1: message-cited-text-color.png --]
[-- Type: image/png, Size: 98934 bytes --]
[-- Attachment #1.2: Type: text/plain, Size: 1131 bytes --]
On 2016-11-24 Thu 15:22 GMT-0800, Hong Xu <hong@topbug.net> wrote:
> Currently in message-mode all cited texts are highlighted in the same
> way. It would be nicer if the highlighting of different citation levels
> can be easily customized.
>
Here is a patch and a screenshot. The default colors I chose may not be
optimal -- but I guess I'll leave that part to professionals.
Add support for different faces for different citation levels in message-mode.
* message.el (message-font-lock-keywords)
(message-font-lock-make-cited-text-matcher): Add support for
different faces for different citation levels. The faces are
defined in the faces named `message-cited-text-N': N of the
Mth citation level will be M mod 4.
(message-cited-text-1, message-cited-text-2)
(message-cited-text-3, message-cited-text-4): Add customization
for the faces of 4 different citation level. In the future, the
number of faces may increase, as the code is flexible enough to
automatically deal with that.
(message-cite-level-function): Add a function to customize the
determination of cite levels given the prefix of the cited text.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.3: message.patch --]
[-- Type: text/x-diff, Size: 7638 bytes --]
diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el
index 448ba7b99718..a61ced374aaf 100644
--- a/lisp/gnus/message.el
+++ b/lisp/gnus/message.el
@@ -649,6 +649,11 @@ message-cite-prefix-regexp
(setq gnus-message-cite-prefix-regexp
(concat "^\\(?:" value "\\)"))))))
+(defcustom message-cite-level-function
+ (lambda (s) (cl-count ?> s))
+ "A function to determine the level of cited text. The function
+ accepts 1 parameter which is the matched prefix.")
+
(defcustom message-cancel-message "I am canceling my own article.\n"
"Message to be inserted in the cancel message."
:group 'message-interface
@@ -1548,18 +1553,57 @@ message-separator
(put 'message-separator-face 'face-alias 'message-separator)
(put 'message-separator-face 'obsolete-face "22.1")
-(defface message-cited-text
+(defface message-cited-text-1
'((((class color)
(background dark))
(:foreground "LightPink1"))
(((class color)
(background light))
- (:foreground "red"))
+ (:foreground "red1"))
+ (t
+ (:bold t)))
+ "Face used for displaying 1st-level cited text."
+ :group 'message-faces)
+
+(defface message-cited-text-2
+ '((((class color)
+ (background dark))
+ (:foreground "forest green"))
+ (((class color)
+ (background light))
+ (:foreground "red4"))
(t
(:bold t)))
- "Face used for displaying cited text names."
+ "Face used for displaying 2nd-level cited text."
:group 'message-faces)
+
+(defface message-cited-text-3
+ '((((class color)
+ (background dark))
+ (:foreground "goldenrod3"))
+ (((class color)
+ (background light))
+ (:foreground "OliveDrab4"))
+ (t
+ (:bold t)))
+ "Face used for displaying 3rd-level cited text."
+ :group 'message-faces)
+
+(defface message-cited-text-4
+ '((((class color)
+ (background dark))
+ (:foreground "chocolate3"))
+ (((class color)
+ (background light))
+ (:foreground "SteelBlue4"))
+ (t
+ (:bold t)))
+ "Face used for displaying 4th-level cited text."
+ :group 'message-faces)
+
;; backward-compatibility alias
+(put 'message-cited-text 'face-alias 'message-cited-text-1)
+(put 'message-cited-text 'obsolete-face "26.1")
(put 'message-cited-text-face 'face-alias 'message-cited-text)
(put 'message-cited-text-face 'obsolete-face "22.1")
@@ -1596,45 +1640,83 @@ message-font-lock-make-header-matcher
(byte-compile form)
form)))
+(defun message-font-lock-make-cited-text-matcher (level maxlevel)
+ "Generate the matcher for cited text. LEVEL is the citation
+level to be matched and MAXLEVEL is the number of levels
+specified in the faces `message-cited-text-*'."
+ (byte-compile
+ `(lambda (limit)
+ (let (matched)
+ ;; Keep search until `message-cite-level-function' returns the level
+ ;; we want to match.
+ (while
+ (and (re-search-forward (concat "^\\("
+ message-cite-prefix-regexp
+ "\\).*")
+ limit t)
+ (not (setq matched
+ (save-match-data
+ (= ,(1- level)
+ (mod
+ (1- (funcall message-cite-level-function
+ (match-string 1)))
+ ,maxlevel)))))))
+ matched))))
+
(defvar message-font-lock-keywords
- (let ((content "[ \t]*\\(.+\\(\n[ \t].*\\)*\\)\n?"))
- `((,(message-font-lock-make-header-matcher
- (concat "^\\([Tt]o:\\)" content))
- (1 'message-header-name)
- (2 'message-header-to nil t))
- (,(message-font-lock-make-header-matcher
- (concat "^\\(^[GBF]?[Cc][Cc]:\\|^[Rr]eply-[Tt]o:\\)" content))
- (1 'message-header-name)
- (2 'message-header-cc nil t))
- (,(message-font-lock-make-header-matcher
- (concat "^\\([Ss]ubject:\\)" content))
- (1 'message-header-name)
- (2 'message-header-subject nil t))
- (,(message-font-lock-make-header-matcher
- (concat "^\\([Nn]ewsgroups:\\|Followup-[Tt]o:\\)" content))
- (1 'message-header-name)
- (2 'message-header-newsgroups nil t))
- (,(message-font-lock-make-header-matcher
- (concat "^\\(X-[A-Za-z0-9-]+:\\|In-Reply-To:\\)" content))
- (1 'message-header-name)
- (2 'message-header-xheader))
- (,(message-font-lock-make-header-matcher
- (concat "^\\([A-Z][^: \n\t]+:\\)" content))
- (1 'message-header-name)
- (2 'message-header-other nil t))
- ,@(if (and mail-header-separator
- (not (equal mail-header-separator "")))
- `((,(concat "^\\(" (regexp-quote mail-header-separator) "\\)$")
- 1 'message-separator))
- nil)
- ((lambda (limit)
- (re-search-forward (concat "^\\("
- message-cite-prefix-regexp
- "\\).*")
- limit t))
- (0 'message-cited-text))
- ("<#/?\\(multipart\\|part\\|external\\|mml\\|secure\\)[^>]*>"
- (0 'message-mml))))
+ (nconc
+ (let ((content "[ \t]*\\(.+\\(\n[ \t].*\\)*\\)\n?"))
+ `((,(message-font-lock-make-header-matcher
+ (concat "^\\([Tt]o:\\)" content))
+ (1 'message-header-name)
+ (2 'message-header-to nil t))
+ (,(message-font-lock-make-header-matcher
+ (concat "^\\(^[GBF]?[Cc][Cc]:\\|^[Rr]eply-[Tt]o:\\)" content))
+ (1 'message-header-name)
+ (2 'message-header-cc nil t))
+ (,(message-font-lock-make-header-matcher
+ (concat "^\\([Ss]ubject:\\)" content))
+ (1 'message-header-name)
+ (2 'message-header-subject nil t))
+ (,(message-font-lock-make-header-matcher
+ (concat "^\\([Nn]ewsgroups:\\|Followup-[Tt]o:\\)" content))
+ (1 'message-header-name)
+ (2 'message-header-newsgroups nil t))
+ (,(message-font-lock-make-header-matcher
+ (concat "^\\(X-[A-Za-z0-9-]+:\\|In-Reply-To:\\)" content))
+ (1 'message-header-name)
+ (2 'message-header-xheader))
+ (,(message-font-lock-make-header-matcher
+ (concat "^\\([A-Z][^: \n\t]+:\\)" content))
+ (1 'message-header-name)
+ (2 'message-header-other nil t))
+ ,@(if (and mail-header-separator
+ (not (equal mail-header-separator "")))
+ `((,(concat "^\\(" (regexp-quote mail-header-separator) "\\)$")
+ 1 'message-separator))
+ nil)
+ ("<#/?\\(multipart\\|part\\|external\\|mml\\|secure\\)[^>]*>"
+ (0 'message-mml))))
+ ;; Additional font locks to highlight different levels of cited text
+ (let ((maxlevel 1)
+ (level 1)
+ cited-text-face
+ keywords)
+ ;; Compute the max level.
+ (while (setq cited-text-face
+ (intern-soft (format "message-cited-text-%d" maxlevel)))
+ (setq maxlevel (1+ maxlevel)))
+ (setq maxlevel (1- maxlevel))
+ ;; Generate the keywords.
+ (while (setq cited-text-face
+ (intern-soft (format "message-cited-text-%d" level)))
+ (setq keywords
+ (cons
+ `(,(message-font-lock-make-cited-text-matcher level maxlevel)
+ (0 ',cited-text-face))
+ keywords))
+ (setq level (1+ level)))
+ keywords))
"Additional expressions to highlight in Message mode.")
(defvar message-face-alist
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply related [flat|nested] 12+ messages in thread
* bug#25022: 25.1.50; Different highlighting for different citation level in message-mode
2016-12-06 6:08 ` Hong Xu
@ 2016-12-06 7:39 ` Katsumi Yamaoka
2016-12-06 8:52 ` Hong Xu
2016-12-06 9:17 ` Hong Xu
2019-09-23 11:12 ` Lars Ingebrigtsen
1 sibling, 2 replies; 12+ messages in thread
From: Katsumi Yamaoka @ 2016-12-06 7:39 UTC (permalink / raw)
To: Hong Xu; +Cc: 25022
[-- Attachment #1: Type: text/plain, Size: 864 bytes --]
On Mon, 05 Dec 2016 22:08:46 -0800, Hong Xu wrote:
> On 2016-11-24 Thu 15:22 GMT-0800, Hong Xu <hong@topbug.net> wrote:
>> Currently in message-mode all cited texts are highlighted in the same
>> way. It would be nicer if the highlighting of different citation levels
>> can be easily customized.
> Here is a patch and a screenshot. The default colors I chose may not be
> optimal -- but I guess I'll leave that part to professionals.
> Add support for different faces for different citation levels in message-mode.
Isn't it redundant as there is this already? ;-)
(defcustom gnus-message-highlight-citation
t ;; gnus-treat-highlight-citation ;; gnus-cite dependency
"Enable highlighting of different citation levels in message-mode."
:version "23.1" ;; No Gnus
:group 'gnus-cite
:group 'gnus-message
:type 'boolean)
Here is my message-mode view:
[-- Attachment #2: message-cited-text-color-2.png --]
[-- Type: image/png, Size: 4367 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#25022: 25.1.50; Different highlighting for different citation level in message-mode
2016-12-06 7:39 ` Katsumi Yamaoka
@ 2016-12-06 8:52 ` Hong Xu
2016-12-06 10:08 ` Katsumi Yamaoka
2016-12-06 9:17 ` Hong Xu
1 sibling, 1 reply; 12+ messages in thread
From: Hong Xu @ 2016-12-06 8:52 UTC (permalink / raw)
To: Katsumi Yamaoka; +Cc: 25022
[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]
On 2016-12-05 Mon 23:39 GMT-0800, Katsumi Yamaoka <yamaoka@jpl.org> wrote:
> On Mon, 05 Dec 2016 22:08:46 -0800, Hong Xu wrote:
>> On 2016-11-24 Thu 15:22 GMT-0800, Hong Xu <hong@topbug.net> wrote:
>>> Currently in message-mode all cited texts are highlighted in the same
>>> way. It would be nicer if the highlighting of different citation levels
>>> can be easily customized.
>
>> Here is a patch and a screenshot. The default colors I chose may not be
>> optimal -- but I guess I'll leave that part to professionals.
>
>> Add support for different faces for different citation levels in message-mode.
>
> Isn't it redundant as there is this already? ;-)
>
> (defcustom gnus-message-highlight-citation
> t ;; gnus-treat-highlight-citation ;; gnus-cite dependency
> "Enable highlighting of different citation levels in message-mode."
> :version "23.1" ;; No Gnus
> :group 'gnus-cite
> :group 'gnus-message
> :type 'boolean)
>
> Here is my message-mode view:
Thank you pointing it out. However, it seems that
gnus-message-citation-mode does not work for me when using message-mode
from mu4e. I'm not sure whether it relies on the whole gnus to work or
simply I missed something...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#25022: 25.1.50; Different highlighting for different citation level in message-mode
2016-12-06 7:39 ` Katsumi Yamaoka
2016-12-06 8:52 ` Hong Xu
@ 2016-12-06 9:17 ` Hong Xu
2016-12-06 15:31 ` Eli Zaretskii
1 sibling, 1 reply; 12+ messages in thread
From: Hong Xu @ 2016-12-06 9:17 UTC (permalink / raw)
To: Katsumi Yamaoka; +Cc: 25022-done
[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]
On 2016-12-05 Mon 23:39 GMT-0800, Katsumi Yamaoka <yamaoka@jpl.org> wrote:
> On Mon, 05 Dec 2016 22:08:46 -0800, Hong Xu wrote:
>> On 2016-11-24 Thu 15:22 GMT-0800, Hong Xu <hong@topbug.net> wrote:
>>> Currently in message-mode all cited texts are highlighted in the same
>>> way. It would be nicer if the highlighting of different citation levels
>>> can be easily customized.
>
>> Here is a patch and a screenshot. The default colors I chose may not be
>> optimal -- but I guess I'll leave that part to professionals.
>
>> Add support for different faces for different citation levels in message-mode.
>
> Isn't it redundant as there is this already? ;-)
>
> (defcustom gnus-message-highlight-citation
> t ;; gnus-treat-highlight-citation ;; gnus-cite dependency
> "Enable highlighting of different citation levels in message-mode."
> :version "23.1" ;; No Gnus
> :group 'gnus-cite
> :group 'gnus-message
> :type 'boolean)
>
> Here is my message-mode view:
I see the reason: gnus-message-citation-mode should see whether the
current major mode is derived from message-mode, rather than equal. I'll
probably find another fix later.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#25022: 25.1.50; Different highlighting for different citation level in message-mode
2016-12-06 8:52 ` Hong Xu
@ 2016-12-06 10:08 ` Katsumi Yamaoka
2019-06-24 23:30 ` Lars Ingebrigtsen
0 siblings, 1 reply; 12+ messages in thread
From: Katsumi Yamaoka @ 2016-12-06 10:08 UTC (permalink / raw)
To: Hong Xu; +Cc: 25022
;; This might not be Cc'd to the bug list, but that's ok. ;-)
On Tue, 06 Dec 2016 00:52:29 -0800, Hong Xu wrote:
> Thank you pointing it out. However, it seems that
> gnus-message-citation-mode does not work for me when using message-mode
> from mu4e. I'm not sure whether it relies on the whole gnus to work or
> simply I missed something...
With `emacs -Q' I tried:
(setq mail-user-agent 'gnus-user-agent)
(compose-mail)
However, I saw that `gnus-message-citation-mode' does not run.
I realized it is because `compose-mail' runs `gnus-msg-mail' that
calls `message-mail' directly if Gnus is not running then. It
doesn't differ from the case `mail-user-agent' is the default.
I vaguely think this is the key to improve it. Anyway, I believe
improving `message-mode' so as to run `gnus-message-citation-mode'
is worthwhile especially for the case where Gnus is not running.
Regards,
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#25022: 25.1.50; Different highlighting for different citation level in message-mode
2016-12-06 9:17 ` Hong Xu
@ 2016-12-06 15:31 ` Eli Zaretskii
2016-12-06 15:51 ` Lars Ingebrigtsen
2016-12-06 20:04 ` Hong Xu
0 siblings, 2 replies; 12+ messages in thread
From: Eli Zaretskii @ 2016-12-06 15:31 UTC (permalink / raw)
To: Hong Xu; +Cc: 25022
> From: Hong Xu <hong@topbug.net>
> Date: Tue, 06 Dec 2016 01:17:35 -0800
> Cc: 25022-done@debbugs.gnu.org
>
> I see the reason: gnus-message-citation-mode should see whether the
> current major mode is derived from message-mode, rather than equal. I'll
> probably find another fix later.
If you change the condition to be true for any mode derived from
message-mode, then all of them will inherit this feature. Are we sure
those other modes all want that? For example, gnus-art.el defines one
such mode; up until now, that mode didn't use this feature, maybe that
was for a good reason?
(Caveat: I don't use Gnus, nor message-mode.)
Thanks.
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#25022: 25.1.50; Different highlighting for different citation level in message-mode
2016-12-06 15:31 ` Eli Zaretskii
@ 2016-12-06 15:51 ` Lars Ingebrigtsen
2016-12-06 19:57 ` Hong Xu
2016-12-06 20:04 ` Hong Xu
1 sibling, 1 reply; 12+ messages in thread
From: Lars Ingebrigtsen @ 2016-12-06 15:51 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 25022, Hong Xu
Eli Zaretskii <eliz@gnu.org> writes:
> If you change the condition to be true for any mode derived from
> message-mode, then all of them will inherit this feature. Are we sure
> those other modes all want that? For example, gnus-art.el defines one
> such mode; up until now, that mode didn't use this feature, maybe that
> was for a good reason?
No, I don't think that was on purpose. I probably just didn't know
about derived-mode-p at the time...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#25022: 25.1.50; Different highlighting for different citation level in message-mode
2016-12-06 15:51 ` Lars Ingebrigtsen
@ 2016-12-06 19:57 ` Hong Xu
0 siblings, 0 replies; 12+ messages in thread
From: Hong Xu @ 2016-12-06 19:57 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 25022
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
On 2016-12-06 Tue 07:51 GMT-0800, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>> If you change the condition to be true for any mode derived from
>> message-mode, then all of them will inherit this feature. Are we sure
>> those other modes all want that? For example, gnus-art.el defines one
>> such mode; up until now, that mode didn't use this feature, maybe that
>> was for a good reason?
>
> No, I don't think that was on purpose. I probably just didn't know
> about derived-mode-p at the time...
I've already proposed the one-line change in #25124. You can commit
directly since this is just one line...
I saw a comment "FIXME: use derived-mode-p" but I'm not sure why it
wasn't changed directly on the code itself.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#25022: 25.1.50; Different highlighting for different citation level in message-mode
2016-12-06 15:31 ` Eli Zaretskii
2016-12-06 15:51 ` Lars Ingebrigtsen
@ 2016-12-06 20:04 ` Hong Xu
1 sibling, 0 replies; 12+ messages in thread
From: Hong Xu @ 2016-12-06 20:04 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 25022
[-- Attachment #1: Type: text/plain, Size: 903 bytes --]
On 2016-12-06 Tue 07:31 GMT-0800, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Hong Xu <hong@topbug.net>
>> Date: Tue, 06 Dec 2016 01:17:35 -0800
>> Cc: 25022-done@debbugs.gnu.org
>>
>> I see the reason: gnus-message-citation-mode should see whether the
>> current major mode is derived from message-mode, rather than equal. I'll
>> probably find another fix later.
>
> If you change the condition to be true for any mode derived from
> message-mode, then all of them will inherit this feature. Are we sure
> those other modes all want that? For example, gnus-art.el defines one
> such mode; up until now, that mode didn't use this feature, maybe that
> was for a good reason?
I don't think it's a big problem -- the minor mode isn't automatically
enabled anyway. If someone derives message-mode to a mode that isn't
compatible with gnus-message-citation-mode, she can just disable the
minor mode.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#25022: 25.1.50; Different highlighting for different citation level in message-mode
2016-12-06 10:08 ` Katsumi Yamaoka
@ 2019-06-24 23:30 ` Lars Ingebrigtsen
0 siblings, 0 replies; 12+ messages in thread
From: Lars Ingebrigtsen @ 2019-06-24 23:30 UTC (permalink / raw)
To: Katsumi Yamaoka; +Cc: 25022, Hong Xu
Katsumi Yamaoka <yamaoka@jpl.org> writes:
> (setq mail-user-agent 'gnus-user-agent)
> (compose-mail)
>
> However, I saw that `gnus-message-citation-mode' does not run.
> I realized it is because `compose-mail' runs `gnus-msg-mail' that
> calls `message-mail' directly if Gnus is not running then. It
> doesn't differ from the case `mail-user-agent' is the default.
> I vaguely think this is the key to improve it. Anyway, I believe
> improving `message-mode' so as to run `gnus-message-citation-mode'
> is worthwhile especially for the case where Gnus is not running.
Yes, we should refactor the gnus-cite code, perhaps, to be able to be
used in Message when Gnus isn't running.
Hm...
OK, I had a look at it, and it does seem possible, but it would take
extensive untangling.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 12+ messages in thread
* bug#25022: 25.1.50; Different highlighting for different citation level in message-mode
2016-12-06 6:08 ` Hong Xu
2016-12-06 7:39 ` Katsumi Yamaoka
@ 2019-09-23 11:12 ` Lars Ingebrigtsen
1 sibling, 0 replies; 12+ messages in thread
From: Lars Ingebrigtsen @ 2019-09-23 11:12 UTC (permalink / raw)
To: Hong Xu; +Cc: 25022
Hong Xu <hong@topbug.net> writes:
> Add support for different faces for different citation levels in
> message-mode.
I had another look at reusing the gnus-cite code for this instead, but
it's just too much code to inflict on non-Gnus users.
So I've applied your patch now to Emacs 27, and it seems to look nice to
me, but of course, since virtually all my mails are generated from a
Gnus context, I won't be seeing these citation faces a lot.
If anybody else wants to tweak the faces, please go ahead.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-09-23 11:12 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-24 23:22 bug#25022: 25.1.50; Different highlighting for different citation level in message-mode Hong Xu
2016-12-06 6:08 ` Hong Xu
2016-12-06 7:39 ` Katsumi Yamaoka
2016-12-06 8:52 ` Hong Xu
2016-12-06 10:08 ` Katsumi Yamaoka
2019-06-24 23:30 ` Lars Ingebrigtsen
2016-12-06 9:17 ` Hong Xu
2016-12-06 15:31 ` Eli Zaretskii
2016-12-06 15:51 ` Lars Ingebrigtsen
2016-12-06 19:57 ` Hong Xu
2016-12-06 20:04 ` Hong Xu
2019-09-23 11:12 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).