From: Fabrice BAUZAC-STEHLY <noon@mykolab.com>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 45800@debbugs.gnu.org
Subject: bug#45800: 27.1; ibuffer sort by filename/process fails with Dired
Date: Mon, 18 Jan 2021 23:05:24 +0100 [thread overview]
Message-ID: <87h7ndc34r.fsf@mykolab.com> (raw)
In-Reply-To: <874kjf1t3d.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 17 Jan 2021 15:27:50 +0000")
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> Fabrice BAUZAC-STEHLY <noon@mykolab.com> writes:
>
>> To fix this on my side, I have replaced both occurrences of
>> (buffer-file-name (car X))
>> with
>> (with-current-buffer (car X) (ibuffer-buffer-file-name))
>> which seems to work:
>
> Thanks, that looks correct. Would you like to provide a patch against
> master to that effect?
Sure, here it is:
diff --git a/lisp/ibuf-ext.el b/lisp/ibuf-ext.el
index ed5c9c0211..44574abd46 100644
--- a/lisp/ibuf-ext.el
+++ b/lisp/ibuf-ext.el
@@ -1497,10 +1497,10 @@ filename/process
(string-lessp
;; FIXME: For now just compare the file name and the process name
;; (if it exists). Is there a better way to do this?
- (or (buffer-file-name (car a))
+ (or (with-current-buffer (car a) (ibuffer-buffer-file-name))
(let ((pr-a (get-buffer-process (car a))))
(and (processp pr-a) (process-name pr-a))))
- (or (buffer-file-name (car b))
+ (or (with-current-buffer (car b) (ibuffer-buffer-file-name))
(let ((pr-b (get-buffer-process (car b))))
(and (processp pr-b) (process-name pr-b))))))
> I think your cumulative changes would still be exempt of copyright
> paperwork, but would you be willing to start the copyright assignment
> process for future changes that exceed the limit, if you haven't
> already?
Yes, no problem for that.
--
Fabrice Bauzac-Stehly
PGP 01EEACF8244E9C14B551C5256ADA5F189BD322B6
old PGP 015AE9B25DCB0511D200A75DE5674DEA514C891D
next prev parent reply other threads:[~2021-01-18 22:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 20:02 bug#45800: 27.1; ibuffer sort by filename/process fails with Dired Fabrice BAUZAC-STEHLY
2021-01-17 15:27 ` Basil L. Contovounesios
2021-01-18 22:05 ` Fabrice BAUZAC-STEHLY [this message]
2021-01-19 21:37 ` Fabrice BAUZAC-STEHLY
2021-01-20 14:21 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7ndc34r.fsf@mykolab.com \
--to=noon@mykolab.com \
--cc=45800@debbugs.gnu.org \
--cc=contovob@tcd.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).