From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Fabrice BAUZAC-STEHLY Newsgroups: gmane.emacs.bugs Subject: bug#45800: 27.1; ibuffer sort by filename/process fails with Dired Date: Mon, 18 Jan 2021 23:05:24 +0100 Message-ID: <87h7ndc34r.fsf@mykolab.com> References: <87wnwjfdht.fsf@mykolab.com> <874kjf1t3d.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9573"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45800@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 18 23:24:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1cwY-0002O9-4d for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Jan 2021 23:24:14 +0100 Original-Received: from localhost ([::1]:49700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1cwX-00022D-0R for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Jan 2021 17:24:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1cwM-0001w9-NK for bug-gnu-emacs@gnu.org; Mon, 18 Jan 2021 17:24:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37089) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l1cwM-0006tE-BR for bug-gnu-emacs@gnu.org; Mon, 18 Jan 2021 17:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l1cwM-0001Eu-7z for bug-gnu-emacs@gnu.org; Mon, 18 Jan 2021 17:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Fabrice BAUZAC-STEHLY Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Jan 2021 22:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45800 X-GNU-PR-Package: emacs Original-Received: via spool by 45800-submit@debbugs.gnu.org id=B45800.16110086224732 (code B ref 45800); Mon, 18 Jan 2021 22:24:02 +0000 Original-Received: (at 45800) by debbugs.gnu.org; 18 Jan 2021 22:23:42 +0000 Original-Received: from localhost ([127.0.0.1]:48635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1cw1-0001EE-R6 for submit@debbugs.gnu.org; Mon, 18 Jan 2021 17:23:42 -0500 Original-Received: from mx.kolabnow.com ([95.128.36.41]:12460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1ceU-0000jo-Ld for 45800@debbugs.gnu.org; Mon, 18 Jan 2021 17:05:35 -0500 Original-Received: from localhost (unknown [127.0.0.1]) by ext-mx-out001.mykolab.com (Postfix) with ESMTP id 5B971B0B; Mon, 18 Jan 2021 23:05:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mykolab.com; h= content-type:content-type:mime-version:message-id:in-reply-to :date:date:references:subject:subject:from:from:received :received:received:received; s=dkim20160331; t=1611007527; x= 1612821928; bh=GyFzkdBEkdYQ/kdWVJyqOwYo40DM/LgFV66CY3bPi/Q=; b=2 LT5yYT16EUWaKJy+65Bbuv/Sabsd6UC1/w0D9KA5bQRJ7p4G9Fdb0+W/YSUMpSGm KPRpa4d+f43QPbphXTcOCwYiTE+L8jswh0uCUbwnbcDxFXlClk4jOmV08T6MQcx6 v1jbyzzTJCtma/VeBhH47P5NC8p6d17N6MJ10unn8x9ltkT/RTgEiEPfkoQIf3iI AMYa7inX91Pnv1eqOhfwZAtfNBC2w94L0kgixPPr+AHf1Ap3s+orfc7HoVdafGiq dqIwemLeqAwPj8gr6J5hPeMqVtzGID7foekHBUlx5sm506VPDCfIjNl98oUXzOIq gu2mLVdYspTbjKMFERiIaZOLR7xfjxlippSmL7ZtHd3XTX3z4UawC2I86eyf7u26 GMSBHegl4T0ZRk/7mVZ6kdsiuS6ixFxOV5PWbzCTqQ8hB9CYoDO3qFa87FVWuZpB kpvhmWee+o1G5FgiSFprKHVWTk0nXQlpMrFqh6nofpG8rKthbYgAtKfaKiNfOJqt 8YxblCpUth4EFe+bGfz59XiGpG4jiAFj8VKOu7DiosWRvKvdO X-Virus-Scanned: amavisd-new at mykolab.com Original-Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out001.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ehZVln71Km_I; Mon, 18 Jan 2021 23:05:27 +0100 (CET) Original-Received: from int-mx001.mykolab.com (unknown [10.9.13.1]) by ext-mx-out001.mykolab.com (Postfix) with ESMTPS id DE724A51; Mon, 18 Jan 2021 23:05:26 +0100 (CET) Original-Received: from ext-subm001.mykolab.com (unknown [10.9.6.1]) by int-mx001.mykolab.com (Postfix) with ESMTPS id 5DB5183E; Mon, 18 Jan 2021 23:05:26 +0100 (CET) Original-Received: from noon by asus.home with local (Exim 4.94) (envelope-from ) id 1l1ceK-0007nV-Ce; Mon, 18 Jan 2021 23:05:24 +0100 In-Reply-To: <874kjf1t3d.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 17 Jan 2021 15:27:50 +0000") X-Mailman-Approved-At: Mon, 18 Jan 2021 17:23:40 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198104 Archived-At: "Basil L. Contovounesios" writes: > Fabrice BAUZAC-STEHLY writes: > >> To fix this on my side, I have replaced both occurrences of >> (buffer-file-name (car X)) >> with >> (with-current-buffer (car X) (ibuffer-buffer-file-name)) >> which seems to work: > > Thanks, that looks correct. Would you like to provide a patch against > master to that effect? Sure, here it is: diff --git a/lisp/ibuf-ext.el b/lisp/ibuf-ext.el index ed5c9c0211..44574abd46 100644 --- a/lisp/ibuf-ext.el +++ b/lisp/ibuf-ext.el @@ -1497,10 +1497,10 @@ filename/process (string-lessp ;; FIXME: For now just compare the file name and the process name ;; (if it exists). Is there a better way to do this? - (or (buffer-file-name (car a)) + (or (with-current-buffer (car a) (ibuffer-buffer-file-name)) (let ((pr-a (get-buffer-process (car a)))) (and (processp pr-a) (process-name pr-a)))) - (or (buffer-file-name (car b)) + (or (with-current-buffer (car b) (ibuffer-buffer-file-name)) (let ((pr-b (get-buffer-process (car b)))) (and (processp pr-b) (process-name pr-b)))))) > I think your cumulative changes would still be exempt of copyright > paperwork, but would you be willing to start the copyright assignment > process for future changes that exceed the limit, if you haven't > already? Yes, no problem for that. -- Fabrice Bauzac-Stehly PGP 01EEACF8244E9C14B551C5256ADA5F189BD322B6 old PGP 015AE9B25DCB0511D200A75DE5674DEA514C891D