* bug#51524: [PATCH] ; * doc/misc/org.org: fix capture context example
@ 2021-10-30 19:51 Hanno Perrey
2021-10-31 15:23 ` Lars Ingebrigtsen
0 siblings, 1 reply; 8+ messages in thread
From: Hanno Perrey @ 2021-10-30 19:51 UTC (permalink / raw)
To: 51524
[-- Attachment #1: Type: text/plain, Size: 354 bytes --]
Hej,
the attached patch fixes a typo in the org-mode info pages: the examples
for org-capture contexts are each missing a pair of parenthesis as
detailed in the doc string for org-capture-templates-contexts, leading
to a "Wrong type argument: listp, in-mode" error when invoking org-capture.
Thanks for the great work on Emacs and best wishes,
Hanno
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch org-mode doc --]
[-- Type: text/x-diff, Size: 1206 bytes --]
From fe58a9b0800f69c55218c7f0ce3306057c511a57 Mon Sep 17 00:00:00 2001
From: Hanno Perrey <hanno@hoowl.se>
Date: Sat, 30 Oct 2021 21:34:04 +0200
Subject: [PATCH] ; * doc/misc/org.org: fix capture context example
Add missing parenthesis to code example for org-capture
template contexts as documented in docstring
Copyright-paperwork-exempt: yes
---
doc/misc/org.org | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/misc/org.org b/doc/misc/org.org
index 788e5efedf..17fd2dc39f 100644
--- a/doc/misc/org.org
+++ b/doc/misc/org.org
@@ -7981,7 +7981,7 @@ patches. Then you would configure this option like this:
#+begin_src emacs-lisp
(setq org-capture-templates-contexts
- '(("p" (in-mode . "message-mode"))))
+ '(("p" ((in-mode . "message-mode")))))
#+end_src
You can also tell that the command key {{{kbd(p)}}} should refer to
@@ -7989,7 +7989,7 @@ another template. In that case, add this command key like this:
#+begin_src emacs-lisp
(setq org-capture-templates-contexts
- '(("p" "q" (in-mode . "message-mode"))))
+ '(("p" "q" ((in-mode . "message-mode")))))
#+end_src
See the docstring of the variable for more information.
--
2.33.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* bug#51524: [PATCH] ; * doc/misc/org.org: fix capture context example
2021-10-30 19:51 bug#51524: [PATCH] ; * doc/misc/org.org: fix capture context example Hanno Perrey
@ 2021-10-31 15:23 ` Lars Ingebrigtsen
2021-10-31 15:32 ` Eli Zaretskii
0 siblings, 1 reply; 8+ messages in thread
From: Lars Ingebrigtsen @ 2021-10-31 15:23 UTC (permalink / raw)
To: Hanno Perrey; +Cc: 51524
Hanno Perrey <hanno@hoowl.se> writes:
> the attached patch fixes a typo in the org-mode info pages: the examples
> for org-capture contexts are each missing a pair of parenthesis as
> detailed in the doc string for org-capture-templates-contexts, leading
> to a "Wrong type argument: listp, in-mode" error when invoking org-capture.
Thanks for the patch; I've now pushed it to emacs-28.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#51524: [PATCH] ; * doc/misc/org.org: fix capture context example
2021-10-31 15:23 ` Lars Ingebrigtsen
@ 2021-10-31 15:32 ` Eli Zaretskii
2021-10-31 15:36 ` Lars Ingebrigtsen
2021-11-21 9:04 ` Bastien
0 siblings, 2 replies; 8+ messages in thread
From: Eli Zaretskii @ 2021-10-31 15:32 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: hanno, 51524
> Resent-From: Lars Ingebrigtsen <larsi@gnus.org>
> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
> Resent-CC: bug-gnu-emacs@gnu.org
> Resent-Sender: help-debbugs@gnu.org
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Sun, 31 Oct 2021 16:23:23 +0100
> Cc: 51524@debbugs.gnu.org
>
> Hanno Perrey <hanno@hoowl.se> writes:
>
> > the attached patch fixes a typo in the org-mode info pages: the examples
> > for org-capture contexts are each missing a pair of parenthesis as
> > detailed in the doc string for org-capture-templates-contexts, leading
> > to a "Wrong type argument: listp, in-mode" error when invoking org-capture.
>
> Thanks for the patch; I've now pushed it to emacs-28.
Aren't Org changes supposed to come from merges of the Org repository?
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#51524: [PATCH] ; * doc/misc/org.org: fix capture context example
2021-10-31 15:32 ` Eli Zaretskii
@ 2021-10-31 15:36 ` Lars Ingebrigtsen
2021-11-21 9:06 ` Bastien
2021-11-21 9:04 ` Bastien
1 sibling, 1 reply; 8+ messages in thread
From: Lars Ingebrigtsen @ 2021-10-31 15:36 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: hanno, 51524
Eli Zaretskii <eliz@gnu.org> writes:
> Aren't Org changes supposed to come from merges of the Org repository?
I thought they merged back changes from Emacs?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#51524: [PATCH] ; * doc/misc/org.org: fix capture context example
2021-10-31 15:36 ` Lars Ingebrigtsen
@ 2021-11-21 9:06 ` Bastien
2021-11-21 9:10 ` Eli Zaretskii
0 siblings, 1 reply; 8+ messages in thread
From: Bastien @ 2021-11-21 9:06 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: hanno, 51524
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>> Aren't Org changes supposed to come from merges of the Org repository?
>
> I thought they merged back changes from Emacs?
Yes, changes from Emacs are backported to Org upstream:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?h=bugfix&id=c5d66563
(Sorry, my previous reply to Eli was meant as a reply to you.)
--
Bastien
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#51524: [PATCH] ; * doc/misc/org.org: fix capture context example
2021-11-21 9:06 ` Bastien
@ 2021-11-21 9:10 ` Eli Zaretskii
2021-11-21 21:52 ` Bastien
0 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2021-11-21 9:10 UTC (permalink / raw)
To: Bastien; +Cc: hanno, larsi, 51524
> From: Bastien <bzg@gnu.org>
> Cc: Eli Zaretskii <eliz@gnu.org>, hanno@hoowl.se, 51524@debbugs.gnu.org
> Date: Sun, 21 Nov 2021 10:06:07 +0100
>
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> >> Aren't Org changes supposed to come from merges of the Org repository?
> >
> > I thought they merged back changes from Emacs?
>
> Yes, changes from Emacs are backported to Org upstream:
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?h=bugfix&id=c5d66563
So it's okay with you if we make changes in Org on our branches? I
worried that doing so might make merging more difficult for you guys.
Thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#51524: [PATCH] ; * doc/misc/org.org: fix capture context example
2021-10-31 15:32 ` Eli Zaretskii
2021-10-31 15:36 ` Lars Ingebrigtsen
@ 2021-11-21 9:04 ` Bastien
1 sibling, 0 replies; 8+ messages in thread
From: Bastien @ 2021-11-21 9:04 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: hanno, Lars Ingebrigtsen, 51524
Hi Eli,
Eli Zaretskii <eliz@gnu.org> writes:
> Aren't Org changes supposed to come from merges of the Org
> repository?
Yes, they are, see for example:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?h=bugfix&id=c5d66563
--
Bastien
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-11-21 21:52 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-30 19:51 bug#51524: [PATCH] ; * doc/misc/org.org: fix capture context example Hanno Perrey
2021-10-31 15:23 ` Lars Ingebrigtsen
2021-10-31 15:32 ` Eli Zaretskii
2021-10-31 15:36 ` Lars Ingebrigtsen
2021-11-21 9:06 ` Bastien
2021-11-21 9:10 ` Eli Zaretskii
2021-11-21 21:52 ` Bastien
2021-11-21 9:04 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).