* bug#51800: 29.0.50; vc-{cvs,dav,rcs,sccs}-responsible-p should not return t
@ 2021-11-13 1:24 TAKAHASHI Yoshio
2021-11-14 1:39 ` Lars Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: TAKAHASHI Yoshio @ 2021-11-13 1:24 UTC (permalink / raw)
To: 51800
Hi,
vc-*-responsible-p should not return t.
it should return nil or path string.
for example, `vc-rcs-responsible-p' returns the result of
`file-directory-p', that is t or nil.
if it returns t, the caller, `vc-backend-for-registration', raises an
error, because it expects SEQUENCE.
--
tkh
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#51800: 29.0.50; vc-{cvs,dav,rcs,sccs}-responsible-p should not return t
2021-11-13 1:24 bug#51800: 29.0.50; vc-{cvs,dav,rcs,sccs}-responsible-p should not return t TAKAHASHI Yoshio
@ 2021-11-14 1:39 ` Lars Ingebrigtsen
0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2021-11-14 1:39 UTC (permalink / raw)
To: TAKAHASHI Yoshio; +Cc: 51800
TAKAHASHI Yoshio <yfb02119@nifty.com> writes:
> vc-*-responsible-p should not return t.
> it should return nil or path string.
>
> for example, `vc-rcs-responsible-p' returns the result of
> `file-directory-p', that is t or nil.
> if it returns t, the caller, `vc-backend-for-registration', raises an
> error, because it expects SEQUENCE.
Yup. I've now fixed this in Emacs 29.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-14 1:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-13 1:24 bug#51800: 29.0.50; vc-{cvs,dav,rcs,sccs}-responsible-p should not return t TAKAHASHI Yoshio
2021-11-14 1:39 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).