unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#52366: GNU Emacsen 28.0.90 and 29.0.50 have buggy calendar mode lines
@ 2021-12-08  0:24 Peter Dyballa
  2021-12-08  9:23 ` Stephen Berman
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Dyballa @ 2021-12-08  0:24 UTC (permalink / raw)
  To: 52366

[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

Hello!

The screenshot from macOS 12.0.1 (Monterey) shows in foreground at the top GNU Emacs 29.0.50 (built in MacPorts) and in foreground at the bottom GNU Emacs 28.0.90 (built manually with MacPorts' Clang 13) and in-between in background GNU Emacs 28.0.50 (built manually with Clang 11 in an older version of macOS, 11.X, Big Sur) which has a correct mode-line. The other two versions display in calendar mode-line a white background where the command options '?', 'o' or '.' are shown. (GNU Emacsen 28.0.X use a "germanised" version of calendar.)

The question is whether it's the source code or it's the macOS version that produces the faults…


[-- Attachment #2: Buggy calendar mode-line.pdf --]
[-- Type: application/pdf, Size: 875232 bytes --]

[-- Attachment #3: Type: text/plain, Size: 137 bytes --]



--
Greetings

  Pete

I hope to die before I *have* to use Microsoft Word.
				– Donald E. Knuth, 2001-10-02 in Tübingen


^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#52366: GNU Emacsen 28.0.90 and 29.0.50 have buggy calendar mode lines
  2021-12-08  0:24 bug#52366: GNU Emacsen 28.0.90 and 29.0.50 have buggy calendar mode lines Peter Dyballa
@ 2021-12-08  9:23 ` Stephen Berman
  2021-12-08 14:24   ` Eli Zaretskii
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Berman @ 2021-12-08  9:23 UTC (permalink / raw)
  To: Peter Dyballa; +Cc: 52366

On Wed, 8 Dec 2021 01:24:44 +0100 Peter Dyballa <Peter_Dyballa@Web.DE> wrote:

> Hello!
>
> The screenshot from macOS 12.0.1 (Monterey) shows in foreground at the top GNU
> Emacs 29.0.50 (built in MacPorts) and in foreground at the bottom GNU Emacs
> 28.0.90 (built manually with MacPorts' Clang 13) and in-between in background
> GNU Emacs 28.0.50 (built manually with Clang 11 in an older version of macOS,
> 11.X, Big Sur) which has a correct mode-line. The other two versions display
> in calendar mode-line a white background where the command options '?', 'o' or
> '.' are shown. (GNU Emacsen 28.0.X use a "germanised" version of calendar.)
>
> The question is whether it's the source code or it's the macOS version that
> produces the faults…

It's due to an Emacs change, the `help-key-binding' face, added in this
commit:

  commit 4a112fd7a6f0dcbd1b99b811b324123f5699bdfb
  Author:     Stefan Kangas <stefan@marxist.se>
  Commit:     Stefan Kangas <stefan@marxist.se>
  CommitDate: Mon Mar 8 04:23:08 2021 +0100
  
      Add new face 'help-key-binding' for keybindings in help

Steve Berman





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#52366: GNU Emacsen 28.0.90 and 29.0.50 have buggy calendar mode lines
  2021-12-08  9:23 ` Stephen Berman
@ 2021-12-08 14:24   ` Eli Zaretskii
  2021-12-15 20:52     ` Stefan Kangas
  0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2021-12-08 14:24 UTC (permalink / raw)
  To: Stephen Berman; +Cc: Peter_Dyballa, 52366

> From: Stephen Berman <stephen.berman@gmx.net>
> Date: Wed, 08 Dec 2021 10:23:52 +0100
> Cc: 52366@debbugs.gnu.org
> 
> On Wed, 8 Dec 2021 01:24:44 +0100 Peter Dyballa <Peter_Dyballa@Web.DE> wrote:
> 
> > Hello!
> >
> > The screenshot from macOS 12.0.1 (Monterey) shows in foreground at the top GNU
> > Emacs 29.0.50 (built in MacPorts) and in foreground at the bottom GNU Emacs
> > 28.0.90 (built manually with MacPorts' Clang 13) and in-between in background
> > GNU Emacs 28.0.50 (built manually with Clang 11 in an older version of macOS,
> > 11.X, Big Sur) which has a correct mode-line. The other two versions display
> > in calendar mode-line a white background where the command options '?', 'o' or
> > '.' are shown. (GNU Emacsen 28.0.X use a "germanised" version of calendar.)
> >
> > The question is whether it's the source code or it's the macOS version that
> > produces the faults…
> 
> It's due to an Emacs change, the `help-key-binding' face, added in this
> commit:
> 
>   commit 4a112fd7a6f0dcbd1b99b811b324123f5699bdfb
>   Author:     Stefan Kangas <stefan@marxist.se>
>   Commit:     Stefan Kangas <stefan@marxist.se>
>   CommitDate: Mon Mar 8 04:23:08 2021 +0100
>   
>       Add new face 'help-key-binding' for keybindings in help

Thanks for the analysis.  This should be fixed now on the emacs-28
branch.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#52366: GNU Emacsen 28.0.90 and 29.0.50 have buggy calendar mode lines
  2021-12-08 14:24   ` Eli Zaretskii
@ 2021-12-15 20:52     ` Stefan Kangas
  0 siblings, 0 replies; 4+ messages in thread
From: Stefan Kangas @ 2021-12-15 20:52 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Peter_Dyballa, Stephen Berman, 52366

close 52366 28.1
thanks

Eli Zaretskii <eliz@gnu.org> writes:

>> It's due to an Emacs change, the `help-key-binding' face, added in this
>> commit:
>>
>>   commit 4a112fd7a6f0dcbd1b99b811b324123f5699bdfb
>>   Author:     Stefan Kangas <stefan@marxist.se>
>>   Commit:     Stefan Kangas <stefan@marxist.se>
>>   CommitDate: Mon Mar 8 04:23:08 2021 +0100
>>
>>       Add new face 'help-key-binding' for keybindings in help
>
> Thanks for the analysis.  This should be fixed now on the emacs-28
> branch.

No further comments within a week, and I can't reproduce this problem so
I'm assuming this is fixed.  I'm therefore closing this bug report.





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-12-15 20:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-08  0:24 bug#52366: GNU Emacsen 28.0.90 and 29.0.50 have buggy calendar mode lines Peter Dyballa
2021-12-08  9:23 ` Stephen Berman
2021-12-08 14:24   ` Eli Zaretskii
2021-12-15 20:52     ` Stefan Kangas

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).