From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 32921@debbugs.gnu.org, larsi@gnus.org, jimis@gmx.net
Subject: bug#32921: emacsclient obeys Xresources even when launched with -nw
Date: Thu, 19 May 2022 21:09:51 +0800 [thread overview]
Message-ID: <87h75l1xeo.fsf@yahoo.com> (raw)
In-Reply-To: <83sfp5d7ad.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 19 May 2022 15:40:58 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> We already do that, see the information and the backtrace posted by
> Lars a while ago.
Hmm... then why does this code still exist at all?
x-create-frame-with-faces should take care of setting the `reverse'
parameter entirely.
Could you please explain what you meant by "startup timer" here?
> So the difference is between (a) taking notice of the reverseVideo
> resource at startup timer as opposed to (b) at frame creation time, is
^^^^^^^^^^^^^
> that right? If so, I think this might affect the use case whereby
> someone changes the X resources after Emacs has already started, or
> something?
Though I doubt this really matters, since X resources cannot change
after Emacs starts.
> The code in x-win.el does something beyond that: it caters for people
> who have X resources specified on their user-private files, and want
> those settings to be in effect on all displays.
But then why only a single resource, and not all of them? Especially
an obscure one like reverseVideo?
BTW, I think I found out why this situation is. Before Emacs 19.29,
reverseVideo and selectionTimeout were both set up in x-win.el assuming
that there would only ever be a single display, just like the other
frame parameters in Fx_create_frame.
When support for multiple displays was added in 19.29, the changes to
make X resources affecting frame parameters specific to each display
were made to the C code in Fx_create_frame, but not to the two
parameters set in Lisp. Whether or not that was done intentionally is
anyone's guess, but I think it was a bug, or an oversight.
> (And besides, what is the chance that someone will want different
> values of reverseVideo on different displays? I think the chances for
> that are nil.)
Many other programs accept a resource named reverseVideo (it and -rv are
a very standard knobs for X programs), so I can imagine someone placing:
*.reverseVideo: on
in the X resources for an X server with dark window decorations, and
vice versa. Emacs should create frames with the colors specified on
each server it is connected to.
> Because we will otherwise break a long-standing behavior.
[...]
> People who want Emacs to behave like you describe can simply remove
> this setting from their ~/.Xdefaults.
That wouldn't be useful, since Emacs doesn't even load ~/.Xdefaults if
the X server it connected to already has some resources loaded. Doing
that is the job of the session script(s) that started the X server.
> Not necessarily, because frame-parameters applied by
> gui_default_parameter could override those we took from ~/.Xdefaults.
I meant the parameters applied by gui_default_parameter when the
parameter is not present in `default-frame-alist' or the ALIST argument.
Thanks.
next prev parent reply other threads:[~2022-05-19 13:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 17:49 bug#32921: emacsclient obeys Xresources even when launched with -nw Dimitrios Apostolou
2022-05-18 12:38 ` Lars Ingebrigtsen
2022-05-18 13:02 ` Eli Zaretskii
2022-05-18 13:13 ` Lars Ingebrigtsen
2022-05-18 13:27 ` Eli Zaretskii
2022-05-18 13:52 ` Lars Ingebrigtsen
2022-05-18 14:00 ` Eli Zaretskii
2022-05-19 22:58 ` Lars Ingebrigtsen
2022-05-19 1:37 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-19 7:02 ` Eli Zaretskii
2022-05-19 7:47 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-19 8:26 ` Eli Zaretskii
2022-05-19 8:59 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-19 9:44 ` Eli Zaretskii
2022-05-19 10:19 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-19 12:40 ` Eli Zaretskii
2022-05-19 13:09 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-05-19 13:23 ` Eli Zaretskii
2022-05-19 13:40 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-19 13:55 ` Eli Zaretskii
2022-05-20 1:04 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-20 7:03 ` Eli Zaretskii
2022-05-20 8:15 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-19 23:04 ` Lars Ingebrigtsen
2022-05-20 6:54 ` Eli Zaretskii
2022-05-20 8:19 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-20 10:50 ` Eli Zaretskii
2022-05-20 8:28 ` Lars Ingebrigtsen
2022-05-20 11:00 ` Eli Zaretskii
2022-05-20 11:30 ` Lars Ingebrigtsen
2022-06-19 13:28 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h75l1xeo.fsf@yahoo.com \
--to=bug-gnu-emacs@gnu.org \
--cc=32921@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jimis@gmx.net \
--cc=larsi@gnus.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).