* bug#21979: [PATCH] Update gv setter for frame-width and frame-height.
@ 2015-11-21 21:26 Christopher Wellons
2016-02-23 4:45 ` Lars Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: Christopher Wellons @ 2015-11-21 21:26 UTC (permalink / raw)
To: 21979; +Cc: Christopher Wellons
Neither set-screen-width nor set-screen-height still exist, having been
replaced by set-frame-width and set-frame-height. These newer functions
take a frame as a second argument, so a simple setter will no longer
work.
---
lisp/emacs-lisp/cl-lib.el | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lisp/emacs-lisp/cl-lib.el b/lisp/emacs-lisp/cl-lib.el
index 2dd0519..5a90c19 100644
--- a/lisp/emacs-lisp/cl-lib.el
+++ b/lisp/emacs-lisp/cl-lib.el
@@ -660,10 +660,12 @@ cl-pairlis
(gv-define-setter face-underline-p (x f &optional s)
`(set-face-underline ,f ,x ,s))
(gv-define-simple-setter file-modes set-file-modes t)
-(gv-define-simple-setter frame-height set-screen-height t)
+(gv-define-setter frame-height (x &optional frame)
+ `(set-frame-height (or ,frame (selected-frame)) ,x))
(gv-define-simple-setter frame-parameters modify-frame-parameters t)
(gv-define-simple-setter frame-visible-p cl--set-frame-visible-p)
-(gv-define-simple-setter frame-width set-screen-width t)
+(gv-define-setter frame-width (x &optional frame)
+ `(set-frame-width (or ,frame (selected-frame)) ,x))
(gv-define-simple-setter getenv setenv t)
(gv-define-simple-setter get-register set-register)
(gv-define-simple-setter global-key-binding global-set-key)
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#21979: [PATCH] Update gv setter for frame-width and frame-height.
2015-11-21 21:26 bug#21979: [PATCH] Update gv setter for frame-width and frame-height Christopher Wellons
@ 2016-02-23 4:45 ` Lars Ingebrigtsen
0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2016-02-23 4:45 UTC (permalink / raw)
To: Christopher Wellons; +Cc: 21979
Christopher Wellons <wellons@nullprogram.com> writes:
> Neither set-screen-width nor set-screen-height still exist, having been
> replaced by set-frame-width and set-frame-height. These newer functions
> take a frame as a second argument, so a simple setter will no longer
> work.
Thanks; applied to emacs-25.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-23 4:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-21 21:26 bug#21979: [PATCH] Update gv setter for frame-width and frame-height Christopher Wellons
2016-02-23 4:45 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).