From: npostavs@users.sourceforge.net
To: Samuel Freilich <sfreilich@google.com>
Cc: 20774@debbugs.gnu.org
Subject: bug#20774: auto-fill doesn't work properly when first-line prefix differs in adaptive-fill-mode
Date: Thu, 24 Aug 2017 21:45:17 -0400 [thread overview]
Message-ID: <87fucga09e.fsf@users.sourceforge.net> (raw)
In-Reply-To: <CACQEUgM-bfjUAwstyvLyAp8FN3qk6dk=w+GdPOntDpK3xHz53A@mail.gmail.com> (Samuel Freilich's message of "Thu, 24 Aug 2017 11:11:12 -0400")
Samuel Freilich <sfreilich@google.com> writes:
> You're right about string-width, since I'm counting number of columns.
> Fixed that. (Which required me to deal with the fact that fill-prefix can
> be nil.)
Actually, it's now occuring to me that adding a position to a
string-width isn't quite correct either, since it doesn't take into
account wide characters on the current line. I guess it should actually
be something like
(save-excursion
(if line-prefix
(move-to-column (string-width line-prefix))
(beginning-of-line))
(point))
> I've attached the fixed version of the patch with a hopefully-improved
> commit message.
That is much better, thanks. (One more minor formatting nitpick, there
should be 2 spaces after the period.)
next prev parent reply other threads:[~2017-08-25 1:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 23:39 bug#20774: auto-fill doesn't work properly when first-line prefix differs in adaptive-fill-mode Samuel Freilich
2015-06-26 23:40 ` bug#20774: Typo in Patch Samuel Freilich
2017-08-22 12:49 ` bug#20774: auto-fill doesn't work properly when first-line prefix differs in adaptive-fill-mode npostavs
2017-08-22 16:00 ` Samuel Freilich
2017-08-23 3:56 ` npostavs
2017-08-23 18:20 ` Samuel Freilich
2017-08-24 2:16 ` npostavs
2017-08-24 15:11 ` Samuel Freilich
2017-08-25 1:45 ` npostavs [this message]
2017-08-29 3:37 ` npostavs
2017-08-29 3:55 ` npostavs
2017-08-31 0:51 ` npostavs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fucga09e.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=20774@debbugs.gnu.org \
--cc=sfreilich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).