From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#20774: auto-fill doesn't work properly when first-line prefix differs in adaptive-fill-mode Date: Thu, 24 Aug 2017 21:45:17 -0400 Message-ID: <87fucga09e.fsf@users.sourceforge.net> References: <878tibbwcv.fsf@users.sourceforge.net> <87wp5v9bsp.fsf@users.sourceforge.net> <87r2w1aew4.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1503625479 28604 195.159.176.226 (25 Aug 2017 01:44:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 25 Aug 2017 01:44:39 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 20774@debbugs.gnu.org To: Samuel Freilich Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 25 03:44:34 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dl3fY-0006R2-Bz for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Aug 2017 03:44:20 +0200 Original-Received: from localhost ([::1]:51096 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dl3ff-0005TE-4L for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Aug 2017 21:44:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dl3fK-0005Lv-C2 for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2017 21:44:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dl3fH-0007Jb-1L for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2017 21:44:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44713) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dl3fG-0007JP-TU for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2017 21:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dl3fG-000879-E2 for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2017 21:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Aug 2017 01:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20774 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 20774-submit@debbugs.gnu.org id=B20774.150362542731159 (code B ref 20774); Fri, 25 Aug 2017 01:44:02 +0000 Original-Received: (at 20774) by debbugs.gnu.org; 25 Aug 2017 01:43:47 +0000 Original-Received: from localhost ([127.0.0.1]:53394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dl3f1-00086V-Fs for submit@debbugs.gnu.org; Thu, 24 Aug 2017 21:43:47 -0400 Original-Received: from mail-it0-f49.google.com ([209.85.214.49]:37565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dl3f0-00086I-48 for 20774@debbugs.gnu.org; Thu, 24 Aug 2017 21:43:46 -0400 Original-Received: by mail-it0-f49.google.com with SMTP id 77so591020itj.0 for <20774@debbugs.gnu.org>; Thu, 24 Aug 2017 18:43:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=re914tYfXRv/RhByu+lizHA+faFFYbKUhXaEZrOvarQ=; b=UKkjE8RdIxz7KcLJ85NO0cZK2/QpQYnNTXRx9dM6QqqmeQEn4xJoC+ZTkT8rUPZKMd LR2gAyZTbL+pamllL8nrw7YeVIKqiSEydysilMNPW6hqWe4N964x6oJfRMw7pjICT3Fg mkknPdAOOpkWqUIvGZMvenDFy7npfdoCdTnuC1tWwT2z4Ry8DBx5ZvTr9r4+tyVauA18 HH1P9qpZdANAiuV81H/FGijlJwE3uHK8POJ8IckOgcqfGLRo48Hhng9fp0+VAxJVnvUC C68MNDBLw/6/emhkKvF30b7IhSjy1z2fim0PAEfvIFpLmLg+PrF8NzyjSi7X09ZZgcUE deUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=re914tYfXRv/RhByu+lizHA+faFFYbKUhXaEZrOvarQ=; b=pti+MaVRUKSHz/YHk3LdOCPPhQdpP+M61DAx//jFYF8w4teoN8inzw7bvfwBNhRU4v PQ85IpaDMBsxBVXBG8gnoD0Mr+IyBe986J7trwDqV7jrr5r0SdPbGIi8YyHX+PWjVt03 a/aKmJXYdGB2dyK2iOh/mnnazzRJpmS/6bFp3hYlGYMyWxXQT5GYDwd5Ax04hjaiIS+F AMasRKJs7fTCBAwk9QYBbB2RePpLBs1ZIRHGblGsQCQgT51dN9c6KreUJZE42OFQyOkl B66gld7MoPHOu0rryiwk7PxK+GWt0TXtAyfvUmroaYJh1qiq8QkP8SAMNLssajUnkvKX h/Jg== X-Gm-Message-State: AHYfb5jcl0ccVHHbQTaQ24g9Ik2DnK13fW0+Bpsoz1dMeVQ5idvt04I1 0RmZ32f3F3NwhH5P X-Received: by 10.36.104.210 with SMTP id v201mr710586itb.95.1503625420400; Thu, 24 Aug 2017 18:43:40 -0700 (PDT) Original-Received: from zony ([45.2.119.49]) by smtp.googlemail.com with ESMTPSA id q21sm234087itb.28.2017.08.24.18.43.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 24 Aug 2017 18:43:38 -0700 (PDT) In-Reply-To: (Samuel Freilich's message of "Thu, 24 Aug 2017 11:11:12 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136176 Archived-At: Samuel Freilich writes: > You're right about string-width, since I'm counting number of columns. > Fixed that. (Which required me to deal with the fact that fill-prefix can > be nil.) Actually, it's now occuring to me that adding a position to a string-width isn't quite correct either, since it doesn't take into account wide characters on the current line. I guess it should actually be something like (save-excursion (if line-prefix (move-to-column (string-width line-prefix)) (beginning-of-line)) (point)) > I've attached the fixed version of the patch with a hopefully-improved > commit message. That is much better, thanks. (One more minor formatting nitpick, there should be 2 spaces after the period.)