From: Juri Linkov <juri@linkov.net>
To: Drew Adams <drew.adams@oracle.com>
Cc: 18090@debbugs.gnu.org
Subject: bug#18090: 24.4.50; `delete-selection-helper' logic changed for non-mouse region?
Date: Mon, 24 Sep 2018 22:08:46 +0300 [thread overview]
Message-ID: <87ftxy69o9.fsf@mail.linkov.net> (raw)
In-Reply-To: <626fca93-0fba-4dd7-b119-7187b818dccb@default> (Drew Adams's message of "Sun, 23 Sep 2018 18:35:03 -0700 (PDT)")
>> You are missing the <mouse-2> part above.
>
> I wasn't missing it. I was trying to point out that that code has nothing
> to do with mouse yanking. As you say, mouse-yank commands are not
> supported by `delete-selection-mode' - they do not have a `yank'
> `delete-selection-mode' property value.
Shouldn't mouse yanking be supported by `delete-selection-mode',
what do you think?
> That code, which you say could be deleted altogether, is essential for
> `delete-selection-mode' to handle `yank'. Don't you agree? That was
> my point. The code in question is about commands whose property
> value is `yank'.
I agree that code that calls (delete-active-region) under the
condition (eq type 'yank) is essential to handle `yank'.
But I think that (current-kill 1) is not essential
unless it renders yank useless in some cases (yet unknown).
> Do you agree? If not, why do you think all of that code could be deleted?
Neither agree nor disagree. Please provide a recipe to show the buggy behavior
like Eli asked you to do.
> Anyway, I think I understand why you added the `mouse-region-match'
> condition now. But it seems to me that that condition should be used,
> as Eli hinted, only when `mouse-drag-copy-region' is non-nil. (It is nil
> by default now.)
>
> Do you agree? Isn't that the (only) case where you are bothered by
> the mouse selection being replaced by the previous kill-ring entry
> (instead of the implicit one from the mouse selection)?
>
> IOW, do you think this addition makes sense?
>
> (when (and (string= (buffer-substring-no-properties
> (point) (mark))
> (car kill-ring))
> mouse-drag-copy-region ; <======
> (fboundp 'mouse-region-match)
> (mouse-region-match))
> (current-kill 1))
I don't know yet. Please describe the settings and steps
that would show how to test this.
Here is a template to help you to create a bug report:
0. emacs -Q
1. M-x delete-selection-mode RET
2. Eval: (setq mouse-drag-copy-region t)
3. Drag mouse to select a word in *scratch*
4. Type `M-w' to copy selected word to the kill-ring
5. Drag mouse to select another word in *scratch*
6. Type `C-y' to yank the word from the kill-ring
I see that the previously copied word correctly replaced the selected word,
so I see no bug here.
next prev parent reply other threads:[~2018-09-24 19:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 18:02 bug#18090: 24.4.50; `delete-selection-helper' logic changed for non-mouse region? Drew Adams
2018-04-03 21:06 ` Drew Adams
2018-09-19 17:51 ` Drew Adams
2018-09-20 6:15 ` Eli Zaretskii
2018-09-20 15:04 ` Drew Adams
2018-09-20 20:52 ` Juri Linkov
2018-09-20 21:55 ` Drew Adams
2018-09-20 22:50 ` Juri Linkov
2018-09-24 1:35 ` Drew Adams
2018-09-24 19:08 ` Juri Linkov [this message]
2018-09-24 21:16 ` Drew Adams
2018-09-25 19:02 ` Juri Linkov
2018-09-21 6:47 ` Eli Zaretskii
2022-02-20 13:06 ` Lars Ingebrigtsen
2022-03-21 18:30 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftxy69o9.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=18090@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).