unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#44270: 24.5; EMMA failures while installing
@ 2020-10-28  1:50 John Gilmore
  2020-10-28 11:31 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 7+ messages in thread
From: John Gilmore @ 2020-10-28  1:50 UTC (permalink / raw)
  To: 44270, gnu


M-x list-packages
picked emms, hit Install.
I've included the *Compile-Log* buffer contents, which include one
error and several warnings.

This was the first time I tried using ELPA and the first time I tried
installing EMMS.  I have no idea if it is working, I just wanted to
report these errors and warnings.  I was inspired to try it by the
gnu-announce email about the latest EMMS and how this is the last
tarball release.



In GNU Emacs 24.5.1 (x86_64-pc-linux-gnu, GTK+ Version 3.18.9)
 of 2017-09-20 on lcy01-07, modified by Debian
System Description:	Ubuntu 16.04.6 LTS

Configured using:
 `configure --build x86_64-linux-gnu --prefix=/usr
 --sharedstatedir=/var/lib --libexecdir=/usr/lib
 --localstatedir=/var/lib --infodir=/usr/share/info
 --mandir=/usr/share/man --with-pop=yes
 --enable-locallisppath=/etc/emacs24:/etc/emacs:/usr/local/share/emacs/24.5/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.5/site-lisp:/usr/share/emacs/site-lisp
 --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib
 --libexecdir=/usr/lib --localstatedir=/var/lib
 --infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes
 --enable-locallisppath=/etc/emacs24:/etc/emacs:/usr/local/share/emacs/24.5/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.5/site-lisp:/usr/share/emacs/site-lisp
 --with-x=yes --with-x-toolkit=gtk3 --with-toolkit-scroll-bars
 'CFLAGS=-g -O2 -fstack-protector-strong -Wformat
 -Werror=format-security -Wall' 'CPPFLAGS=-Wdate-time
 -D_FORTIFY_SOURCE=2' 'LDFLAGS=-Wl,-Bsymbolic-functions -Wl,-z,relro''

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Compilation

Minor modes in effect:
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
Checking /gnu/home/.emacs.d/elpa/emms-6.0...
Checking /gnu/home/.emacs.d/elpa/emms-6.0/doc...
Checking /gnu/home/.emacs.d/elpa/emms-6.0/src...
Done (Total of 48 files compiled, 3 failed, 2 skipped)
Contacting host: elpa.gnu.org:80

scroll-up-command: End of buffer
Mark set
Saved text until "6.0/jack.el at Tue Oct 27 18:43:26 2020
"

Load-path shadows:
/usr/share/emacs/24.5/site-lisp/debian-startup hides /usr/share/emacs/site-lisp/debian-startup
/usr/share/emacs24/site-lisp/mh-e/mh-utils hides /usr/share/emacs/24.5/lisp/mh-e/mh-utils
/usr/share/emacs24/site-lisp/mh-e/mh-letter hides /usr/share/emacs/24.5/lisp/mh-e/mh-letter
/usr/share/emacs24/site-lisp/mh-e/mh-buffers hides /usr/share/emacs/24.5/lisp/mh-e/mh-buffers
/usr/share/emacs24/site-lisp/mh-e/mh-gnus hides /usr/share/emacs/24.5/lisp/mh-e/mh-gnus
/usr/share/emacs24/site-lisp/mh-e/mh-scan hides /usr/share/emacs/24.5/lisp/mh-e/mh-scan
/usr/share/emacs24/site-lisp/mh-e/mh-mime hides /usr/share/emacs/24.5/lisp/mh-e/mh-mime
/usr/share/emacs24/site-lisp/mh-e/mh-limit hides /usr/share/emacs/24.5/lisp/mh-e/mh-limit
/usr/share/emacs24/site-lisp/mh-e/mh-xface hides /usr/share/emacs/24.5/lisp/mh-e/mh-xface
/usr/share/emacs24/site-lisp/mh-e/mh-inc hides /usr/share/emacs/24.5/lisp/mh-e/mh-inc
/usr/share/emacs24/site-lisp/mh-e/mh-comp hides /usr/share/emacs/24.5/lisp/mh-e/mh-comp
/usr/share/emacs24/site-lisp/mh-e/mh-compat hides /usr/share/emacs/24.5/lisp/mh-e/mh-compat
/usr/share/emacs24/site-lisp/mh-e/mh-thread hides /usr/share/emacs/24.5/lisp/mh-e/mh-thread
/usr/share/emacs24/site-lisp/mh-e/mh-e hides /usr/share/emacs/24.5/lisp/mh-e/mh-e
/usr/share/emacs24/site-lisp/mh-e/mh-junk hides /usr/share/emacs/24.5/lisp/mh-e/mh-junk
/usr/share/emacs24/site-lisp/mh-e/mh-alias hides /usr/share/emacs/24.5/lisp/mh-e/mh-alias
/usr/share/emacs24/site-lisp/mh-e/mh-print hides /usr/share/emacs/24.5/lisp/mh-e/mh-print
/usr/share/emacs24/site-lisp/mh-e/mh-folder hides /usr/share/emacs/24.5/lisp/mh-e/mh-folder
/usr/share/emacs24/site-lisp/mh-e/mh-tool-bar hides /usr/share/emacs/24.5/lisp/mh-e/mh-tool-bar
/usr/share/emacs24/site-lisp/mh-e/mh-show hides /usr/share/emacs/24.5/lisp/mh-e/mh-show
/usr/share/emacs24/site-lisp/mh-e/mh-speed hides /usr/share/emacs/24.5/lisp/mh-e/mh-speed
/usr/share/emacs24/site-lisp/mh-e/mh-search hides /usr/share/emacs/24.5/lisp/mh-e/mh-search
/usr/share/emacs24/site-lisp/mh-e/mh-identity hides /usr/share/emacs/24.5/lisp/mh-e/mh-identity
/usr/share/emacs24/site-lisp/mh-e/mh-acros hides /usr/share/emacs/24.5/lisp/mh-e/mh-acros
/usr/share/emacs24/site-lisp/mh-e/mh-funcs hides /usr/share/emacs/24.5/lisp/mh-e/mh-funcs
/usr/share/emacs24/site-lisp/mh-e/mh-seq hides /usr/share/emacs/24.5/lisp/mh-e/mh-seq
/usr/share/emacs24/site-lisp/mh-e/mh-loaddefs hides /usr/share/emacs/24.5/lisp/mh-e/mh-loaddefs

Features:
(shadow mail-extr emacsbug sendmail easy-mmode emms-volume-mixerctl
emms-volume-pulse emms-volume-amixer emms-player-xine emms-player-mpd
emms-lyrics emms-streams emms-show-all emms-tag-editor emms-mark
emms-info-exiftool emms-info-tinytag emms-info-metaflac
emms-info-opusinfo emms-info-ogginfo emms-info-mp3info advice pcase tq
emms-mode-line derived emms-url emms-librefm-scrobbler xml json warnings
sort emms-playlist-sort emms-playlist-mode edmacro kmacro
emms-source-playlist emms-last-played emms-source-file locate dired
emms-cache emms-playing-time emms-player-simple emms-info emms-later-do
emms emms-compat compile comint ansi-color ring info autoload tar-mode
lisp-mnt mule-util mm-archive network-stream starttls url-http tls
url-gw url-cache url-auth url url-proxy url-privacy url-expand
url-methods url-history url-cookie url-domsuf url-util url-handlers
url-parse auth-source eieio byte-opt bytecomp byte-compile cl-extra
cconv eieio-core url-vars epg finder-inf package help-mode mh-mime
mh-gnus mh-show goto-addr thingatpt gnus-cite gnus-art mm-uu mml2015
epg-config mm-view mml-smime smime password-cache dig mailcap gnus-sum
nnoo gnus-group gnus-undo nnmail mail-source gnus-start gnus-spec
gnus-int message format-spec rfc822 mml mml-sec mm-decode mm-bodies
mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums gmm-utils
mailheader gnus-win gnus-range gnus gnus-ems nnheader mail-utils mm-util
help-fns mail-prsvr wid-edit mh-seq mh-inc hl-line mh-tool-bar mh-xface
mh-utils mh-folder which-func imenu easymenu gnus-util mh-scan mh-e
mh-compat mailabbrev mh-acros cl-macs cl gv cl-loaddefs cl-lib
mh-buffers mh-loaddefs xterm time-date mh-cus-load mh-autoloads tooltip
electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment
lisp-mode prog-mode register page menu-bar rfn-eshadow timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese hebrew greek romanian slovak czech european ethiopic
indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple
abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
dbusbind gfilenotify dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs)

Memory information:
((conses 16 275317 21780)
 (symbols 48 31999 0)
 (miscs 40 122 244)
 (strings 32 58876 7247)
 (string-bytes 1 1772514)
 (vectors 16 28121)
 (vector-slots 8 1258289 177791)
 (floats 8 254 431)
 (intervals 56 8483 414)
 (buffers 960 21)
 (heap 1024 25717 1216))


This is the contents of the *Compile-Log* buffer:

Leaving directory `/gnu/home/.emacs.d/elpa/emms-6.0'
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-bookmarks.el at Tue Oct 27 18:43:24 2020
Entering directory `/gnu/home/.emacs.d/elpa/emms-6.0/'
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-browser.el at Tue Oct 27 18:43:24 2020
emms-browser.el:292:1:Error: Cannot open load file: no such file or directory, seq
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-cache.el at Tue Oct 27 18:43:24 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-compat.el at Tue Oct 27 18:43:24 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-cue.el at Tue Oct 27 18:43:24 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-history.el at Tue Oct 27 18:43:24 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-i18n.el at Tue Oct 27 18:43:24 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-info-exiftool.el at Tue Oct 27 18:43:24 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-info-libtag.el at Tue Oct 27 18:43:24 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-info-metaflac.el at Tue Oct 27 18:43:24 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-info-mp3info.el at Tue Oct 27 18:43:24 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-info-ogginfo.el at Tue Oct 27 18:43:24 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-info-opusinfo.el at Tue Oct 27 18:43:24 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-info-tinytag.el at Tue Oct 27 18:43:24 2020

In end of data:
emms-info-tinytag.el:120:1:Warning: the function `alist-get' is not known to
    be defined.
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-info.el at Tue Oct 27 18:43:24 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-last-played.el at Tue Oct 27 18:43:24 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-later-do.el at Tue Oct 27 18:43:24 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-librefm-scrobbler.el at Tue Oct 27 18:43:24 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-librefm-stream.el at Tue Oct 27 18:43:24 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-lyrics.el at Tue Oct 27 18:43:24 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-maint.el at Tue Oct 27 18:43:24 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-mark.el at Tue Oct 27 18:43:24 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-metaplaylist-mode.el at Tue Oct 27 18:43:24 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-mode-line-icon.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-mode-line.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-player-mpd.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-player-mpg321-remote.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-player-mplayer.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-player-mpv.el at Tue Oct 27 18:43:25 2020

In end of data:
emms-player-mpv.el:848:1:Warning: the following functions are not known to be defined: seq-map,
    string>, seq-some, seq-filter, make-process, alist-get
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-player-simple.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-player-vlc.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-player-xine.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-playing-time.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-playlist-limit.el at Tue Oct 27 18:43:25 2020
emms-playlist-limit.el:57:1:Error: Cannot open load file: no such file or directory, seq
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-playlist-mode.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-playlist-sort.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-score.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-setup.el at Tue Oct 27 18:43:25 2020
emms-setup.el:100:15:Error: Cannot open load file: no such file or directory, seq
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-show-all.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-source-file.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-source-playlist.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-stream-info.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-streams.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-tag-editor.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-url.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-volume-amixer.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-volume-mixerctl.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-volume-pulse.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-volume.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms.el at Tue Oct 27 18:43:25 2020
\f
Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/jack.el at Tue Oct 27 18:43:26 2020





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#44270: 24.5; EMMA failures while installing
  2020-10-28  1:50 bug#44270: 24.5; EMMA failures while installing John Gilmore
@ 2020-10-28 11:31 ` Lars Ingebrigtsen
  2020-11-04 15:49   ` bug#44270: 24.5; EMMS " Stefan Kangas
  0 siblings, 1 reply; 7+ messages in thread
From: Lars Ingebrigtsen @ 2020-10-28 11:31 UTC (permalink / raw)
  To: John Gilmore; +Cc: 44270

John Gilmore <gnu@toad.com> writes:

> M-x list-packages
> picked emms, hit Install.
> I've included the *Compile-Log* buffer contents, which include one
> error and several warnings.
> Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-browser.el at Tue Oct 27 18:43:24 2020
> emms-browser.el:292:1:Error: Cannot open load file: no such file or directory, seq

It seems like EMMS requires seq, but that it's not installed in your
Emacs?  My guess is that your Emacs (24.5) is too old to use EMMS.

But EMMS should specify that, I guess?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#44270: 24.5; EMMS failures while installing
  2020-10-28 11:31 ` Lars Ingebrigtsen
@ 2020-11-04 15:49   ` Stefan Kangas
  2020-11-05  2:38     ` Yoni Rabkin
  0 siblings, 1 reply; 7+ messages in thread
From: Stefan Kangas @ 2020-11-04 15:49 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 44270, John Gilmore, Yoni Rabkin

Lars Ingebrigtsen <larsi@gnus.org> writes:

> John Gilmore <gnu@toad.com> writes:
>
>> M-x list-packages
>> picked emms, hit Install.
>> I've included the *Compile-Log* buffer contents, which include one
>> error and several warnings.
>> Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-browser.el at Tue Oct 27 18:43:24 2020
>> emms-browser.el:292:1:Error: Cannot open load file: no such file or directory, seq
>
> It seems like EMMS requires seq, but that it's not installed in your
> Emacs?  My guess is that your Emacs (24.5) is too old to use EMMS.
>
> But EMMS should specify that, I guess?

Indeed, I think EMMS should add a dependency on seq:

    ;; Package-Requires: ((cl-lib "0.5") (seq "2.22"))

Perhaps it should add a dependency also on Emacs, but I don't know which
version it would need.

Yoni, could you please take a look at this?  This might warrant
releasing a new version of the package on GNU ELPA.





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#44270: 24.5; EMMS failures while installing
  2020-11-04 15:49   ` bug#44270: 24.5; EMMS " Stefan Kangas
@ 2020-11-05  2:38     ` Yoni Rabkin
  2020-11-05  7:25       ` Stefan Kangas
  0 siblings, 1 reply; 7+ messages in thread
From: Yoni Rabkin @ 2020-11-05  2:38 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: Lars Ingebrigtsen, 44270, John Gilmore, Yoni Rabkin

Stefan Kangas <stefan@marxist.se> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> John Gilmore <gnu@toad.com> writes:
>>
>>> M-x list-packages
>>> picked emms, hit Install.
>>> I've included the *Compile-Log* buffer contents, which include one
>>> error and several warnings.
>>> Compiling file /gnu/home/.emacs.d/elpa/emms-6.0/emms-browser.el at Tue Oct 27 18:43:24 2020
>>> emms-browser.el:292:1:Error: Cannot open load file: no such file or directory, seq
>>
>> It seems like EMMS requires seq, but that it's not installed in your
>> Emacs?  My guess is that your Emacs (24.5) is too old to use EMMS.
>>
>> But EMMS should specify that, I guess?
>
> Indeed, I think EMMS should add a dependency on seq:
>
>     ;; Package-Requires: ((cl-lib "0.5") (seq "2.22"))
>
> Perhaps it should add a dependency also on Emacs, but I don't know which
> version it would need.
>
> Yoni, could you please take a look at this?  This might warrant
> releasing a new version of the package on GNU ELPA.
>

The code which requires seq (in emms-browser.el) was added in 2017
(contemporaneous with Emacs 25.2), but of course Emacs 24.5 dates back
from 2015.

I'll see if it possible to re-write that code without seq and therefore
to regain that backward compatibility. If so, it will take a good while
before it is done.

Should I add a dependency on a particular version of Emacs in the
meantime?

-- 
   "Cut your own wood and it will warm you twice"





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#44270: 24.5; EMMS failures while installing
  2020-11-05  2:38     ` Yoni Rabkin
@ 2020-11-05  7:25       ` Stefan Kangas
  2020-11-05 13:35         ` Yoni Rabkin
  0 siblings, 1 reply; 7+ messages in thread
From: Stefan Kangas @ 2020-11-05  7:25 UTC (permalink / raw)
  To: Yoni Rabkin; +Cc: Lars Ingebrigtsen, 44270, John Gilmore, Yoni Rabkin

Yoni Rabkin <yoni@rabkins.net> writes:

>> Indeed, I think EMMS should add a dependency on seq:
>>
>>     ;; Package-Requires: ((cl-lib "0.5") (seq "2.22"))
>
> The code which requires seq (in emms-browser.el) was added in 2017
> (contemporaneous with Emacs 25.2), but of course Emacs 24.5 dates back
> from 2015.
>
> Should I add a dependency on a particular version of Emacs in the
> meantime?

I think it's better if you add a dependency on seq actually.  The
package system should automatically install it on old versions, and the
GNU ELPA package has compatibility code that makes it work with Emacs
version 24.x.

> I'll see if it possible to re-write that code without seq and therefore
> to regain that backward compatibility.

Unless you want Emacs 23 compatibility, I don't think it is strictly
necessary to get rid of the seq dependency.





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#44270: 24.5; EMMS failures while installing
  2020-11-05  7:25       ` Stefan Kangas
@ 2020-11-05 13:35         ` Yoni Rabkin
  2020-11-05 13:58           ` Stefan Kangas
  0 siblings, 1 reply; 7+ messages in thread
From: Yoni Rabkin @ 2020-11-05 13:35 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: Lars Ingebrigtsen, 44270, John Gilmore, Yoni Rabkin

Stefan Kangas <stefan@marxist.se> writes:

> Yoni Rabkin <yoni@rabkins.net> writes:
>
>>> Indeed, I think EMMS should add a dependency on seq:
>>>
>>>     ;; Package-Requires: ((cl-lib "0.5") (seq "2.22"))
>>
>> The code which requires seq (in emms-browser.el) was added in 2017
>> (contemporaneous with Emacs 25.2), but of course Emacs 24.5 dates back
>> from 2015.
>>
>> Should I add a dependency on a particular version of Emacs in the
>> meantime?
>
> I think it's better if you add a dependency on seq actually.  The
> package system should automatically install it on old versions, and the
> GNU ELPA package has compatibility code that makes it work with Emacs
> version 24.x.

I've added seq as a requirement, bumped the version number, and pushed
to elpa.git.

-- 
   "Cut your own wood and it will warm you twice"





^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#44270: 24.5; EMMS failures while installing
  2020-11-05 13:35         ` Yoni Rabkin
@ 2020-11-05 13:58           ` Stefan Kangas
  0 siblings, 0 replies; 7+ messages in thread
From: Stefan Kangas @ 2020-11-05 13:58 UTC (permalink / raw)
  To: Yoni Rabkin; +Cc: Lars Ingebrigtsen, 44270-done, John Gilmore, Yoni Rabkin

Yoni Rabkin <yoni@rabkins.net> writes:

> I've added seq as a requirement, bumped the version number, and pushed
> to elpa.git.

Thanks!

Looks good to me.  I'm therefore closing this bug report now.

The EMMS commit can be seen here:
https://git.savannah.gnu.org/cgit/emacs/elpa.git/commit/?h=externals/emms&id=87059ff05739

If anyone is still having issues, please reply to this email (use "Reply
to all" in your email client) and we can reopen the bug report.





^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-11-05 13:58 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-28  1:50 bug#44270: 24.5; EMMA failures while installing John Gilmore
2020-10-28 11:31 ` Lars Ingebrigtsen
2020-11-04 15:49   ` bug#44270: 24.5; EMMS " Stefan Kangas
2020-11-05  2:38     ` Yoni Rabkin
2020-11-05  7:25       ` Stefan Kangas
2020-11-05 13:35         ` Yoni Rabkin
2020-11-05 13:58           ` Stefan Kangas

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).