From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Eli Zaretskii <eliz@gnu.org>
Cc: joaotavora@gmail.com, 44629@debbugs.gnu.org
Subject: bug#44629: 28.0.50; Eglot noisy with gfm-view-mode and view-read-only
Date: Sat, 14 Nov 2020 12:26:28 +0000 [thread overview]
Message-ID: <87ft5cunt7.fsf@tcd.ie> (raw)
In-Reply-To: <838sb4w3i7.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Nov 2020 14:02:08 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: "Basil L. Contovounesios" <contovob@tcd.ie>
>> Date: Sat, 14 Nov 2020 11:15:48 +0000
>> Cc: João Távora <joaotavora@gmail.com>
>>
>> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>>
>> > Perhaps Eglot could/should bind view-inhibit-help-message around
>> > gfm-view-mode? Any other ideas?
>>
>> I tried advising eglot--format-markup to bind view-inhibit-help-message,
>> which gets rid of the most annoying messages, but some still seem to
>> emanate from jsonrpc, which calls read-only-mode in
>> jsonrpc-events-buffer and initialize-instance. I'd rather not have to
>> rely on advising internal functions, but maybe I can't have my cake and
>> eat it, too. ;)
>
> Can what you want be achieved by setting set-message-function to
> something suitable?
I don't have a preference for one or the other approach, but I'm not
sure how that would be much different to binding
view-inhibit-help-message. The problem in both cases is that eglot and
jsonrpc internally make calls, either directly or indirectly, to
read-only-mode, which can be noisy.
I'd like read-only-mode to remain noisy (via view-read-only) in all
other cases, if possible, such as when visiting a read-only file. How
can the use of set-message-function distinguish between calls to
read-only-mode from internal Eglot plumbing, vs those from
e.g. find-file?
The only clean approaches off the top of my head are:
a) inhibit these messages in one way or another around calls to
gfm-view-mode/read-only-mode in eglot/jsonrpc;
b) disable view-read-only and/or enable view-inhibit-help-message
in my configuration.
--
Basil
next prev parent reply other threads:[~2020-11-14 12:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 10:58 bug#44629: 28.0.50; Eglot noisy with gfm-view-mode and view-read-only Basil L. Contovounesios
2020-11-14 11:15 ` Basil L. Contovounesios
2020-11-14 12:02 ` Eli Zaretskii
2020-11-14 12:26 ` Basil L. Contovounesios [this message]
2020-11-14 14:46 ` Eli Zaretskii
2020-11-14 15:13 ` João Távora
2020-11-15 20:27 ` Juri Linkov
2020-11-15 21:52 ` Basil L. Contovounesios
2020-11-15 23:14 ` João Távora
2020-11-17 20:15 ` Basil L. Contovounesios
2020-11-17 20:21 ` Basil L. Contovounesios
2020-11-17 22:55 ` João Távora
2020-11-28 21:27 ` Basil L. Contovounesios
2020-11-29 10:36 ` Lars Ingebrigtsen
2020-12-03 15:26 ` Basil L. Contovounesios
2020-11-16 9:14 ` Juri Linkov
2020-11-14 13:47 ` João Távora
2020-11-14 17:13 ` Basil L. Contovounesios
2020-11-15 9:55 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ft5cunt7.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=44629@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).