From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#44629: 28.0.50; Eglot noisy with gfm-view-mode and view-read-only Date: Sat, 14 Nov 2020 12:26:28 +0000 Message-ID: <87ft5cunt7.fsf@tcd.ie> References: <875z68p5mr.fsf@tcd.ie> <87v9e8i3yz.fsf@tcd.ie> <838sb4w3i7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5540"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: joaotavora@gmail.com, 44629@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 14 13:27:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kdue6-0001L0-Of for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Nov 2020 13:27:10 +0100 Original-Received: from localhost ([::1]:43786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdue5-0005vn-8n for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Nov 2020 07:27:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdudy-0005vd-76 for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2020 07:27:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38434) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kdudx-0006LR-Rc for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2020 07:27:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kdudx-0000yd-NA for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2020 07:27:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Nov 2020 12:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44629 X-GNU-PR-Package: emacs Original-Received: via spool by 44629-submit@debbugs.gnu.org id=B44629.16053567993725 (code B ref 44629); Sat, 14 Nov 2020 12:27:01 +0000 Original-Received: (at 44629) by debbugs.gnu.org; 14 Nov 2020 12:26:39 +0000 Original-Received: from localhost ([127.0.0.1]:49980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kduda-0000y1-SN for submit@debbugs.gnu.org; Sat, 14 Nov 2020 07:26:39 -0500 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:34969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdudY-0000xo-OA for 44629@debbugs.gnu.org; Sat, 14 Nov 2020 07:26:37 -0500 Original-Received: by mail-wm1-f51.google.com with SMTP id w24so18346878wmi.0 for <44629@debbugs.gnu.org>; Sat, 14 Nov 2020 04:26:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=alPV1KhhPWZw5MIJV4Lbh/w4EKW/W6YLfrzX8Xd76MU=; b=FmQ5CfzPo2/84SjkHm/U6X6fCEWloUHT1zdzZJmWure2aq6pc+0TWGrfsQUfyMq6ZS fe+GjKLcZD/MmUXgyHguawq4w9Ic/Mz6v6wJBdgUlZo1YUfhFWYaGrjOnEepUCXzYnZL F7/m35NLKbSRpeWQ6lsTB7V7PXyVc2x+XS7qc+xNOcQrUd2vtqI3BHpfm1af5eJHSkb6 0SWywkHVjSVpkxR8ikgHfRUIGgOWc2Ktg2b8yDJhQZej0qnIbS/e2z3NtrKZOeMxfoTP nGAj4ZC7gQn3oJCYWYQRbFGJITG+gHsOkR50ZTeCNBEFJlMsvGSCEOczuzY+kAxAEHYt xKag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=alPV1KhhPWZw5MIJV4Lbh/w4EKW/W6YLfrzX8Xd76MU=; b=NXFnst5ZLJYbse+OttePNGhyRLMwGcZuuhb0eP1mOLktEiH6Yu/Ar3NXSQYkOdole/ En/5GblH7b8qSUuee3S87hhPOW+u1EmyJhZw7D5hicy3SS0Smvjq8Z0fSMrgIb5qkstr nScbtr9DvtYbPUsq+HyrDBsWgwuDhkjMPySB0n9zoKaU76+4XvEzFr3kU9oZtzBYjJn8 ViX3fTSyI0a3njzebP/+7ytyOCXWUyV49nWj9xrZIlO3W6/d6mJM9LEgHNyLLSV1QWPW 44MTOpeODl4Y8XPU3nsRbLcbdHX6Ldqyd1xHzzMYUk1ciNXhyZJqsa/9CdztkGcKeOI1 og+w== X-Gm-Message-State: AOAM533csqriC1wWYa3yigGhFdB8uQD+ZCovC7/ch25V3LsFDqEYT8n9 zYVL79YpykifJIWwPLfGCRLXsw== X-Google-Smtp-Source: ABdhPJzGLNVL822R+BqYHw4xcYGOJIViOcbM+AVyex9ZdXtgMMJCj/g16xQyolQlrrtVGo6K2M3sJw== X-Received: by 2002:a1c:3803:: with SMTP id f3mr6661094wma.14.1605356790742; Sat, 14 Nov 2020 04:26:30 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:fef1:a98a:87ca:e0e6]) by smtp.gmail.com with ESMTPSA id e5sm13381800wrs.84.2020.11.14.04.26.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Nov 2020 04:26:30 -0800 (PST) In-Reply-To: <838sb4w3i7.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Nov 2020 14:02:08 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193269 Archived-At: Eli Zaretskii writes: >> From: "Basil L. Contovounesios" >> Date: Sat, 14 Nov 2020 11:15:48 +0000 >> Cc: Jo=C3=A3o T=C3=A1vora >>=20 >> "Basil L. Contovounesios" writes: >>=20 >> > Perhaps Eglot could/should bind view-inhibit-help-message around >> > gfm-view-mode? Any other ideas? >>=20 >> I tried advising eglot--format-markup to bind view-inhibit-help-message, >> which gets rid of the most annoying messages, but some still seem to >> emanate from jsonrpc, which calls read-only-mode in >> jsonrpc-events-buffer and initialize-instance. I'd rather not have to >> rely on advising internal functions, but maybe I can't have my cake and >> eat it, too. ;) > > Can what you want be achieved by setting set-message-function to > something suitable? I don't have a preference for one or the other approach, but I'm not sure how that would be much different to binding view-inhibit-help-message. The problem in both cases is that eglot and jsonrpc internally make calls, either directly or indirectly, to read-only-mode, which can be noisy. I'd like read-only-mode to remain noisy (via view-read-only) in all other cases, if possible, such as when visiting a read-only file. How can the use of set-message-function distinguish between calls to read-only-mode from internal Eglot plumbing, vs those from e.g. find-file? The only clean approaches off the top of my head are: a) inhibit these messages in one way or another around calls to gfm-view-mode/read-only-mode in eglot/jsonrpc; b) disable view-read-only and/or enable view-inhibit-help-message in my configuration. --=20 Basil