unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Sharaf Zaman <shzam@sdf.org>
Cc: 51355@debbugs.gnu.org, 51354@debbugs.gnu.org,
	Yuuki Harano <masm+github@masm11.me>
Subject: bug#51354: [PATCH] Fix a memory leak in pgtk_draw_fringe_bitmap
Date: Sun, 24 Oct 2021 20:09:17 +0200	[thread overview]
Message-ID: <87fssq5m7m.fsf_-_@gnus.org> (raw)
In-Reply-To: <87wnm3da0j.fsf@sdf.org> (Sharaf Zaman's message of "Sat, 23 Oct 2021 15:41:00 +0000")

Sharaf Zaman <shzam@sdf.org> writes:

> I discovered that there's a memory leak in the pgtk code, if the windows are
> created/destroyed/moved/shrunk/widened frequently. I've verified it with
> profiler that this indeed is the location (https://i.imgur.com/LnrgGyj.png) and
> fixed it (https://i.imgur.com/zdgnn5K.png).

Makes sense to me, so I've applied it to the pgtk branch, but perhaps
Yuuki has a comment (added to the CCs).

> PS: This is my first time sending a patch over an email, I'm not 100%
> sure if this is how it's done.

Looked perfect.  :-)

This change was small enough to apply without assigning copyright to the
FSF, but for future patches you want to submit, it might make sense to
get the paperwork started now, so that subsequent patches can be applied
speedily. Would you be willing to sign such paperwork?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2021-10-24 18:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-23 14:34 bug#51354: [PATCH] Fix a memory leak in pgtk_draw_fringe_bitmap Sharaf Zaman
     [not found] ` <87zgqzda7w.fsf@sdf.org>
2021-10-23 15:41   ` bug#51355: Fwd: " Sharaf Zaman
2021-10-24 18:09     ` Lars Ingebrigtsen [this message]
     [not found]       ` <874k95txyd.fsf@sdf.org>
2021-10-25 13:35         ` bug#51355: bug#51354: " Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fssq5m7m.fsf_-_@gnus.org \
    --to=larsi@gnus.org \
    --cc=51354@debbugs.gnu.org \
    --cc=51355@debbugs.gnu.org \
    --cc=masm+github@masm11.me \
    --cc=shzam@sdf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).