From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#51354: [PATCH] Fix a memory leak in pgtk_draw_fringe_bitmap Date: Sun, 24 Oct 2021 20:09:17 +0200 Message-ID: <87fssq5m7m.fsf_-_@gnus.org> References: <87pmrvbyif.fsf@sdf.org> <87zgqzda7w.fsf@sdf.org> <87wnm3da0j.fsf@sdf.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2566"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51355@debbugs.gnu.org, 51354@debbugs.gnu.org, Yuuki Harano To: Sharaf Zaman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 24 20:11:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mehxl-0000Us-Ag for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Oct 2021 20:11:17 +0200 Original-Received: from localhost ([::1]:57390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mehxj-0006Vq-PH for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Oct 2021 14:11:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mehwZ-0006TV-1M for bug-gnu-emacs@gnu.org; Sun, 24 Oct 2021 14:10:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57471) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mehwY-0001Lx-OF for bug-gnu-emacs@gnu.org; Sun, 24 Oct 2021 14:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mehwY-0006It-Gi for bug-gnu-emacs@gnu.org; Sun, 24 Oct 2021 14:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Oct 2021 18:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51354 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51354-submit@debbugs.gnu.org id=B51354.163509897024170 (code B ref 51354); Sun, 24 Oct 2021 18:10:02 +0000 Original-Received: (at 51354) by debbugs.gnu.org; 24 Oct 2021 18:09:30 +0000 Original-Received: from localhost ([127.0.0.1]:40779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mehw1-0006Hl-Lp for submit@debbugs.gnu.org; Sun, 24 Oct 2021 14:09:29 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:46716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mehvz-0006HR-Vy; Sun, 24 Oct 2021 14:09:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TZLfxUT07vmn3reFl2vg/fUdH8LHpu8NHYZ0NEc4Shw=; b=T8X27o+5Ks7npf45XCE0PhZ4up LP7rGxMu9UYQP0ppAbTVyc5OcrpUjKvlQjg0+BQGPq4WM58WWtKvNHTkkwQJwpp1CK5wczgsWnmpL weJT6Acy8Y8Uwj+0Hsx1M4RhJLAGQykzwdJEQwnC6nbxSJTYcKJVL36raPkiQALzTosk=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mehvq-0001Ch-8D; Sun, 24 Oct 2021 20:09:20 +0200 In-Reply-To: <87wnm3da0j.fsf@sdf.org> (Sharaf Zaman's message of "Sat, 23 Oct 2021 15:41:00 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218165 Archived-At: Sharaf Zaman writes: > I discovered that there's a memory leak in the pgtk code, if the windows are > created/destroyed/moved/shrunk/widened frequently. I've verified it with > profiler that this indeed is the location (https://i.imgur.com/LnrgGyj.png) and > fixed it (https://i.imgur.com/zdgnn5K.png). Makes sense to me, so I've applied it to the pgtk branch, but perhaps Yuuki has a comment (added to the CCs). > PS: This is my first time sending a patch over an email, I'm not 100% > sure if this is how it's done. Looked perfect. :-) This change was small enough to apply without assigning copyright to the FSF, but for future patches you want to submit, it might make sense to get the paperwork started now, so that subsequent patches can be applied speedily. Would you be willing to sign such paperwork? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no