unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 51702@debbugs.gnu.org
Subject: bug#51702: 29.0.50; [PATCH] Fix xwidget buffer name being stuck on something nonsensical
Date: Tue, 09 Nov 2021 20:58:10 +0800	[thread overview]
Message-ID: <87fss57afx.fsf@yahoo.com> (raw)
In-Reply-To: <83k0hh5w8k.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 Nov 2021 14:50:19 +0200")

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> You've lost the period in the comment there.

Thanks for this catch.

>And the sentence after that should be capitalized, of course.

Thanks.  I was trying to keep the style of the original comment intact,
but now that you've brought it up I see no harm in changing it.

Please see the attached change.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-comment-capitalization-in-xwidget.el.patch --]
[-- Type: text/x-patch, Size: 1135 bytes --]

From c569e2419886f30940032745da76e99342d0a5d8 Mon Sep 17 00:00:00 2001
From: Po Lu <luangruo@yahoo.com>
Date: Tue, 9 Nov 2021 20:57:19 +0800
Subject: [PATCH] Fix comment capitalization in xwidget.el

* lisp/xwidget.el (xwidget-webkit-callback): Rectify comment.
---
 lisp/xwidget.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/xwidget.el b/lisp/xwidget.el
index 905327083b..28add0db0a 100644
--- a/lisp/xwidget.el
+++ b/lisp/xwidget.el
@@ -360,8 +360,8 @@ xwidget-webkit-callback
     (cond ((eq xwidget-event-type 'load-changed)
            (let ((title (xwidget-webkit-title xwidget)))
              ;; This funciton will be called multi times, so only
-             ;; change buffer name when the load actually completes
-             ;; this can limit buffer-name flicker in mode-line.
+             ;; change buffer name when the load actually completes.
+             ;; This can limit buffer-name flicker in mode-line.
              (when (or (string-equal (nth 3 last-input-event)
                                      "load-finished")
                        (> (length title) 0))
-- 
2.31.1


  reply	other threads:[~2021-11-09 12:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87k0hhal3v.fsf.ref@yahoo.com>
2021-11-09  6:39 ` bug#51702: 29.0.50; [PATCH] Fix xwidget buffer name being stuck on something nonsensical Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-09  6:46   ` Lars Ingebrigtsen
2021-11-09  6:54     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-09 12:50   ` Eli Zaretskii
2021-11-09 12:58     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-11-09 13:35       ` Eli Zaretskii
2021-11-09 13:51         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-09 17:33       ` Benjamin Riefenstahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fss57afx.fsf@yahoo.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=51702@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).