From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51702: 29.0.50; [PATCH] Fix xwidget buffer name being stuck on something nonsensical Date: Tue, 09 Nov 2021 20:58:10 +0800 Message-ID: <87fss57afx.fsf@yahoo.com> References: <87k0hhal3v.fsf.ref@yahoo.com> <87k0hhal3v.fsf@yahoo.com> <83k0hh5w8k.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11180"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: 51702@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 09 13:59:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkQif-0002he-6Q for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Nov 2021 13:59:21 +0100 Original-Received: from localhost ([::1]:37494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mkQid-0004k5-Nj for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Nov 2021 07:59:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48868) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mkQiM-0004iG-1Y for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 07:59:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49591) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mkQiL-00015U-Pg for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 07:59:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mkQiL-0007Hs-P8 for bug-gnu-emacs@gnu.org; Tue, 09 Nov 2021 07:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Nov 2021 12:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51702 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51702-submit@debbugs.gnu.org id=B51702.163646270827961 (code B ref 51702); Tue, 09 Nov 2021 12:59:01 +0000 Original-Received: (at 51702) by debbugs.gnu.org; 9 Nov 2021 12:58:28 +0000 Original-Received: from localhost ([127.0.0.1]:32904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkQho-0007Gu-5m for submit@debbugs.gnu.org; Tue, 09 Nov 2021 07:58:28 -0500 Original-Received: from sonic307-56.consmr.mail.ne1.yahoo.com ([66.163.190.31]:45629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mkQhk-0007Gg-Vx for 51702@debbugs.gnu.org; Tue, 09 Nov 2021 07:58:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636462699; bh=jwYPQ6d7ZVHsv35ywQieXI7InM+ZXbiY0zjAd//BQv8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=lUMl228bt3fBhQB4Cu8QtV67l868LN2a55abMAlzqoYbKqKHZ0Gqx9dJMY8hsFgChb7rIBMLecPFQvk1rWf3tY4Nwk5PCX+7UgnLMRSYZZq7hyiYl5+CDelzUCU/piU1oBgENf3QY7hOb8b6gv4OG5ONeKmD/fp8FKG6bCy7BBHtMBrjCadRUdBhgQSedRE1QzUMIPGEAztLgStDsKdrjj21HswmZy5heQ2pBinnAB/4NWcAYQ4TtR/9Ats20SrFujyMuWAzMM74KdhRMqiQ7fgCfIYOradmfwq8kj3xEiQZgw1DwDvG0hLTB8pFi0dp/3VhOJ5muMvFN18kvpdqSQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636462699; bh=bAntfszUWJhQktPbitw+oUgP8P3i5OA8lNnk6UAJESI=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=W9UV6lqVq3bvZ6nGA9Km5mZ8pDNwd62Ko4UXP2MckKl+Uuu+9sEmhv5YLKGBCvw/dKKoYc+7v1DoRS7WBaYQIA4uLFtWX+5FuRb2zSarllpwAROnVhPIkd50ZZsx8UA3zFv67oXDLSec87st1ASaxXyvixouOZvdvwYYJ3SMZewv110pauWWpIKHVDDhR6nacOJZkxIkrjDai2LzMWbBXj/ZS8sPe44jdxJ/sg2LGYSD+YkucGV+0esEWvajAZbVL+yhAHE4awd2+4OcxCWiWpDu1+zYpWqDL0WV7bpNr5mP2Sy7HpWVMgk3EwF+SiGuWDtaPVyrTDd16Z9oC4wFoQ== X-YMail-OSG: HTqFrxQVM1kq0ARp.nkzyGwMgNXwt3u7Y1U3_.EFsG1o0v3sgNRtUBx7w7zionl 38Xy3KsQIh5Gy2fVSj4MRoTVy.l4WpXBV3g3bkiIdJI6kObmJBL4a6No63BPkqO6nirXkdOI_LmE FrKERI83fki6lZevsMVRJo.zJi1JKAEnmDnxVxYgIFKanZkIvKAK0VkmRWBh1o6Vwl0830JJ9082 SCFygU.Uip306AuO9pw6HEAe5YawErfKW.pVL._DqnURglHOl8xgzfSjVvrr7WTeQ5ZOFl8zLr20 9wghOGECFAOjRw0XKRBKCxHZvmJaYzDZm5phVAXE0Y3yPpb9zOn2ae0Y3OuQ14nx1pMFv.lm1ZaE dZaXxtyCjuO6Zgni5nDjfK5NtfURFWCtSTnFnpx4FAV6j6XutsVTzYs904SQvefmeeo97f_804fj t4m8XE8LoY_uSHvzcDaYyMtYv2QOFG3jDAgIS52EDY9ENMQnkD6txj7WSef2DmqcMp7_6.jYHpyd bfBJoRB0voiYo2TSzOkmEgagjjkPKKndBNiz_o2deAi7LX4RP2wJ9LuSfHOzHo.WcmSsP002vduO 0KOPgbB.w6PeOYNFHzLmoFROpPlRoos9RGCwZv83XA810lAfp0RxtZhCaANF9JJQP1FYIoG5dbnV RGx4U33Escy6Ree2INISRjUGKP5d2nrn5wSawAKfadcpC9A1t1tyhWHNScncf5betwgzATC3sbfl lt5H1qYrnAEIncTb7yZ0.PnYKu599JFlGiJ8gz.JyTqystqSuooe9lUFtPv.glxahcDivZ7P_oYN ELwrwe7cob6qMJ0uv1C2sxNqP_X5UDLaSvpDSbDFFY X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Tue, 9 Nov 2021 12:58:19 +0000 Original-Received: by kubenode507.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID d19397c8f3c331f109777a3d70b98ae0; Tue, 09 Nov 2021 12:58:13 +0000 (UTC) In-Reply-To: <83k0hh5w8k.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 Nov 2021 14:50:19 +0200") X-Mailer: WebService/1.1.19266 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219444 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: > You've lost the period in the comment there. Thanks for this catch. >And the sentence after that should be capitalized, of course. Thanks. I was trying to keep the style of the original comment intact, but now that you've brought it up I see no harm in changing it. Please see the attached change. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-comment-capitalization-in-xwidget.el.patch >From c569e2419886f30940032745da76e99342d0a5d8 Mon Sep 17 00:00:00 2001 From: Po Lu Date: Tue, 9 Nov 2021 20:57:19 +0800 Subject: [PATCH] Fix comment capitalization in xwidget.el * lisp/xwidget.el (xwidget-webkit-callback): Rectify comment. --- lisp/xwidget.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/xwidget.el b/lisp/xwidget.el index 905327083b..28add0db0a 100644 --- a/lisp/xwidget.el +++ b/lisp/xwidget.el @@ -360,8 +360,8 @@ xwidget-webkit-callback (cond ((eq xwidget-event-type 'load-changed) (let ((title (xwidget-webkit-title xwidget))) ;; This funciton will be called multi times, so only - ;; change buffer name when the load actually completes - ;; this can limit buffer-name flicker in mode-line. + ;; change buffer name when the load actually completes. + ;; This can limit buffer-name flicker in mode-line. (when (or (string-equal (nth 3 last-input-event) "load-finished") (> (length title) 0)) -- 2.31.1 --=-=-=--