From: Lars Ingebrigtsen <larsi@gnus.org>
To: Koen van Greevenbroek <koen_devel@posteo.net>
Cc: 52260@debbugs.gnu.org
Subject: bug#52260: Fix compilation error in feature/pgtk branch
Date: Fri, 03 Dec 2021 18:12:48 +0100 [thread overview]
Message-ID: <87fsr9vchb.fsf@gnus.org> (raw)
In-Reply-To: <1656047e6c87e052a7bbc7010410de4d7b500246.camel@posteo.net> (Koen van Greevenbroek's message of "Fri, 03 Dec 2021 09:20:53 +0000")
Koen van Greevenbroek <koen_devel@posteo.net> writes:
> I was just trying to compile the latest version of the pgtk branch when
> I noticed that commit 901938109f introduced a regression: two empty
> switch cases will result in a compilation error. My suggested fix is
> the following:
>
> Fix compilation error due to empty switch cases
>
> modified src/pgtkterm.c
> @@ -4276,6 +4276,7 @@ set_fullscreen_state (struct frame *f)
>
> case FULLSCREEN_WIDTH:
> case FULLSCREEN_HEIGHT:
> + ;
> /* Not supported by gtk. Ignore them. */
> }
>
> This fixes the compilation error for me; I don't know if there is a
> more idiomatic way of solving this.
I think adding a "break;" is the normal way to do it, so I've now done
this on the pgtk branch.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2021-12-03 17:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 9:20 bug#52260: Fix compilation error in feature/pgtk branch Koen van Greevenbroek
2021-12-03 17:12 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsr9vchb.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=52260@debbugs.gnu.org \
--cc=koen_devel@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).