From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#52260: Fix compilation error in feature/pgtk branch Date: Fri, 03 Dec 2021 18:12:48 +0100 Message-ID: <87fsr9vchb.fsf@gnus.org> References: <1656047e6c87e052a7bbc7010410de4d7b500246.camel@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32855"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 52260@debbugs.gnu.org To: Koen van Greevenbroek Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 03 18:13:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtC7V-0008MW-JU for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Dec 2021 18:13:13 +0100 Original-Received: from localhost ([::1]:55082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mtC7U-0007fP-NO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Dec 2021 12:13:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtC7L-0007f2-Eb for bug-gnu-emacs@gnu.org; Fri, 03 Dec 2021 12:13:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40597) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mtC7K-0006wB-HX for bug-gnu-emacs@gnu.org; Fri, 03 Dec 2021 12:13:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mtC7K-0001cI-D4 for bug-gnu-emacs@gnu.org; Fri, 03 Dec 2021 12:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Dec 2021 17:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52260 X-GNU-PR-Package: emacs Original-Received: via spool by 52260-submit@debbugs.gnu.org id=B52260.16385515806198 (code B ref 52260); Fri, 03 Dec 2021 17:13:02 +0000 Original-Received: (at 52260) by debbugs.gnu.org; 3 Dec 2021 17:13:00 +0000 Original-Received: from localhost ([127.0.0.1]:52140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtC7H-0001bu-WC for submit@debbugs.gnu.org; Fri, 03 Dec 2021 12:13:00 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:54590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtC7E-0001be-To for 52260@debbugs.gnu.org; Fri, 03 Dec 2021 12:12:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=k+2K2Xl/ioMouBCENW5rHGZwLKL4fLyCfwcOZdvmaIE=; b=KOJeibbtRlPdS+n6533/gefxFK X0K579yDB1rFXeM/k/spXN7LLrkAHxMOI1b7N1AJZsjiou1PXc0MVyn54W/hBUThllGRVl2lbbPWU +H5PfIcpIDE0Bjw3e2EzzJ+SZimzY4Fxr+D9nJ4yT8Q4YJH4aNSPxxaxldYXao7UqWJw=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtC76-0004oz-J6; Fri, 03 Dec 2021 18:12:51 +0100 X-Now-Playing: Joni Mitchell's _Dog Eat Dog_: "The Three Great Stimulants" In-Reply-To: <1656047e6c87e052a7bbc7010410de4d7b500246.camel@posteo.net> (Koen van Greevenbroek's message of "Fri, 03 Dec 2021 09:20:53 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221403 Archived-At: Koen van Greevenbroek writes: > I was just trying to compile the latest version of the pgtk branch when > I noticed that commit 901938109f introduced a regression: two empty > switch cases will result in a compilation error. My suggested fix is > the following: > > Fix compilation error due to empty switch cases > > modified src/pgtkterm.c > @@ -4276,6 +4276,7 @@ set_fullscreen_state (struct frame *f) > > case FULLSCREEN_WIDTH: > case FULLSCREEN_HEIGHT: > + ; > /* Not supported by gtk. Ignore them. */ > } > > This fixes the compilation error for me; I don't know if there is a > more idiomatic way of solving this. I think adding a "break;" is the normal way to do it, so I've now done this on the pgtk branch. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no