* bug#57835: (featurep 'haiku) vs (eq system-type 'haiku) @ 2022-09-15 16:24 ` Stefan Kangas 2022-09-16 1:28 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors 2022-09-19 7:47 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors 0 siblings, 2 replies; 3+ messages in thread From: Stefan Kangas @ 2022-09-15 16:24 UTC (permalink / raw) To: 57835; +Cc: Po Lu Severity: wishlist Should the below be changed to use (eq system-type 'haiku) instead? It seems like that's the pattern we use for the other systems we support. ./term/haiku-win.el:28:(unless (featurep 'haiku) ./loadup.el:306:(if (featurep 'haiku) ./cus-start.el:866: (featurep 'haiku)) ./version.el:81: ((featurep 'haiku) ./select.el:527: ((featurep 'haiku) (add-hook 'haiku-lost-selection-functions ./select.el:535: ((featurep 'haiku) (remove-hook 'haiku-lost-selection-functions ./net/browse-url.el:1044: ((featurep 'haiku) ./image/wallpaper.el:246: ((featurep 'haiku) ^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#57835: (featurep 'haiku) vs (eq system-type 'haiku) 2022-09-15 16:24 ` bug#57835: (featurep 'haiku) vs (eq system-type 'haiku) Stefan Kangas @ 2022-09-16 1:28 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors 2022-09-19 7:47 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors 1 sibling, 0 replies; 3+ messages in thread From: Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2022-09-16 1:28 UTC (permalink / raw) To: Stefan Kangas; +Cc: 57835 Stefan Kangas <stefankangas@gmail.com> writes: > Severity: wishlist > > Should the below be changed to use (eq system-type 'haiku) instead? > It seems like that's the pattern we use for the other systems we > support. > > ./term/haiku-win.el:28:(unless (featurep 'haiku) > ./loadup.el:306:(if (featurep 'haiku) > ./cus-start.el:866: (featurep 'haiku)) > ./version.el:81: ((featurep 'haiku) > ./select.el:527: ((featurep 'haiku) (add-hook > 'haiku-lost-selection-functions > ./select.el:535: ((featurep 'haiku) (remove-hook > 'haiku-lost-selection-functions > ./net/browse-url.el:1044: ((featurep 'haiku) > ./image/wallpaper.el:246: ((featurep 'haiku) The `haiku' named feature checks for Haiku window system support, while `system-type' only checks if Emacs (which could be built without window system support) is running on Haiku. So this isn't a bug. ^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#57835: (featurep 'haiku) vs (eq system-type 'haiku) 2022-09-15 16:24 ` bug#57835: (featurep 'haiku) vs (eq system-type 'haiku) Stefan Kangas 2022-09-16 1:28 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2022-09-19 7:47 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors 1 sibling, 0 replies; 3+ messages in thread From: Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2022-09-19 7:47 UTC (permalink / raw) To: 57835-done ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-19 7:47 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <87fsgnreki.fsf.ref@yahoo.com> 2022-09-15 16:24 ` bug#57835: (featurep 'haiku) vs (eq system-type 'haiku) Stefan Kangas 2022-09-16 1:28 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors 2022-09-19 7:47 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).