From: Jonas Bernoulli <jonas@bernoul.li>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 60740@debbugs.gnu.org, larsi@gnus.org
Subject: bug#60740: [PATCH 0/2] emoji changes
Date: Sun, 05 Feb 2023 17:29:12 +0100 [thread overview]
Message-ID: <87fsbkkrdz.fsf@bernoul.li> (raw)
In-Reply-To: <83wn4wqhot.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Jonas Bernoulli <jonas@bernoul.li>
>> Cc: 60740@debbugs.gnu.org, larsi@gnus.org
>> Date: Sun, 05 Feb 2023 15:40:48 +0100
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> > My suggestion is for now to install the first patch on emacs-29 and
>> > the second one on master.
>>
>> I've installed the first
>
> This apparently leads to
I looked at the log to prevent that, but I think I just redirected
stdout and forgot about stderr. Byte-compiler warnings go to stderr,
right?
> ELC ../lisp/isearch.elc
>
> In end of data:
> isearch.el:2785:40: Warning: the function `emoji--read-emoji' is not
> known to be defined.
What's the usual way of dealing with this in Emacs itself? I wasn't
sure using an autoload would work here, and was going to use another
approach if this resulted in a warning. Unfortunately I missed the
warning. Should I use 'declare-function' instead and require 'emoji'
inside 'isearch-emoji-by-name'?
> ELC international/emoji.elc
>
> In emoji--choose-emoji:
> international/emoji.el:688:37: Warning: Unused lexical variable
> `emoji--read-emoji'
Yikes.
next prev parent reply other threads:[~2023-02-05 16:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <83leli3nly.fsf@gnu.org>
2023-02-01 23:09 ` bug#60740: [PATCH 0/2] emoji changes Jonas Bernoulli
2023-02-01 23:09 ` bug#60740: [PATCH 1/2] No longer use transient in isearch-emoji-by-name Jonas Bernoulli
2023-02-01 23:09 ` bug#60740: [PATCH 2/2] Rewrite emoji's usage of transient Jonas Bernoulli
2023-02-04 8:30 ` bug#60740: [PATCH 0/2] emoji changes Eli Zaretskii
2023-02-04 12:05 ` Jonas Bernoulli
2023-02-04 12:29 ` Eli Zaretskii
2023-02-05 14:40 ` Jonas Bernoulli
2023-02-05 14:53 ` Eli Zaretskii
2023-02-05 15:02 ` Eli Zaretskii
2023-02-05 16:29 ` Jonas Bernoulli [this message]
2023-02-05 16:53 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsbkkrdz.fsf@bernoul.li \
--to=jonas@bernoul.li \
--cc=60740@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).