From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.bugs Subject: bug#60740: [PATCH 0/2] emoji changes Date: Sun, 05 Feb 2023 17:29:12 +0100 Message-ID: <87fsbkkrdz.fsf@bernoul.li> References: <83leli3nly.fsf@gnu.org> <20230201230918.550-1-jonas@bernoul.li> <83zg9tu91v.fsf@gnu.org> <874js1vdo7.fsf@bernoul.li> <83r0v5txzs.fsf@gnu.org> <87ilggkwen.fsf@bernoul.li> <83wn4wqhot.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3191"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60740@debbugs.gnu.org, larsi@gnus.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 05 17:30:40 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pOhuZ-0000hX-RT for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Feb 2023 17:30:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pOhu6-0001ED-A1; Sun, 05 Feb 2023 11:30:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOhu0-0001DG-5d for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 11:30:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pOhty-0003UX-Jd for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 11:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pOhty-0004fc-6C for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 11:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Feb 2023 16:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60740 X-GNU-PR-Package: emacs Original-Received: via spool by 60740-submit@debbugs.gnu.org id=B60740.167561456217886 (code B ref 60740); Sun, 05 Feb 2023 16:30:02 +0000 Original-Received: (at 60740) by debbugs.gnu.org; 5 Feb 2023 16:29:22 +0000 Original-Received: from localhost ([127.0.0.1]:46320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOhtK-0004eP-4o for submit@debbugs.gnu.org; Sun, 05 Feb 2023 11:29:22 -0500 Original-Received: from mail.hostpark.net ([212.243.197.30]:37632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOhtH-0004eD-85 for 60740@debbugs.gnu.org; Sun, 05 Feb 2023 11:29:20 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 083CE1625C; Sun, 5 Feb 2023 17:29:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from:received :received; s=sel2011a; t=1675614552; bh=Sl0RVfJZDVcyDqsi7S5LhVAI QihU6dHQiZaNWuCO1OY=; b=Mjja4KF/oJIZ1fSr2P/Soh7FjCz/Vrw8M1DVbHnX sn7goq8P3sKdK0+yuT5i2zymD5V+6e55pSnncPN3Hv12S53t68ZOruSFBin91vFT P7etb3NWo/MBZrLY4mn45nUGsopKlFznWfZ+FXu8twI5KXoS/h41v1HIkMLSc8ko f9k= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id nx-tTItpePNo; Sun, 5 Feb 2023 17:29:12 +0100 (CET) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id A14A816255; Sun, 5 Feb 2023 17:29:12 +0100 (CET) In-Reply-To: <83wn4wqhot.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254870 Archived-At: Eli Zaretskii writes: >> From: Jonas Bernoulli >> Cc: 60740@debbugs.gnu.org, larsi@gnus.org >> Date: Sun, 05 Feb 2023 15:40:48 +0100 >> >> Eli Zaretskii writes: >> >> > My suggestion is for now to install the first patch on emacs-29 and >> > the second one on master. >> >> I've installed the first > > This apparently leads to I looked at the log to prevent that, but I think I just redirected stdout and forgot about stderr. Byte-compiler warnings go to stderr, right? > ELC ../lisp/isearch.elc > > In end of data: > isearch.el:2785:40: Warning: the function `emoji--read-emoji' is not > known to be defined. What's the usual way of dealing with this in Emacs itself? I wasn't sure using an autoload would work here, and was going to use another approach if this resulted in a warning. Unfortunately I missed the warning. Should I use 'declare-function' instead and require 'emoji' inside 'isearch-emoji-by-name'? > ELC international/emoji.elc > > In emoji--choose-emoji: > international/emoji.el:688:37: Warning: Unused lexical variable > `emoji--read-emoji' Yikes.