unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Jeremy Bryant <jb@jeremybryant.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>,
	"Eli Zaretskii" <eliz@gnu.org>
Cc: 58808@debbugs.gnu.org
Subject: bug#58808: map-y-or-n-p should use read-key, not read-event
Date: Wed, 08 Feb 2023 22:51:11 +0000	[thread overview]
Message-ID: <87fsbfu5y8.fsf@jeremybryant.net> (raw)
In-Reply-To: <jwvpmed2s9i.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 27 Oct 2022 11:39:10 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:
Hi Stefan,

In order to work on this, please could you confirm the suggested change
below from October is still the recommended one, to work on a patch
along the lines below?

Jeremy

>>> I found that map-y-or-n-p uses read-event, not read-key (still the
>>> case in master as of 2022-10-27).  Will you accept a patch if I try
>>> to rewrite it?
> [...]
>> Isn't there some translation map that could help you?
>
> No, `read-event` is the low-level function that gives access to the
> actual untranslated events.  I think `map-y-or-n-p` should be changed
> similarly to `y-or-n-p` to use either `read-key` or the minibuffer
> (probably obeying `y-or-n-p-use-read-key`).
>
>
>         Stefan





  reply	other threads:[~2023-02-08 22:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26 23:59 bug#58808: map-y-or-n-p should use read-key, not read-event meedstrom--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-27  5:58 ` Eli Zaretskii
2022-10-27 15:39   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-08 22:51     ` Jeremy Bryant [this message]
2023-02-08 23:59       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-27 11:01 ` meedstrom--- via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsbfu5y8.fsf@jeremybryant.net \
    --to=jb@jeremybryant.net \
    --cc=58808@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).