From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jeremy Bryant Newsgroups: gmane.emacs.bugs Subject: bug#58808: map-y-or-n-p should use read-key, not read-event Date: Wed, 08 Feb 2023 22:51:11 +0000 Message-ID: <87fsbfu5y8.fsf@jeremybryant.net> References: <26bfd854bff2e7ccb0de0f1acb20ce2ced6e006a@teknik.io> <83fsf9n6xu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13574"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 58808@debbugs.gnu.org To: Stefan Monnier , "Eli Zaretskii" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 09 04:39:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pPxmS-0003L5-Mo for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Feb 2023 04:39:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPxm7-0003L0-8a; Wed, 08 Feb 2023 22:39:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPxm5-0003KZ-BG for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2023 22:39:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPxm4-0004rt-AG for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2023 22:39:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPxm4-00067J-5f for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2023 22:39:04 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jeremy Bryant Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Feb 2023 03:39:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58808 X-GNU-PR-Package: emacs Original-Received: via spool by 58808-submit@debbugs.gnu.org id=B58808.167591391523414 (code B ref 58808); Thu, 09 Feb 2023 03:39:04 +0000 Original-Received: (at 58808) by debbugs.gnu.org; 9 Feb 2023 03:38:35 +0000 Original-Received: from localhost ([127.0.0.1]:57106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPxlY-00065X-Vd for submit@debbugs.gnu.org; Wed, 08 Feb 2023 22:38:35 -0500 Original-Received: from p3plsmtp17-03-2.prod.phx3.secureserver.net ([173.201.193.166]:40798 helo=p3plwbeout17-03.prod.phx3.secureserver.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPtHd-0006sk-3N for 58808@debbugs.gnu.org; Wed, 08 Feb 2023 17:51:22 -0500 Original-Received: from mailex.mailcore.me ([94.136.40.145]) by :WBEOUT: with ESMTP id PtHUpplkE6DsKPtHUpMlCl; Wed, 08 Feb 2023 15:51:13 -0700 X-CMAE-Analysis: v=2.4 cv=DsOTREz+ c=1 sm=1 tr=0 ts=63e42762 a=7e6w4QD8YWtpVJ/7+iiidw==:117 a=nzDM7VRi/FXkTBRroS9HBg==:17 a=yM0T0u6Ik-0A:10 a=m04uMKEZRckA:10 a=iRZporoAAAAA:8 a=JKSuXWEfkVFDHtsCQmoA:9 a=NOBgFS-JBQ2l-kSd6-zu:22 X-SECURESERVER-ACCT: jb@jeremybryant.net X-SID: PtHUpplkE6DsK Original-Received: from [152.37.91.204] (helo=hexa3.local.com) by smtp07.mailcore.me with esmtpa (Exim 4.94.2) (envelope-from ) id 1pPtHV-00025c-AX; Wed, 08 Feb 2023 22:51:13 +0000 In-Reply-To: (Stefan Monnier's message of "Thu, 27 Oct 2022 11:39:10 -0400") X-Mailcore-Auth: 278589627 X-Mailcore-Domain: 1689493 X-123-reg-Authenticated: jb@jeremybryant.net X-Originating-IP: 152.37.91.204 X-CMAE-Envelope: MS4xfFtRTOn+nA6OTLdKpmdhdLjjmjle8UGxyJEBCInkqe9yl12lPURwa0P7hm8gELRGvh7UaPDLvmmHTNuw8oaO+XE/wfwG71xtK9dkFxJEinC77dgUDkMv EPQXk1+aOhEm71Gyaq/IBjmGXQFwQdr4Vg5g/zOZqfxz5OE3sUfqWGZIteFETyR0kTxKN+QrFUO11xoZbW0j8cvB4ThmfvFlmFk= X-Mailman-Approved-At: Wed, 08 Feb 2023 22:38:31 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255180 Archived-At: Stefan Monnier writes: Hi Stefan, In order to work on this, please could you confirm the suggested change below from October is still the recommended one, to work on a patch along the lines below? Jeremy >>> I found that map-y-or-n-p uses read-event, not read-key (still the >>> case in master as of 2022-10-27). Will you accept a patch if I try >>> to rewrite it? > [...] >> Isn't there some translation map that could help you? > > No, `read-event` is the low-level function that gives access to the > actual untranslated events. I think `map-y-or-n-p` should be changed > similarly to `y-or-n-p` to use either `read-key` or the minibuffer > (probably obeying `y-or-n-p-use-read-key`). > > > Stefan