unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#64935: 30.0.50; Some failed tests for Tramp
@ 2023-07-29 16:26 Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2023-07-30 17:38 ` Michael Albinus
  0 siblings, 1 reply; 11+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-07-29 16:26 UTC (permalink / raw)
  To: 64935

[-- Attachment #1: Type: text/plain, Size: 79 bytes --]


Hi,

Some tests are failing for me on Tramp.  Here is the produced log file.


[-- Attachment #2: tramp-tests.log --]
[-- Type: text/plain, Size: 7804 bytes --]

Running 58 tests (2023-07-29 18:19:03+0200, selector ‘(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))’)
Remote directory: ‘/mock::/tmp/’
   passed   1/58  tramp-test00-availability (0.099552 sec)
   passed   2/58  tramp-test01-file-name-syntax (0.032171 sec)
   passed   3/58  tramp-test02-file-name-dissect (0.022969 sec)
   passed   4/58  tramp-test03-file-name-defaults (0.016731 sec)
   passed   5/58  tramp-test03-file-name-host-rules (0.112698 sec)
   passed   6/58  tramp-test03-file-name-method-rules (0.229611 sec)
   passed   7/58  tramp-test04-substitute-in-file-name (0.003635 sec)
   passed   8/58  tramp-test05-expand-file-name (0.000921 sec)
   passed   9/58  tramp-test05-expand-file-name-relative (0.191613 sec)
   passed  10/58  tramp-test05-expand-file-name-top (0.197940 sec)
   passed  11/58  tramp-test06-directory-file-name (0.191757 sec)
   passed  12/58  tramp-test07-abbreviate-file-name (0.520596 sec)
   passed  13/58  tramp-test07-file-exists-p (0.686342 sec)
   passed  14/58  tramp-test08-file-local-copy (0.564818 sec)
   passed  15/58  tramp-test09-insert-file-contents (0.881275 sec)
Wrote /mock:computer:/tmp/tramp-testp4nRd7
Wrote /mock:computer:/tmp/tramp-testp4nRd7
Wrote /mock:computer:/tmp/tramp-testp4nRd7
   passed  16/58  tramp-test10-write-region (2.231408 sec)
   passed  17/58  tramp-test10-write-region-file-precious-flag (0.829178 sec)
  skipped  18/58  tramp-test10-write-region-other-file-name-handler (0.017172 sec)
   passed  19/58  tramp-test11-copy-file (3.357548 sec)
   passed  20/58  tramp-test12-rename-file (3.103996 sec)
   passed  21/58  tramp-test13-make-directory (0.271594 sec)
   passed  22/58  tramp-test14-delete-directory (1.059498 sec)
   passed  23/58  tramp-test15-copy-directory (2.088268 sec)
   passed  24/58  tramp-test16-directory-files (0.488821 sec)
   passed  25/58  tramp-test16-file-expand-wildcards (0.856164 sec)
   passed  26/58  tramp-test17-dired-with-wildcards (1.045634 sec)
   passed  27/58  tramp-test17-insert-directory (0.605171 sec)
   passed  28/58  tramp-test17-insert-directory-one-file (0.599421 sec)
   passed  29/58  tramp-test18-file-attributes (2.234078 sec)
   passed  30/58  tramp-test19-directory-files-and-attributes (0.725101 sec)
   passed  31/58  tramp-test20-file-modes (0.486878 sec)
   passed  32/58  tramp-test21-file-links (1.796671 sec)
   passed  33/58  tramp-test22-file-times (0.580576 sec)
   passed  34/58  tramp-test23-visited-file-modtime (0.461438 sec)
  skipped  35/58  tramp-test24-file-acl (0.019309 sec)
  skipped  36/58  tramp-test25-file-selinux (0.328894 sec)
   passed  37/58  tramp-test26-file-name-completion (1.078665 sec)
   passed  38/58  tramp-test26-interactive-file-name-completion (2.029193 sec)
   passed  39/58  tramp-test27-load (0.772457 sec)
   passed  40/58  tramp-test33-environment-variables-and-port-numbers (0.221919 sec)
   passed  41/58  tramp-test35-exec-path (0.639290 sec)
   passed  42/58  tramp-test35-remote-path (2.605689 sec)
   passed  43/58  tramp-test37-make-auto-save-file-name (0.535751 sec)
   passed  44/58  tramp-test38-find-backup-file-name (0.693856 sec)
   passed  45/58  tramp-test39-detect-external-change (2.807169 sec)
   passed  46/58  tramp-test39-make-lock-file-name (3.408914 sec)
   passed  47/58  tramp-test40-make-nearby-temp-file (0.541202 sec)
Test tramp-test41-special-characters backtrace:
  signal(ert-test-failed (((should (member name files)) :form (member 
  ert-fail(((should (member name files)) :form (member "?foo bar baz?@
  tramp--test-check-files("\11foo bar baz\11@foo@bar@baz@$foo$bar$$baz
  apply(tramp--test-check-files "\11foo bar baz\11@foo@bar@baz@$foo$ba
  #f(compiled-function () #<bytecode 0x6db6e73ba35fd18>)()
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name tramp-test41-special-characters :docu
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/net/tramp-tests" "--
  command-line()
  normal-top-level()
Test tramp-test41-special-characters condition:
    (ert-test-failed
     ((should (member name files)) :form
      (member
       "?foo bar baz?@foo@bar@baz@$foo$bar$$baz$-foo-bar-baz-%foo%bar%baz%&foo&bar&baz&?foo?bar?baz?*foo+bar*baz+'foo\"bar'baz\"#foo~bar#baz~!foo|bar!baz|:foo;bar:baz;<foo>bar<baz>(foo)bar(baz)[foo]bar[baz]{foo}bar{baz}"
       ("\11foo bar baz\11@foo@bar@baz@$foo$bar$$baz$-foo-bar-baz-%foo%bar%baz%&foo&bar&baz&?foo?bar?baz?*foo+bar*baz+'foo\"bar'baz\"#foo~bar#baz~!foo|bar!baz|:foo;bar:baz;<foo>bar<baz>(foo)bar(baz)[foo]bar[baz]{foo}bar{baz}"))
      :value nil))
   FAILED  48/58  tramp-test41-special-characters (1.087710 sec) at lisp/net/tramp-tests.el:7388
Test tramp-test42-utf8 backtrace:
  signal(ert-test-failed (((should (member name files)) :form (member 
  ert-fail(((should (member name files)) :form (member "???bung" ("Γυρ
  tramp--test-check-files("Γυρίστε το Γαλαξία με Ώτο Στοπ" "أصبح بوسعك
  apply(tramp--test-check-files ("Γυρίστε το Γαλαξία με Ώτο Στοπ" "أصب
  #f(compiled-function () #<bytecode 0x843b90e9b240bce>)()
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name tramp-test42-utf8 :documentation "Che
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/net/tramp-tests" "--
  command-line()
  normal-top-level()
Test tramp-test42-utf8 condition:
    (ert-test-failed
     ((should (member name files)) :form
      (member "???bung"
	      ("Γυρίστε το Γαλαξία με Ώτο Στοπ"
	       "أصبح بوسعك الآن تنزيل نسخة كاملة من موسوعة ويكيبيديا العربية لتصفحها بلا اتصال بالإنترنت"
	       "银河系漫游指南系列" "Автостопом по гала́ктике"
	       "™›šbung" "🌈🍒👋"))
      :value nil))
   FAILED  49/58  tramp-test42-utf8 (3.341081 sec) at lisp/net/tramp-tests.el:7457
   passed  50/58  tramp-test43-file-system-info (0.132409 sec)
   passed  51/58  tramp-test44-file-user-group-ids (0.210491 sec)
  skipped  52/58  tramp-test46-dired-compress-dir (0.095940 sec)
  skipped  53/58  tramp-test46-dired-compress-file (0.193113 sec)
   passed  54/58  tramp-test48-auto-load (0.429029 sec)
   passed  55/58  tramp-test48-delay-load (0.362569 sec)
   passed  56/58  tramp-test48-recursive-load (0.644378 sec)
   passed  57/58  tramp-test48-remote-load-path (0.247035 sec)
   passed  58/58  tramp-test49-without-remote-files (0.190787 sec)

Ran 58 tests, 51 results as expected, 2 unexpected, 5 skipped (2023-07-29 18:19:52+0200, 49.817625 sec)

2 unexpected results:
   FAILED  tramp-test41-special-characters
   FAILED  tramp-test42-utf8

5 skipped results:
  SKIPPED  tramp-test10-write-region-other-file-name-handler
  SKIPPED  tramp-test24-file-acl
  SKIPPED  tramp-test25-file-selinux
  SKIPPED  tramp-test46-dired-compress-dir
  SKIPPED  tramp-test46-dired-compress-file

\a

[-- Attachment #3: Type: text/plain, Size: 8505 bytes --]



In GNU Emacs 30.0.50 (build 1, x86_64-unknown-openbsd7.3, cairo version
 1.17.8) of 2023-07-29 built on computer
Repository revision: f4c3260e982c0ff5f8afc0d80f634d5d3a3f991b
Repository branch: mgi/per-directory
Windowing system distributor 'The X.Org Foundation', version 11.0.12101006
System Description: OpenBSD computer 7.3 GENERIC.MP#1125 amd64

Configured using:
 'configure --prefix=/home/manuel/emacs --bindir=/home/manuel/bin
 --with-x-toolkit=no --with-toolkit-scroll-bars=no --without-sound
 --without-compress-install CPPFLAGS=-I/usr/local/include
 LDFLAGS=-L/usr/local/lib'

Configured features:
CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LCMS2 LIBOTF LIBXML2 MODULES NOTIFY KQUEUE OLDXMENU PDUMPER PNG RSVG
SQLITE3 THREADS TIFF TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM ZLIB

Important settings:
  value of $LC_ALL: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Dired by name

Minor modes in effect:
  global-git-commit-mode: t
  magit-auto-revert-mode: t
  gnus-dired-mode: t
  display-time-mode: t
  display-battery-mode: t
  server-mode: t
  hyperbole-mode: t
  override-global-mode: t
  repeat-mode: t
  desktop-save-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  buffer-read-only: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
/home/manuel/.emacs.d/elpa/ef-themes-1.2.0/theme-loaddefs hides /home/manuel/emacs/share/emacs/30.0.50/lisp/theme-loaddefs

Features:
(shadow emacsbug wdired pcmpl-unix detached-shell man flow-fill
mailalias smtpmail gnus-cite mail-extr textsec uni-scripts idna-mapping
ucs-normalize uni-confusable textsec-check gnus-async gnus-bcklg gnus-ml
gnus-topic mm-archive url-cache qp utf-7 imap rfc2104 nndoc nndraft nnmh
network-stream nnfolder nnml gnus-agent gnus-srvr gnus-score score-mode
nnvirtual nntp gnus-cache nnrss misearch multi-isearch magit-extras
mule-util magit-patch face-remap magit-bookmark magit-submodule
magit-obsolete magit-blame magit-stash magit-reflog magit-bisect
magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit
magit-sequence magit-notes magit-worktree magit-tag magit-merge
magit-branch magit-reset magit-files magit-refs magit-status magit
magit-repos magit-apply magit-wip magit-log which-func magit-diff
git-commit log-edit add-log magit-core magit-autorevert magit-margin
magit-transient magit-process with-editor magit-mode transient magit-git
magit-section magit-utils dash image-dired-dired tabify image-file
image-converter image-dired image-dired-tags image-dired-external
image-dired-util help-fns radix-tree cus-edit cus-start kotl-autoloads
css-mode sgml-mode facemenu imenu vc-cvs vc-rcs log-view pcvs-util
sh-script smie treesit executable vc pascal vc-hg conf-mode reveal
texinfo texinfo-loaddefs smerge-mode diff emacs-news-mode make-mode
gnus-dired bug-reference paredit vc-git whitespace diff-mode time
battery org-indent vc-dispatcher vc-svn oc-basic ol-eww eww url-queue
mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview
doc-view jka-compr image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m
ol-doi org-link-doi org-agenda cus-load exwm-randr xcb-randr exwm-config
ido exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating
xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh
xcb-icccm xcb xcb-xproto xcb-types xcb-debug server modus-operandi-theme
modus-themes zone speed-type url-http url-auth url-gw nsm compat ytdious
mingus libmpdee reporter edebug detached-init detached autorevert
filenotify transmission calc-bin calc-ext calc calc-loaddefs rect
calc-macs supercite regi ebdb-message ebdb-gnus ebdb-mua ebdb-com crm
ebdb-format ebdb eieio-opt speedbar ezimage dframe eieio-base pcase
timezone gnus-icalendar org-capture icalendar visual-basic-mode cl
web-mode disp-table erlang-start smart-tabs-mode skeleton cc-mode
cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars
cc-defs slime-asdf grep slime-tramp slime-fancy slime-indentation
slime-cl-indent cl-indent slime-trace-dialog slime-fontifying-fu
slime-package-fu slime-references slime-compiler-notes-tree advice
slime-scratch slime-presentations bridge slime-macrostep macrostep
slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace
slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc
slime-repl slime-parse slime apropos arc-mode archive-mode hyperspec
thingatpt slime-autoloads hyperbole hinit hibtypes hib-doc-id klink
hib-kbd hib-debbugs hib-social hsys-www hypb-ert ert ewoc debug
backtrace hactypes bookmark pp hui-mini hui hui-mouse hmouse-key hargs
etags fileloop xref project hsys-org org-element org-persist org-id
org-refile avl-tree generator org ob ob-tangle ob-ref ob-lob ob-table
ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote
org-faces org-entities ob-emacs-lisp ob-core ob-eval org-cycle org-table
ol org-fold org-fold-core org-keys oc org-loaddefs find-func org-version
org-compat org-macs hui-menu hyrolo-menu hyrolo sort hui-jmenu hpath
tramp rx tramp-loaddefs trampver tramp-integration files-x tramp-compat
xdg shell pcomplete format-spec noutline outline icons hmouse-sh
hmouse-drv hui-window pulse color hycontrol hui-select hsettings
hui-em-but hbut view hbdata hgnus gnus-msg gnus-art mm-uu mml2015
mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku
url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud
nnimap nnmail mail-source utf7 nnoo parse-time iso8601 gnus-spec
gnus-int gnus-range gnus-win gnus nnheader range wid-edit hsmail message
sendmail yank-media puny rfc822 mml mml-sec epa derived epg rfc6068
epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse
rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev
mail-utils gmm-utils mailheader hmail htz cal-julian hbmap hmoccur hvar
hypb locate hact hhist compile text-property-search comint ansi-osc
ansi-color ring set hversion hload-path edmacro kmacro
use-package-bind-key bind-key appt diary-lib diary-loaddefs cal-menu
calendar cal-loaddefs dired-x dired-aux dired dired-loaddefs
notifications dbus xml cl-extra help-mode use-package-core repeat
easy-mmode desktop frameset debbugs-autoloads detached-autoloads
ebdb-autoloads ef-themes-autoloads exwm-autoloads hyperbole-autoloads
magit-autoloads git-commit-autoloads finder-inf magit-section-autoloads
dash-autoloads osm-autoloads paredit-autoloads rust-mode-autoloads
speed-type-autoloads transmission-autoloads visual-fill-column-autoloads
with-editor-autoloads info compat-autoloads ytdious-autoloads package
browse-url url url-proxy url-privacy url-expand url-methods url-history
url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers
url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache
json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs
cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify
ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads dbusbind kqueue lcms2 dynamic-setting system-font-setting
font-render-setting cairo xinput2 x multi-tty move-toolbar
make-network-process emacs)

Memory information:
((conses 16 1114106 720128) (symbols 48 66231 31)
 (strings 32 317667 40941) (string-bytes 1 10312871)
 (vectors 16 198565) (vector-slots 8 3317318 131797)
 (floats 8 717 2465) (intervals 56 31631 7065) (buffers 984 139))

-- 
Manuel Giraud

^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#64935: 30.0.50; Some failed tests for Tramp
  2023-07-29 16:26 bug#64935: 30.0.50; Some failed tests for Tramp Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-07-30 17:38 ` Michael Albinus
       [not found]   ` <87jzug9m1x.fsf@ledu-giraud.fr>
  0 siblings, 1 reply; 11+ messages in thread
From: Michael Albinus @ 2023-07-30 17:38 UTC (permalink / raw)
  To: 64935; +Cc: manuel

[-- Attachment #1: Type: text/plain, Size: 839 bytes --]

Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:

> Hi,

Hi Manuel,

> 2 unexpected results:
>    FAILED  tramp-test41-special-characters
>    FAILED  tramp-test42-utf8

I've tried to reproduce the problem on an old FreeBSD 12 VM, but the
tests succeed. That was the closest machine I could find, compared with
your system.

> In GNU Emacs 30.0.50 (build 1, x86_64-unknown-openbsd7.3, cairo version
>  1.17.8) of 2023-07-29 built on computer

Could you pls apply the appended patch, and run then

$ make -C test tramp-tests.log SELECTOR='(or tramp-test41-special-characters tramp-test42-utf8)'

There will be a file tramp-tests.log (large), which you could send
gzipped. Since it will still be several MB, perhaps you send it only to
me directly.

Best regards, Michael.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 990 bytes --]

diff --git a/test/tramp-tests.el b/test/tramp-tests.el
index ee9c09df..c2ff3388 100644
--- a/test/tramp-tests.el
+++ b/test/tramp-tests.el
@@ -7181,6 +7181,7 @@ This requires restrictions of file name syntax."

 (defun tramp--test-check-files (&rest files)
   "Run a simple but comprehensive test over every file in FILES."
+  (tramp--test-instrument-test-case 10
   (dolist (quoted (if (tramp--test-expensive-test-p) '(nil t) '(nil)))
     ;; We must use `file-truename' for the temporary directory,
     ;; because it could be located on a symlinked directory.  This
@@ -7383,7 +7384,7 @@ This requires restrictions of file name syntax."
 	;; Cleanup.
 	(ignore-errors (kill-buffer buffer))
 	(ignore-errors (delete-directory tmp-name1 'recursive))
-	(ignore-errors (delete-directory tmp-name2 'recursive))))))
+	(ignore-errors (delete-directory tmp-name2 'recursive)))))))

 ;; These tests are inspired by Bug#17238.
 (ert-deftest tramp-test41-special-characters ()

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* bug#64935: 30.0.50; Some failed tests for Tramp
       [not found]   ` <87jzug9m1x.fsf@ledu-giraud.fr>
@ 2023-08-02 18:41     ` Michael Albinus
  2023-08-03 17:22       ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 11+ messages in thread
From: Michael Albinus @ 2023-08-02 18:41 UTC (permalink / raw)
  To: Manuel Giraud; +Cc: 64935

Manuel Giraud <manuel@ledu-giraud.fr> writes:

> Hi Michael,

Hi Manuel,

> Your patch did not applied but I've made the same changes and here is
> the full log.

Thanks. Your ls command seems to be less featured.

In both tests, special file names are investigated. They are
"	foo bar baz	" (leading and trailing TAB) and "™›šbung".

Everything is fine in creation, modification, and deleting with these
files. But at one point, Tramp wants a directory listing, and does

--8<---------------cut here---------------start------------->8---
16:35:57.806511 tramp-send-command (6) # /bin/ls -al /tmp/tramp-testaIHNWR/. 2>/dev/null
16:35:57.812537 tramp-wait-for-regexp (6) #
total 186
drwxr-xr-x   2 manuel  wheel   5632 Jul 31 16:35 .
drwxrwxrwt  18 root    wheel   4096 Jul 31 16:35 ..
-rw-r--r--   1 manuel  manuel    10 Jul 31 16:35 ???bung
--8<---------------cut here---------------end--------------->8---

as well as

--8<---------------cut here---------------start------------->8---
16:36:16.803178 tramp-send-command (6) # /bin/ls -al /tmp/tramp-testLuWwoc/. 2>/dev/null
total 42
-rw-r--r--   1 manuel  manuel    13 Jul 31 16:36 ?foo bar baz?
--8<---------------cut here---------------end--------------->8---

That is, the special characters are replaced by a question mark
"?". Tramp does several checks how to invoke ls, but in your case it
couldn't find proper options. If there is a GNU ls, for example, Tramp
calls instead

--8<---------------cut here---------------start------------->8---
20:38:15.943249 tramp-send-command (6) # /usr/bin/ls --color=never -al --quoting-style\=literal --show-control-chars /home/albinus/. 2>/dev/null
--8<---------------cut here---------------end--------------->8---

Could you please investigate on your system, how to invoke ls for seeing
a TAB in a file name as TAB?

> Thanks.

Best regards, Michael.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#64935: 30.0.50; Some failed tests for Tramp
  2023-08-02 18:41     ` Michael Albinus
@ 2023-08-03 17:22       ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2023-08-04  4:05         ` Michael Albinus
  0 siblings, 1 reply; 11+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-08-03 17:22 UTC (permalink / raw)
  To: Michael Albinus; +Cc: 64935

Michael Albinus <michael.albinus@gmx.de> writes:

[...]

> Could you please investigate on your system, how to invoke ls for seeing
> a TAB in a file name as TAB?

Hi Michael,

I have read OpenBSD ls man page and the only option related to non
printable chars is the following:

     -q      Force printing of non-graphic characters in file names as the
             character ‘?’; this is the default when output is to a terminal.

What is weird is that I can create a local file named "/tmp/ foo" and
that Dired can display it correctly (ie. without a question mark but
with a real tab).
-- 
Manuel Giraud





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#64935: 30.0.50; Some failed tests for Tramp
  2023-08-03 17:22       ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-08-04  4:05         ` Michael Albinus
  2023-08-04  7:51           ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 11+ messages in thread
From: Michael Albinus @ 2023-08-04  4:05 UTC (permalink / raw)
  To: Manuel Giraud; +Cc: 64935

Manuel Giraud <manuel@ledu-giraud.fr> writes:

> Hi Michael,

Hi Manuel,

> I have read OpenBSD ls man page and the only option related to non
> printable chars is the following:
>
>      -q      Force printing of non-graphic characters in file names as the
>              character ‘?’; this is the default when output is to a terminal.
>
> What is weird is that I can create a local file named "/tmp/ foo" and
> that Dired can display it correctly (ie. without a question mark but
> with a real tab).

Well, your underlying file system handles these special characters
properly. It is just ls, which cannot display them. And dired does not
use ls internally in the local case.

There are already special cases for different systems in tramp-tests.el,
so we could add your case as well. What does "uname -sr" return on your
machine?

Best regards, Michael.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#64935: 30.0.50; Some failed tests for Tramp
  2023-08-04  4:05         ` Michael Albinus
@ 2023-08-04  7:51           ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2023-08-06  9:48             ` Michael Albinus
  0 siblings, 1 reply; 11+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-08-04  7:51 UTC (permalink / raw)
  To: Michael Albinus; +Cc: 64935

Michael Albinus <michael.albinus@gmx.de> writes:

> Manuel Giraud <manuel@ledu-giraud.fr> writes:
>
>> Hi Michael,
>
> Hi Manuel,
>
>> I have read OpenBSD ls man page and the only option related to non
>> printable chars is the following:
>>
>>      -q      Force printing of non-graphic characters in file names as the
>>              character ‘?’; this is the default when output is to a terminal.
>>
>> What is weird is that I can create a local file named "/tmp/ foo" and
>> that Dired can display it correctly (ie. without a question mark but
>> with a real tab).
>
> Well, your underlying file system handles these special characters
> properly. It is just ls, which cannot display them. And dired does not
> use ls internally in the local case.

Hi Michael,

I think that Dired uses ls but it seems that it does with a call to
`call-process' so there is no shell involved.  But I imagine that Tramp
needs a shell.

> There are already special cases for different systems in tramp-tests.el,
> so we could add your case as well. What does "uname -sr" return on your
> machine?

It returns: OpenBSD 7.3
-- 
Manuel Giraud





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#64935: 30.0.50; Some failed tests for Tramp
  2023-08-04  7:51           ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-08-06  9:48             ` Michael Albinus
  2023-08-06 11:31               ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 11+ messages in thread
From: Michael Albinus @ 2023-08-06  9:48 UTC (permalink / raw)
  To: Manuel Giraud; +Cc: 64935

Manuel Giraud <manuel@ledu-giraud.fr> writes:

Hi Manuel,

>> There are already special cases for different systems in tramp-tests.el,
>> so we could add your case as well. What does "uname -sr" return on your
>> machine?
>
> It returns: OpenBSD 7.3

I've suppressed both file names for OpenBSD in the tests, pushed to
master. Could you, pls, check?

Best regards, Michael.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#64935: 30.0.50; Some failed tests for Tramp
  2023-08-06  9:48             ` Michael Albinus
@ 2023-08-06 11:31               ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2023-08-06 11:53                 ` Michael Albinus
  0 siblings, 1 reply; 11+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-08-06 11:31 UTC (permalink / raw)
  To: Michael Albinus; +Cc: 64935

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]

Michael Albinus <michael.albinus@gmx.de> writes:

> Manuel Giraud <manuel@ledu-giraud.fr> writes:
>
> Hi Manuel,
>
>>> There are already special cases for different systems in tramp-tests.el,
>>> so we could add your case as well. What does "uname -sr" return on your
>>> machine?
>>
>> It returns: OpenBSD 7.3
>
> I've suppressed both file names for OpenBSD in the tests, pushed to
> master. Could you, pls, check?

Hi,

Here is the Tramp log from a regular "make check".  It seems that I
still have a FAILED on test41.

Best regards,
-- 
Manuel Giraud

[-- Attachment #2: tramp-tests.log --]
[-- Type: text/plain, Size: 6161 bytes --]

Running 58 tests (2023-08-06 13:18:08+0200, selector ‘(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))’)
Remote directory: ‘/mock::/tmp/’
   passed   1/58  tramp-test00-availability (0.342916 sec)
   passed   2/58  tramp-test01-file-name-syntax (0.029083 sec)
   passed   3/58  tramp-test02-file-name-dissect (0.023083 sec)
   passed   4/58  tramp-test03-file-name-defaults (0.016208 sec)
   passed   5/58  tramp-test03-file-name-host-rules (0.107407 sec)
   passed   6/58  tramp-test03-file-name-method-rules (0.279734 sec)
   passed   7/58  tramp-test04-substitute-in-file-name (0.005110 sec)
   passed   8/58  tramp-test05-expand-file-name (0.001262 sec)
   passed   9/58  tramp-test05-expand-file-name-relative (0.242244 sec)
   passed  10/58  tramp-test05-expand-file-name-top (0.240448 sec)
   passed  11/58  tramp-test06-directory-file-name (0.253517 sec)
   passed  12/58  tramp-test07-abbreviate-file-name (0.651194 sec)
   passed  13/58  tramp-test07-file-exists-p (0.741771 sec)
   passed  14/58  tramp-test08-file-local-copy (0.700929 sec)
   passed  15/58  tramp-test09-insert-file-contents (0.983149 sec)
Wrote /mock:computer:/tmp/tramp-testSvtPQb
Wrote /mock:computer:/tmp/tramp-testSvtPQb
Wrote /mock:computer:/tmp/tramp-testSvtPQb
   passed  16/58  tramp-test10-write-region (2.324712 sec)
   passed  17/58  tramp-test10-write-region-file-precious-flag (0.871043 sec)
  skipped  18/58  tramp-test10-write-region-other-file-name-handler (0.016693 sec)
   passed  19/58  tramp-test11-copy-file (2.858342 sec)
   passed  20/58  tramp-test12-rename-file (2.980400 sec)
   passed  21/58  tramp-test13-make-directory (0.363743 sec)
   passed  22/58  tramp-test14-delete-directory (1.059691 sec)
   passed  23/58  tramp-test15-copy-directory (1.879029 sec)
   passed  24/58  tramp-test16-directory-files (0.597159 sec)
   passed  25/58  tramp-test16-file-expand-wildcards (0.644862 sec)
   passed  26/58  tramp-test17-dired-with-wildcards (0.942963 sec)
   passed  27/58  tramp-test17-insert-directory (0.661439 sec)
   passed  28/58  tramp-test17-insert-directory-one-file (0.688573 sec)
   passed  29/58  tramp-test18-file-attributes (2.276620 sec)
   passed  30/58  tramp-test19-directory-files-and-attributes (0.759572 sec)
   passed  31/58  tramp-test20-file-modes (0.643671 sec)
   passed  32/58  tramp-test21-file-links (2.006793 sec)
   passed  33/58  tramp-test22-file-times (0.708466 sec)
   passed  34/58  tramp-test23-visited-file-modtime (0.567958 sec)
  skipped  35/58  tramp-test24-file-acl (0.017484 sec)
  skipped  36/58  tramp-test25-file-selinux (0.426385 sec)
   passed  37/58  tramp-test26-file-name-completion (1.145828 sec)
   passed  38/58  tramp-test26-interactive-file-name-completion (2.032344 sec)
   passed  39/58  tramp-test27-load (0.872643 sec)
   passed  40/58  tramp-test33-environment-variables-and-port-numbers (0.327951 sec)
   passed  41/58  tramp-test35-exec-path (0.787327 sec)
   passed  42/58  tramp-test35-remote-path (4.011547 sec)
   passed  43/58  tramp-test37-make-auto-save-file-name (0.615598 sec)
   passed  44/58  tramp-test38-find-backup-file-name (0.919176 sec)
   passed  45/58  tramp-test39-detect-external-change (3.086355 sec)
   passed  46/58  tramp-test39-make-lock-file-name (4.174026 sec)
   passed  47/58  tramp-test40-make-nearby-temp-file (0.649466 sec)
Test tramp-test41-special-characters backtrace:
  signal(ert-test-failed (((should (member name files)) :form (member 
  ert-fail(((should (member name files)) :form (member "foo bar baz @f
  tramp--test-check-files(" foo bar baz @foo@bar@baz@$foo$bar$$baz$-fo
  apply(tramp--test-check-files " foo bar baz @foo@bar@baz@$foo$bar$$b
  #f(compiled-function () #<bytecode 0x1e96fe0d0cea50c6>)()
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name tramp-test41-special-characters :docu
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/net/tramp-tests" "--
  command-line()
  normal-top-level()
Test tramp-test41-special-characters condition:
    (ert-test-failed
     ((should (member name files)) :form
      (member
       "foo bar baz @foo@bar@baz@$foo$bar$$baz$-foo-bar-baz-%foo%bar%baz%&foo&bar&baz&?foo?bar?baz?*foo+bar*baz+'foo\"bar'baz\"#foo~bar#baz~!foo|bar!baz|:foo;bar:baz;<foo>bar<baz>(foo)bar(baz)[foo]bar[baz]{foo}bar{baz}"
       (" foo bar baz @foo@bar@baz@$foo$bar$$baz$-foo-bar-baz-%foo%bar%baz%&foo&bar&baz&?foo?bar?baz?*foo+bar*baz+'foo\"bar'baz\"#foo~bar#baz~!foo|bar!baz|:foo;bar:baz;<foo>bar<baz>(foo)bar(baz)[foo]bar[baz]{foo}bar{baz}"))
      :value nil))
   FAILED  48/58  tramp-test41-special-characters (1.161472 sec) at lisp/net/tramp-tests.el:7395
   passed  49/58  tramp-test42-utf8 (5.033835 sec)
   passed  50/58  tramp-test43-file-system-info (0.249897 sec)
   passed  51/58  tramp-test44-file-user-group-ids (0.370989 sec)
  skipped  52/58  tramp-test46-dired-compress-dir (0.130810 sec)
  skipped  53/58  tramp-test46-dired-compress-file (0.466468 sec)
   passed  54/58  tramp-test48-auto-load (0.589145 sec)
   passed  55/58  tramp-test48-delay-load (0.370569 sec)
   passed  56/58  tramp-test48-recursive-load (0.853268 sec)
   passed  57/58  tramp-test48-remote-load-path (0.333634 sec)
   passed  58/58  tramp-test49-without-remote-files (0.323961 sec)

Ran 58 tests, 52 results as expected, 1 unexpected, 5 skipped (2023-08-06 13:19:05+0200, 56.824367 sec)

1 unexpected results:
   FAILED  tramp-test41-special-characters

5 skipped results:
  SKIPPED  tramp-test10-write-region-other-file-name-handler
  SKIPPED  tramp-test24-file-acl
  SKIPPED  tramp-test25-file-selinux
  SKIPPED  tramp-test46-dired-compress-dir
  SKIPPED  tramp-test46-dired-compress-file

\a

^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#64935: 30.0.50; Some failed tests for Tramp
  2023-08-06 11:31               ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-08-06 11:53                 ` Michael Albinus
  2023-08-06 13:45                   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 11+ messages in thread
From: Michael Albinus @ 2023-08-06 11:53 UTC (permalink / raw)
  To: Manuel Giraud; +Cc: 64935

Manuel Giraud <manuel@ledu-giraud.fr> writes:

> Hi,

Hi Manuel,

> Here is the Tramp log from a regular "make check".  It seems that I
> still have a FAILED on test41.

Well OpenBSD doesn't like leading spaces as well. I have adapted the
test, pushed to master.

> Best regards,

Best regards, Michael.





^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#64935: 30.0.50; Some failed tests for Tramp
  2023-08-06 11:53                 ` Michael Albinus
@ 2023-08-06 13:45                   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2023-08-06 13:51                     ` Michael Albinus
  0 siblings, 1 reply; 11+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-08-06 13:45 UTC (permalink / raw)
  To: Michael Albinus; +Cc: 64935

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

I think it is ok this time.  Thanks!

Do you happen to know what should I do with other failing tests (not
in Tramp)?  Should I report them one by one?
-- 
Manuel Giraud

[-- Attachment #2: tramp-tests.log --]
[-- Type: text/plain, Size: 4452 bytes --]

Running 58 tests (2023-08-06 15:35:51+0200, selector ‘(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))’)
Remote directory: ‘/mock::/tmp/’
   passed   1/58  tramp-test00-availability (0.146642 sec)
   passed   2/58  tramp-test01-file-name-syntax (0.061893 sec)
   passed   3/58  tramp-test02-file-name-dissect (0.020164 sec)
   passed   4/58  tramp-test03-file-name-defaults (0.016883 sec)
   passed   5/58  tramp-test03-file-name-host-rules (0.105870 sec)
   passed   6/58  tramp-test03-file-name-method-rules (0.241420 sec)
   passed   7/58  tramp-test04-substitute-in-file-name (0.003710 sec)
   passed   8/58  tramp-test05-expand-file-name (0.001100 sec)
   passed   9/58  tramp-test05-expand-file-name-relative (0.274602 sec)
   passed  10/58  tramp-test05-expand-file-name-top (0.239484 sec)
   passed  11/58  tramp-test06-directory-file-name (0.241882 sec)
   passed  12/58  tramp-test07-abbreviate-file-name (0.624839 sec)
   passed  13/58  tramp-test07-file-exists-p (0.743157 sec)
   passed  14/58  tramp-test08-file-local-copy (0.681999 sec)
   passed  15/58  tramp-test09-insert-file-contents (1.000646 sec)
Wrote /mock:computer:/tmp/tramp-testJhtZUQ
Wrote /mock:computer:/tmp/tramp-testJhtZUQ
Wrote /mock:computer:/tmp/tramp-testJhtZUQ
   passed  16/58  tramp-test10-write-region (2.355329 sec)
   passed  17/58  tramp-test10-write-region-file-precious-flag (0.879705 sec)
  skipped  18/58  tramp-test10-write-region-other-file-name-handler (0.016147 sec)
   passed  19/58  tramp-test11-copy-file (3.005543 sec)
   passed  20/58  tramp-test12-rename-file (3.221136 sec)
   passed  21/58  tramp-test13-make-directory (0.372736 sec)
   passed  22/58  tramp-test14-delete-directory (1.092970 sec)
   passed  23/58  tramp-test15-copy-directory (1.964035 sec)
   passed  24/58  tramp-test16-directory-files (0.618258 sec)
   passed  25/58  tramp-test16-file-expand-wildcards (0.651578 sec)
   passed  26/58  tramp-test17-dired-with-wildcards (0.954620 sec)
   passed  27/58  tramp-test17-insert-directory (0.686118 sec)
   passed  28/58  tramp-test17-insert-directory-one-file (0.701847 sec)
   passed  29/58  tramp-test18-file-attributes (2.328581 sec)
   passed  30/58  tramp-test19-directory-files-and-attributes (0.730243 sec)
   passed  31/58  tramp-test20-file-modes (0.574224 sec)
   passed  32/58  tramp-test21-file-links (2.084091 sec)
   passed  33/58  tramp-test22-file-times (0.704800 sec)
   passed  34/58  tramp-test23-visited-file-modtime (0.560264 sec)
  skipped  35/58  tramp-test24-file-acl (0.017854 sec)
  skipped  36/58  tramp-test25-file-selinux (0.426050 sec)
   passed  37/58  tramp-test26-file-name-completion (1.125893 sec)
   passed  38/58  tramp-test26-interactive-file-name-completion (2.034499 sec)
   passed  39/58  tramp-test27-load (0.880015 sec)
   passed  40/58  tramp-test33-environment-variables-and-port-numbers (0.317667 sec)
   passed  41/58  tramp-test35-exec-path (0.778324 sec)
   passed  42/58  tramp-test35-remote-path (3.891923 sec)
   passed  43/58  tramp-test37-make-auto-save-file-name (0.595721 sec)
   passed  44/58  tramp-test38-find-backup-file-name (0.845124 sec)
   passed  45/58  tramp-test39-detect-external-change (2.908683 sec)
   passed  46/58  tramp-test39-make-lock-file-name (4.028328 sec)
   passed  47/58  tramp-test40-make-nearby-temp-file (0.674398 sec)
   passed  48/58  tramp-test41-special-characters (1.740285 sec)
   passed  49/58  tramp-test42-utf8 (4.851433 sec)
   passed  50/58  tramp-test43-file-system-info (0.287306 sec)
   passed  51/58  tramp-test44-file-user-group-ids (0.320633 sec)
  skipped  52/58  tramp-test46-dired-compress-dir (0.094512 sec)
  skipped  53/58  tramp-test46-dired-compress-file (0.243548 sec)
   passed  54/58  tramp-test48-auto-load (0.521869 sec)
   passed  55/58  tramp-test48-delay-load (0.336013 sec)
   passed  56/58  tramp-test48-recursive-load (0.820778 sec)
   passed  57/58  tramp-test48-remote-load-path (0.362913 sec)
   passed  58/58  tramp-test49-without-remote-files (0.242081 sec)

Ran 58 tests, 53 results as expected, 0 unexpected, 5 skipped (2023-08-06 15:36:47+0200, 56.262004 sec)

5 skipped results:
  SKIPPED  tramp-test10-write-region-other-file-name-handler
  SKIPPED  tramp-test24-file-acl
  SKIPPED  tramp-test25-file-selinux
  SKIPPED  tramp-test46-dired-compress-dir
  SKIPPED  tramp-test46-dired-compress-file

\a

^ permalink raw reply	[flat|nested] 11+ messages in thread

* bug#64935: 30.0.50; Some failed tests for Tramp
  2023-08-06 13:45                   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-08-06 13:51                     ` Michael Albinus
  0 siblings, 0 replies; 11+ messages in thread
From: Michael Albinus @ 2023-08-06 13:51 UTC (permalink / raw)
  To: Manuel Giraud; +Cc: 64935-done

Version: 30.1

Manuel Giraud <manuel@ledu-giraud.fr> writes:

Hi Manuel,

> I think it is ok this time.  Thanks!

Thanks for the feedback. I'm closing the bug.

> Do you happen to know what should I do with other failing tests (not
> in Tramp)?  Should I report them one by one?

Yes, this might be the best scenario.

Best regards, Michael.





^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2023-08-06 13:51 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-29 16:26 bug#64935: 30.0.50; Some failed tests for Tramp Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-30 17:38 ` Michael Albinus
     [not found]   ` <87jzug9m1x.fsf@ledu-giraud.fr>
2023-08-02 18:41     ` Michael Albinus
2023-08-03 17:22       ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-04  4:05         ` Michael Albinus
2023-08-04  7:51           ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-06  9:48             ` Michael Albinus
2023-08-06 11:31               ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-06 11:53                 ` Michael Albinus
2023-08-06 13:45                   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-06 13:51                     ` Michael Albinus

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).