bug#2217: [PATCH] add-log.el (add-log-current-defun-header-regexp): Improve docstring

bug#2217: [PATCH] add-log.el (add-log-current-defun-header-regexp): Improve docstring

[Jari Aalto]

Tags: patch

2009-02-06  Jari Aalto  <jari.aalto@cante.net>

       * add-log.el: Improve docstring by mentioning submatch 1.

From d936b3faf4372e5538bee950f2145870196e257c Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aalto@cante.net>
Date: Fri, 6 Feb 2009 06:01:53 +0200
Subject: [PATCH] lisp/add-log.el: (add-log-current-defun-header-regexp): Improve docstring

Signed-off-by: Jari Aalto <jari.aalto@cante.net>
---
 lisp/add-log.el |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/lisp/add-log.el b/lisp/add-log.el
index 00e3172..c43a548 100644
--- a/lisp/add-log.el
+++ b/lisp/add-log.el
@@ -1095,7 +1095,9 @@ Prefix arg means justify as well."
 \f
 (defcustom add-log-current-defun-header-regexp
   "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alpha:]]+\\)[ \t]*[:=]"
-  "Heuristic regexp used by `add-log-current-defun' for unknown major modes."
+  "Heuristic regexp used by `add-log-current-defun' for unknown major modes.
+The regular expression's submatch 1 is used for the text in '(parenthesis)'."
+text in '(parentheses)'."
   :type 'regexp
   :group 'change-log)
 
-- 
1.5.6.5

bug#2217: [PATCH] add-log.el (add-log-current-defun-header-regexp): Improve docstring

[Jari Aalto]

severity: minor
thanks

The value is also case sensitive. Here is slightly improved patch.

2009-02-06  Jari Aalto  <jari.aalto@cante.net>

       * add-log.el: Improve docstring by mentioning submatch 1.

From 60a95c697ccc35abbfce6950f081100549b0b3fd Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aalto@cante.net>
Date: Fri, 6 Feb 2009 06:25:04 +0200
Subject: [PATCH] lisp/add-log.el: (add-log-current-defun-header-regexp): Improve docstring

Signed-off-by: Jari Aalto <jari.aalto@cante.net>
---
 lisp/add-log.el |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/lisp/add-log.el b/lisp/add-log.el
index 00e3172..c63e96d 100644
--- a/lisp/add-log.el
+++ b/lisp/add-log.el
@@ -1095,7 +1095,9 @@ Prefix arg means justify as well."
 \f
 (defcustom add-log-current-defun-header-regexp
   "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alpha:]]+\\)[ \t]*[:=]"
-  "Heuristic regexp used by `add-log-current-defun' for unknown major modes."
+  "Heuristic regexp used by `add-log-current-defun' for unknown major modes.
+The regular expression's submatch 1 is used for the text in '(parenthesis)'.
+The value is case-sensitive."
   :type 'regexp
   :group 'change-log)
 
-- 
1.5.6.5

bug#2217: marked as done ([PATCH] add-log.el (add-log-current-defun-header-regexp): Improve docstring)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 942 bytes --]


Your message dated Sun, 05 Jul 2009 00:54:21 -0400
with message-id <87skhbhgqq.fsf@stupidchicken.com>
and subject line Re: [PATCH] add-log.el (add-log-current-defun-header-regexp): Improve docstring
has caused the Emacs bug report #2217,
regarding [PATCH] add-log.el (add-log-current-defun-header-regexp): Improve docstring
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
2217: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2217
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3343 bytes --]

From: Jari Aalto <jari.aalto@cante.net>
To: Emacs bug BTS <submit@emacsbugs.donarmstrong.com>
Subject: [PATCH] add-log.el (add-log-current-defun-header-regexp): Improve docstring
Date: Fri, 06 Feb 2009 06:02:24 +0200
Message-ID: <87eiyc5i27.fsf@jondo.cante.net>

Tags: patch

2009-02-06  Jari Aalto  <jari.aalto@cante.net>

       * add-log.el: Improve docstring by mentioning submatch 1.

From d936b3faf4372e5538bee950f2145870196e257c Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aalto@cante.net>
Date: Fri, 6 Feb 2009 06:01:53 +0200
Subject: [PATCH] lisp/add-log.el: (add-log-current-defun-header-regexp): Improve docstring

Signed-off-by: Jari Aalto <jari.aalto@cante.net>
---
 lisp/add-log.el |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/lisp/add-log.el b/lisp/add-log.el
index 00e3172..c43a548 100644
--- a/lisp/add-log.el
+++ b/lisp/add-log.el
@@ -1095,7 +1095,9 @@ Prefix arg means justify as well."
 \f
 (defcustom add-log-current-defun-header-regexp
   "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alpha:]]+\\)[ \t]*[:=]"
-  "Heuristic regexp used by `add-log-current-defun' for unknown major modes."
+  "Heuristic regexp used by `add-log-current-defun' for unknown major modes.
+The regular expression's submatch 1 is used for the text in '(parenthesis)'."
+text in '(parentheses)'."
   :type 'regexp
   :group 'change-log)
 
-- 
1.5.6.5




[-- Attachment #3: Type: message/rfc822, Size: 1610 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Jari Aalto <jari.aalto@cante.net>
Cc: 2217-done@emacsbugs.donarmstrong.com
Subject: Re: [PATCH] add-log.el (add-log-current-defun-header-regexp): Improve docstring
Date: Sun, 05 Jul 2009 00:54:21 -0400
Message-ID: <87skhbhgqq.fsf@stupidchicken.com>

> * add-log.el: Improve docstring by mentioning submatch 1.

I checked in a slightly different fix.  Thanks for reporting the
problem.