* bug#5536: set-face-attribute doesn't work correctly
@ 2010-02-06 15:29 sj
2010-02-07 4:14 ` Chong Yidong
0 siblings, 1 reply; 2+ messages in thread
From: sj @ 2010-02-06 15:29 UTC (permalink / raw)
To: 5536
[-- Attachment #1: Type: text/plain, Size: 993 bytes --]
symptom:
(custom-face-attributes-get 'font-lock-keyword-face nil)
==> (:foreground "Cyan1")
(set-face-attribute 'font-lock-keyword-face nil
:family "verdana")
(custom-face-attributes-get 'font-lock-keyword-face nil)
==> (:foreground "Cyan1" :family "verdana")
--------------------------------------------------------------
(set-face-attribute 'font-lock-keyword-face nil
:family 'unspecified)
(custom-face-attributes-get 'font-lock-keyword-face nil)
==> (:foreground "Cyan1" :family "verdana") ;; wasn't removed
--------------------------------------------------------------
my solution:
modify faces.el file
===============================================================
738c738
< (when (stringp family)
---
> (when (or (stringp family)(eq family 'unspecified))
741c741
< (when (stringp foundry)
---
> (when (or (stringp foundry)(eq foundry 'unspecified))
===============================================================
[-- Attachment #2: Type: text/html, Size: 1223 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#5536: set-face-attribute doesn't work correctly
2010-02-06 15:29 bug#5536: set-face-attribute doesn't work correctly sj
@ 2010-02-07 4:14 ` Chong Yidong
0 siblings, 0 replies; 2+ messages in thread
From: Chong Yidong @ 2010-02-07 4:14 UTC (permalink / raw)
To: sj; +Cc: 5536
> (custom-face-attributes-get 'font-lock-keyword-face nil)
> ==> (:foreground "Cyan1")
> (set-face-attribute 'font-lock-keyword-face nil
> :family "verdana")
> (custom-face-attributes-get 'font-lock-keyword-face nil)
> ==> (:foreground "Cyan1" :family "verdana")
> (set-face-attribute 'font-lock-keyword-face nil
> :family 'unspecified)
> (custom-face-attributes-get 'font-lock-keyword-face nil)
> ==> (:foreground "Cyan1" :family "verdana")
>
> my solution:
> modify faces.el file
Thanks. Your patch looks reasonable, and I've checked it in.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-07 4:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-06 15:29 bug#5536: set-face-attribute doesn't work correctly sj
2010-02-07 4:14 ` Chong Yidong
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).