From: npostavs@users.sourceforge.net
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: 26360@debbugs.gnu.org
Subject: bug#26360: 26.0.50; ido-mode doesn't enable IDO for C-x 4 d
Date: Sat, 22 Apr 2017 17:40:18 -0400 [thread overview]
Message-ID: <87efwkp1dp.fsf@users.sourceforge.net> (raw)
In-Reply-To: <CAArVCkRZAq-yueedgcR-BEqyTFtB=HssXX7i+V95Oa7RczRv0Q@mail.gmail.com> (Philipp Stephani's message of "Sat, 22 Apr 2017 19:24:05 +0000")
Philipp Stephani <p.stephani2@gmail.com> writes:
> <npostavs@users.sourceforge.net> schrieb am Fr., 21. Apr. 2017 um 05:28 Uhr:
>>
>> Patch looks good, except the test seems redundant to me. I don't think
>> it's useful to test that a command is defined, or testing that specific
>> keybindings have been set (i.e., no need to test again that `defun' or
>> `define-key' are working).
>
>
> I've used a bit of TDD for this patch, thus the verbose test.
I suppose my real objection is that 'make check' is already taking long
enough that it makes me reluctant to use it, so I don't really want to
see more tests of such marginal utility. But any single test isn't
adding a significant amount of time, so I'm not going to insist.
In conclusion, feel free to push this; as far as I'm concerned, the
decision about the test is up to you.
next prev parent reply other threads:[~2017-04-22 21:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 12:20 bug#26360: 26.0.50; ido-mode doesn't enable IDO for C-x 4 d Philipp Stephani
2017-04-04 12:28 ` Noam Postavsky
2017-04-20 13:45 ` Philipp Stephani
2017-04-21 3:29 ` npostavs
2017-04-22 19:24 ` Philipp Stephani
2017-04-22 21:40 ` npostavs [this message]
2017-04-23 16:43 ` Philipp Stephani
2022-02-10 8:01 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efwkp1dp.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=26360@debbugs.gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).