From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#26360: 26.0.50; ido-mode doesn't enable IDO for C-x 4 d Date: Sat, 22 Apr 2017 17:40:18 -0400 Message-ID: <87efwkp1dp.fsf@users.sourceforge.net> References: <87efwmqvym.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1492897152 3492 195.159.176.226 (22 Apr 2017 21:39:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 22 Apr 2017 21:39:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) Cc: 26360@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 22 23:39:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d22kF-0000na-Jk for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Apr 2017 23:39:07 +0200 Original-Received: from localhost ([::1]:36944 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d22kL-0002mp-Cm for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Apr 2017 17:39:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d22kD-0002lp-FZ for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2017 17:39:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d22kA-0005KE-Cc for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2017 17:39:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36604) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d22kA-0005K6-7U for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2017 17:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d22k9-0003hv-T2 for bug-gnu-emacs@gnu.org; Sat, 22 Apr 2017 17:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Apr 2017 21:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26360 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 26360-submit@debbugs.gnu.org id=B26360.149289713614239 (code B ref 26360); Sat, 22 Apr 2017 21:39:01 +0000 Original-Received: (at 26360) by debbugs.gnu.org; 22 Apr 2017 21:38:56 +0000 Original-Received: from localhost ([127.0.0.1]:34803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d22k4-0003hb-10 for submit@debbugs.gnu.org; Sat, 22 Apr 2017 17:38:56 -0400 Original-Received: from mail-it0-f46.google.com ([209.85.214.46]:38343) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d22k2-0003hP-TB for 26360@debbugs.gnu.org; Sat, 22 Apr 2017 17:38:55 -0400 Original-Received: by mail-it0-f46.google.com with SMTP id e132so18771289ite.1 for <26360@debbugs.gnu.org>; Sat, 22 Apr 2017 14:38:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=b6m9h/b87eFrPp82scEXwQJGyTbbOWlgw/u3tffuSI8=; b=ThB3eoXQWyrqiZgAj9JlE3PClxE3hzkj0NLaTzb8u8IgtLosPbG0z6veno8BGxYz8w AQS83rFNVbu6q28iClxv8TycD+vCaSH3hYyNMlXveYWVdFJuMbJ/Pv/3yr1mMXYowQWN B7DnD0vRFveHZQ9Kl0QjXZKIICLBd1m4WD36FwoOwJV8jA1aGwvIlO+eu8FLCku+V9oA b42P0HAyzpf05WGRSjjlAhiF4GBSCVg9/BBI6st2fBbX1sQhKIgZKBvkxgvP+rkcXHGf YcHCPmePrWGKxo3qrJoisW/hmh191pCoT/tGAparrfrZRpgD5V5BVPARwUE8iq/UXXi7 dvqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=b6m9h/b87eFrPp82scEXwQJGyTbbOWlgw/u3tffuSI8=; b=DmPnQJHXe1hmEEKEWJVk6vx7SUKOKUiMeXuwokN5DWcOYVJvBKZ7vBMP6CAFlaI5DU 9ct/IVx+pxLap3sPadLQ6ZMMQUFcqn+YsQ5EbyUeAi4eWiAad1OYQcLHekvcQcf07Ki7 wNVueqCntxOh3AQRse09eTBSuRiQAfPsVv7LGprve2FPVvDszXkdNTdmjuSwwWnbS/52 mkqNEdnCWYaW7fkvZNj7YKEgD9XAMbuorknG9lDxiiQuhyTOe6gAMD6FHC/eYPyxfmSb 1jR/HqUYxPBs0NWfVhcESXHndqyRUoBdwi3+4sLN/9RyDdNwbZJr8fw9P3NV6aGl/hAB 3Fmw== X-Gm-Message-State: AN3rC/5BDprEZB15dyok3KqGCiGV7KPulS2kVUTNC/m5+T6E80SOeGWG hGaUABRbsGLqmw== X-Received: by 10.36.228.14 with SMTP id o14mr5590842ith.15.1492897129267; Sat, 22 Apr 2017 14:38:49 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 93sm5763548ioj.58.2017.04.22.14.38.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Apr 2017 14:38:48 -0700 (PDT) In-Reply-To: (Philipp Stephani's message of "Sat, 22 Apr 2017 19:24:05 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:131895 Archived-At: Philipp Stephani writes: > schrieb am Fr., 21. Apr. 2017 um 05:28 Uhr: >> >> Patch looks good, except the test seems redundant to me. I don't think >> it's useful to test that a command is defined, or testing that specific >> keybindings have been set (i.e., no need to test again that `defun' or >> `define-key' are working). > > > I've used a bit of TDD for this patch, thus the verbose test. I suppose my real objection is that 'make check' is already taking long enough that it makes me reluctant to use it, so I don't really want to see more tests of such marginal utility. But any single test isn't adding a significant amount of time, so I'm not going to insist. In conclusion, feel free to push this; as far as I'm concerned, the decision about the test is up to you.