From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 40532@debbugs.gnu.org, arnau@mini-dweeb.org
Subject: bug#40532: 28.0.50; eww/shr: Anchor link does not work
Date: Thu, 30 Apr 2020 11:15:32 +0100 [thread overview]
Message-ID: <87ees5z3cr.fsf@tcd.ie> (raw)
In-Reply-To: <878sid4nn7.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 30 Apr 2020 06:13:00 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>> I think this is OK for the release branch, but I'd like Lars to
>> comment. Lars, please chime in.
>
> I think this looks correct:
>
> - (let ((dom (plist-get eww-data :dom)))
> + (let ((dom (plist-get eww-data :dom))
> + (shr-target-id (url-target (url-generic-parse-url url))))
>
> But I haven't tested the code.
Why not move this binding back into eww-display-html instead, closer to
where shr-insert-document is called, for the benefit of other callers of
eww-display-html as well, and deviating the least from previous versions
of eww, as per the second proposed patch?
Thanks,
--
Basil
next prev parent reply other threads:[~2020-04-30 10:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 3:56 bug#40532: 28.0.50; eww/shr: Anchor link does not work Arnaud Fontaine
2020-04-22 6:24 ` Arnaud Fontaine
2020-04-22 11:38 ` Basil L. Contovounesios
2020-04-22 12:55 ` Basil L. Contovounesios
2020-04-25 14:46 ` Arnaud Fontaine
2020-04-25 20:28 ` Basil L. Contovounesios
2020-04-30 4:11 ` Lars Ingebrigtsen
2020-04-30 10:20 ` Basil L. Contovounesios
2020-05-08 1:10 ` Basil L. Contovounesios
2020-05-12 4:57 ` Arnaud Fontaine
2020-05-21 22:34 ` Basil L. Contovounesios
2020-05-19 12:23 ` Lars Ingebrigtsen
2020-05-21 22:34 ` Basil L. Contovounesios
2020-06-13 15:06 ` Basil L. Contovounesios
2020-06-18 15:54 ` Basil L. Contovounesios
2020-04-22 13:53 ` Eli Zaretskii
2020-04-22 15:44 ` Basil L. Contovounesios
2020-04-22 15:57 ` Eli Zaretskii
2020-04-22 16:15 ` Basil L. Contovounesios
2020-04-22 16:21 ` Eli Zaretskii
2020-04-22 22:32 ` Basil L. Contovounesios
2020-04-22 20:10 ` Arnaud Fontaine
2020-04-22 22:32 ` Basil L. Contovounesios
2020-04-25 10:14 ` Eli Zaretskii
2020-04-30 4:13 ` Lars Ingebrigtsen
2020-04-30 10:15 ` Basil L. Contovounesios [this message]
2020-04-30 22:09 ` Lars Ingebrigtsen
2020-05-03 23:49 ` Basil L. Contovounesios
2020-05-07 4:02 ` Arnaud Fontaine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ees5z3cr.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=40532@debbugs.gnu.org \
--cc=arnau@mini-dweeb.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).