From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#40532: 28.0.50; eww/shr: Anchor link does not work Date: Thu, 30 Apr 2020 11:15:32 +0100 Message-ID: <87ees5z3cr.fsf@tcd.ie> References: <87sghckn7p.fsf@milkypond.org> <87o8rk597f.fsf@milkypond.org> <87blnj92dy.fsf@tcd.ie> <83wo67eien.fsf@gnu.org> <87h7xbjzjh.fsf@tcd.ie> <83r1wfecoc.fsf@gnu.org> <838sij98im.fsf@gnu.org> <878sid4nn7.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="7271"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 40532@debbugs.gnu.org, arnau@mini-dweeb.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 30 12:20:06 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jU6IY-0001og-Jp for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Apr 2020 12:20:06 +0200 Original-Received: from localhost ([::1]:43446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jU6IX-00087F-4Z for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Apr 2020 06:20:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52272) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jU6Hv-00084d-W7 for bug-gnu-emacs@gnu.org; Thu, 30 Apr 2020 06:19:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jU6Ec-000582-OE for bug-gnu-emacs@gnu.org; Thu, 30 Apr 2020 06:19:27 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33838) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jU6Ec-00056P-AR for bug-gnu-emacs@gnu.org; Thu, 30 Apr 2020 06:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jU6Ec-0001DC-3r for bug-gnu-emacs@gnu.org; Thu, 30 Apr 2020 06:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Apr 2020 10:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40532 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 40532-submit@debbugs.gnu.org id=B40532.15882417434632 (code B ref 40532); Thu, 30 Apr 2020 10:16:02 +0000 Original-Received: (at 40532) by debbugs.gnu.org; 30 Apr 2020 10:15:43 +0000 Original-Received: from localhost ([127.0.0.1]:45384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jU6EJ-0001Ce-LG for submit@debbugs.gnu.org; Thu, 30 Apr 2020 06:15:43 -0400 Original-Received: from mail-pg1-f181.google.com ([209.85.215.181]:38710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jU6EI-0001CR-5U for 40532@debbugs.gnu.org; Thu, 30 Apr 2020 06:15:42 -0400 Original-Received: by mail-pg1-f181.google.com with SMTP id l25so207623pgc.5 for <40532@debbugs.gnu.org>; Thu, 30 Apr 2020 03:15:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=rSJXw7K+hAXlBWWYM1xlytq8j+JQX/tu5KHmhrhpXjI=; b=KUTSuh2Ybs0q+8deM6V8joWTzsAUkJK3ndoZFAk/i/0ZLDEm3vgsUVZ53WdCTtsT+O 06qHQaOlhYTj9FEAIMsOqM9Lp/6a0QTr3yjpdGyqKOi256zDrdw5D7BjYokPjyDmGmN0 bPDQS6ie0M8/qoAKE4ltitknmM7auwHJfzwrzJ4yByvavKvMONCYpU06sMAx4r7OeJOa MMtFGU9FXNvkAlNIYY5TpFsGD1CuFd4wusR8JnkoU9H9WO9T0EvRhwKMwZdChLCwVyyc q76FliSw9PTF36sbKVJ1dTQPiXFH20zfA4pcejfZFHmQu9dn4thq+rx0cw7G4YdA73Rm vgkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=rSJXw7K+hAXlBWWYM1xlytq8j+JQX/tu5KHmhrhpXjI=; b=L4t4PIskRpPCbC26HnsSAYQYqdm5dM+KYBm2jJL48ihSDh6QBqt+/1IgGKkMwTvOey wma8GkuJmWkDNrkN5p5MSnuZtz9PFW1+VqeRKMdHBpAPunCBrXqZz5PRSyWJIx3uq68R 1K1P2RwvNbdUlrGPRC2j82yczDLDX1v2KTcDnLeduwj25vOInpIjbzdiykAOdtc23HwC 7OSGRdravVq3HQJcnDac38dQO5gpgGobcvd8mHUprqG+v84hDZxx1nVLffxj3sYVIE93 +spLYzzryET49LB7l4sOBfvXF8P1ZzPP7Fhpr7KmbI5s1ZlqRRQ1nF0MLwh9Vgq8kbzz KijA== X-Gm-Message-State: AGi0PuYvsHejAThP6afH8d3qdlcPFSVnT1hUa+RqniCr8npGKc+tIeEv q+J0/O+L0YJkLI3KAVk8qefZwg== X-Google-Smtp-Source: APiQypJg0AOSbhOE2Q/h3JNOfPz6iy0cZDt7V8AnTW/068tqaiHeR/WGjlKaqbY05E4f0fkmIWUE2A== X-Received: by 2002:aa7:8e8b:: with SMTP id a11mr2819941pfr.62.1588241736205; Thu, 30 Apr 2020 03:15:36 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id w11sm3183178pfq.100.2020.04.30.03.15.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2020 03:15:35 -0700 (PDT) In-Reply-To: <878sid4nn7.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 30 Apr 2020 06:13:00 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179382 Archived-At: Lars Ingebrigtsen writes: > Eli Zaretskii writes: > >> I think this is OK for the release branch, but I'd like Lars to >> comment. Lars, please chime in. > > I think this looks correct: > > - (let ((dom (plist-get eww-data :dom))) > + (let ((dom (plist-get eww-data :dom)) > + (shr-target-id (url-target (url-generic-parse-url url)))) > > But I haven't tested the code. Why not move this binding back into eww-display-html instead, closer to where shr-insert-document is called, for the benefit of other callers of eww-display-html as well, and deviating the least from previous versions of eww, as per the second proposed patch? Thanks, -- Basil