From: Juri Linkov <juri@linkov.net>
To: "João Távora" <joaotavora@gmail.com>
Cc: Andrew Schwartzmeyer <andrew@schwartzmeyer.com>, 41633@debbugs.gnu.org
Subject: bug#41633: Prompts incorrect for multi-occur and multi-isearch when using fido-mode
Date: Tue, 02 Jun 2020 01:49:46 +0300 [thread overview]
Message-ID: <87eeqys8ol.fsf@mail.linkov.net> (raw)
In-Reply-To: <87zh9nn7os.fsf@gmail.com> ("João Távora"'s message of "Sun, 31 May 2020 21:57:55 +0100")
> Thanks for the report. I don't have anything to comment here
> specifically, since I'm not familiar with the modes that you propose
> patching, so let's wait for someone more knowledgeable with those modes.
I don't know who is more knowledgeable since I just blindly
copied that ugly ‘(eq read-buffer-function #'ido-read-buffer)’
from multi-occur to multi-isearch-read-buffers.
Also I see that the patch that Andrew sent works fine in multi-isearch-files.
> However, at first sight, it doesn't seem to be particularly off the
> mark, except that a user might change that binding and break it. Maybe
> a better, more generic fix would be ask the current minibuffer for the
> answer, perhaps by searching the keymap for the keybinding that maps to
> a command symbol that has a certain property set on it (and then
> fido-mode and ido-mode would play ball). But maybe that's too
> complex...
Something like this is needed indeed, not too complicated.
If it's not easy to just rephrase the prompt to avoid mentions of
the key, then I suggest to display the string returned from
(substitute-command-keys "(\\[exit-minibuffer] to end): ")
called in the minibuffer.
next prev parent reply other threads:[~2020-06-01 22:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 19:37 bug#41633: Prompts incorrect for multi-occur and multi-isearch when using fido-mode Andrew Schwartzmeyer
2020-05-31 20:57 ` João Távora
2020-06-01 22:49 ` Juri Linkov [this message]
2020-09-27 13:33 ` Lars Ingebrigtsen
2020-09-30 19:08 ` Juri Linkov
2020-10-01 1:03 ` Lars Ingebrigtsen
2020-10-04 19:31 ` Juri Linkov
2020-10-05 6:36 ` Lars Ingebrigtsen
2020-10-06 18:36 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eeqys8ol.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=41633@debbugs.gnu.org \
--cc=andrew@schwartzmeyer.com \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).