From: Lars Ingebrigtsen <larsi@gnus.org>
To: Juri Linkov <juri@linkov.net>
Cc: Andrew Schwartzmeyer <andrew@schwartzmeyer.com>,
41633@debbugs.gnu.org, joaotavora@gmail.com
Subject: bug#41633: Prompts incorrect for multi-occur and multi-isearch when using fido-mode
Date: Mon, 05 Oct 2020 08:36:07 +0200 [thread overview]
Message-ID: <877ds5rxgo.fsf@gnus.org> (raw)
In-Reply-To: <87a6x4wxbm.fsf@linkov.net> (Juri Linkov's message of "Sun, 04 Oct 2020 22:31:09 +0300")
Juri Linkov <juri@linkov.net> writes:
> I confirm it doesn't work with ido-everywhere.
> Maybe this is a better condition?
>
> diff --git a/lisp/replace.el b/lisp/replace.el
> index 4883ecfc8f..b717a2a25c 100644
> --- a/lisp/replace.el
> +++ b/lisp/replace.el
> @@ -1588,7 +1588,7 @@ multi-occur--prompt
> (concat
> "Next buffer to search "
> (cond
> - ((eq read-buffer-function #'ido-read-buffer)
> + ((bound-and-true-p ido-everywhere)
Makes sense, I think -- I think pretty much the only way to have ido
enabled in these two functions is to have ido-anywhere enabled? On the
other hand, perhaps somebody bound read-buffer-function "manually" here,
so perhaps something like
(or (eq read-buffer-function #'ido-read-buffer)
(bound-and-true-p ido-everywhere))
would be slightly more correct?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-10-05 6:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 19:37 bug#41633: Prompts incorrect for multi-occur and multi-isearch when using fido-mode Andrew Schwartzmeyer
2020-05-31 20:57 ` João Távora
2020-06-01 22:49 ` Juri Linkov
2020-09-27 13:33 ` Lars Ingebrigtsen
2020-09-30 19:08 ` Juri Linkov
2020-10-01 1:03 ` Lars Ingebrigtsen
2020-10-04 19:31 ` Juri Linkov
2020-10-05 6:36 ` Lars Ingebrigtsen [this message]
2020-10-06 18:36 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ds5rxgo.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=41633@debbugs.gnu.org \
--cc=andrew@schwartzmeyer.com \
--cc=joaotavora@gmail.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).