unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "J.P." <jp@neverwas.me>
To: Guy Gastineau <strings.stringsandstrings@gmail.com>
Cc: bug-gnu-emacs@gnu.org, emacs-erc@gnu.org
Subject: Re: 28.0.90; duplicate checks in erc--switch-to-buffer
Date: Fri, 28 Jan 2022 19:07:43 -0800	[thread overview]
Message-ID: <87ee4rutmo.fsf@neverwas.me> (raw)
In-Reply-To: <CAHgGP-JF0mD8KRxjhR0y_5y7m823FY4WV+V=ZG=ep_hb1WdU_w@mail.gmail.com> (Guy Gastineau's message of "Fri, 28 Jan 2022 19:10:00 -0500")

Hi Guy,

Thanks for following through with the report.

Guy Gastineau <strings.stringsandstrings@gmail.com> writes:

> The entire sexp starting with `with-current-buffer ...` can be removed
> without changing the semantics of erc--switch-to-buffer.

You're right, of course. In fact, the same commit that introduced
`erc--buffer-p' added the redundancy as well [1]. It looks like they saw
an opportunity to factor out that predicate and simply forgot to erase
the last of what they'd just obsoleted.

Are you sure you're not into cloning the repo and saving out a patch? No
worries if not. This is great regardless.

Thanks again,
J.P.


[1] https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f925fc93



  reply	other threads:[~2022-01-29  3:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-29  0:10 bug#53617: 28.0.90; duplicate checks in erc--switch-to-buffer Guy Gastineau
2022-01-29  3:07 ` J.P. [this message]
2022-01-29  3:13   ` Guy Gastineau
2022-01-29  3:30     ` J.P.
2022-01-29  4:29       ` Guy Gastineau
2022-01-29 23:49         ` bug#53617: " J.P.
     [not found]         ` <878ruyqf0b.fsf@neverwas.me>
2022-01-30  2:25           ` Guy Gastineau
2022-01-30  6:34           ` Eli Zaretskii
     [not found]           ` <83a6fdbulb.fsf@gnu.org>
2022-01-30 15:43             ` J.P.
     [not found]             ` <878rux9ql2.fsf@neverwas.me>
2022-01-30 16:00               ` Lars Ingebrigtsen
     [not found]               ` <87bkztb4di.fsf@gnus.org>
2022-01-30 16:25                 ` Guy Gastineau
2022-01-31  3:22                 ` Michael Olson
2022-01-31  3:30                   ` Emanuel Berg via General discussion about ERC
2022-01-31  3:38                     ` Emanuel Berg via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-31  5:35                   ` J.P.
2022-01-31 12:31                   ` Eli Zaretskii
2022-03-14 13:33           ` J.P.
2022-03-19 10:08             ` J.P.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ee4rutmo.fsf@neverwas.me \
    --to=jp@neverwas.me \
    --cc=bug-gnu-emacs@gnu.org \
    --cc=emacs-erc@gnu.org \
    --cc=strings.stringsandstrings@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).